Browse Source

Merge branch 'master' of github.com:Semantic-Org/Semantic-UI into next

next
jlukic 2 years ago
parent
commit
b19d2d3111
3 changed files with 8 additions and 3 deletions
  1. 6
      README.md
  2. 3
      RELEASE-NOTES.md
  3. 2
      src/definitions/modules/dimmer.js

6
README.md

@ -68,7 +68,7 @@ Although some components will work in IE9, [grids](http://semantic-ui.com/collec
## Community ## Community
#### Getting Help #### Getting Help
Please **do not post** usage questions to GitHub Issues. For these types of questions use our [Gitter chatroom] or [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui).
Please **do not post** usage questions to GitHub Issues. For these types of questions use our [Gitter chatroom][Gitter.im Room] or [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui).
#### Submitting Bugs and Enhancements #### Submitting Bugs and Enhancements
[GitHub Issues](https://github.com/Semantic-Org/Semantic-UI/issues) is for suggesting enhancements and reporting bugs. Before submiting a bug make sure you do the following: [GitHub Issues](https://github.com/Semantic-Org/Semantic-UI/issues) is for suggesting enhancements and reporting bugs. Before submiting a bug make sure you do the following:
@ -92,7 +92,7 @@ When adding pull requests, be sure to merge into the [next](https://github.com/S
Resource | Description Resource | Description
--- | --- | --- | --- |
Bugs & Feature Requests | All bug submission **require** a link to a test case, and a set of steps to reproduce the issue. You can make a test case by forking this [JSFiddle](https://jsfiddle.net/ca0rovs3/), then submit your [bug report on GitHub Issues](https://github.com/Semantic-Org/Semantic-UI/issues) Bugs & Feature Requests | All bug submission **require** a link to a test case, and a set of steps to reproduce the issue. You can make a test case by forking this [JSFiddle](https://jsfiddle.net/ca0rovs3/), then submit your [bug report on GitHub Issues](https://github.com/Semantic-Org/Semantic-UI/issues)
Live Chat | Join our [Gitter.im Room](https://gitter.im/Semantic-Org/Semantic-UI)
Live Chat | Join our [Gitter.im Room][Gitter.im Room]
Newsletter Updates | Sign up for updates at [semantic-ui.com](http://www.semantic-ui.com) Newsletter Updates | Sign up for updates at [semantic-ui.com](http://www.semantic-ui.com)
Additional Resources | Submit a question on [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui) or ask our [Google Group](https://groups.google.com/forum/#!forum/semantic-ui) Additional Resources | Submit a question on [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui) or ask our [Google Group](https://groups.google.com/forum/#!forum/semantic-ui)
@ -110,3 +110,5 @@ Guides & Tutorials | Help write guides and tutorials | [Join the discussion](htt
If you'd like to start a conversation about Semantic feel free to e-mail me at [jack@semantic-ui.com](mailto:jack@semantic-ui.com) If you'd like to start a conversation about Semantic feel free to e-mail me at [jack@semantic-ui.com](mailto:jack@semantic-ui.com)
<a href="http://packagequality.com/#?package=semantic-ui"><img src="http://npm.packagequality.com/badge/semantic-ui.png"/></a> <a href="http://packagequality.com/#?package=semantic-ui"><img src="http://npm.packagequality.com/badge/semantic-ui.png"/></a>
[Gitter.im Room]: https://gitter.im/Semantic-Org/Semantic-UI

3
RELEASE-NOTES.md

@ -2,6 +2,9 @@
### Version 2.5.0 - Oct 21, 2018 ### Version 2.5.0 - Oct 21, 2018
**Note**
> Special Note: If you run into any breaking changes with Gulp 4. Please reach out to me at jack@semantic-ui.com with bug reports
**Critical Fix** **Critical Fix**
- **CSS** - Fix extra semicolon causing CSS build of Semantic UI to fail compilation with various systems - **CSS** - Fix extra semicolon causing CSS build of Semantic UI to fail compilation with various systems

2
src/definitions/modules/dimmer.js

@ -151,7 +151,7 @@ $.fn.dimmer = function(parameters) {
event: { event: {
click: function(event) { click: function(event) {
module.verbose('Determining if event occured on dimmer', event);
module.verbose('Determining if event occurred on dimmer', event);
if( $dimmer.find(event.target).length === 0 || $(event.target).is(selector.content) ) { if( $dimmer.find(event.target).length === 0 || $(event.target).is(selector.content) ) {
module.hide(); module.hide();
event.stopImmediatePropagation(); event.stopImmediatePropagation();

Loading…
Cancel
Save