From 38de2884d3424eb300d35972f33d33bbc6aa6d58 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sat, 6 Mar 2021 19:21:20 -0500 Subject: [PATCH 1/3] Fix first link to gitter.im --- README.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 974c20e77..3c0446fe9 100644 --- a/README.md +++ b/README.md @@ -68,7 +68,7 @@ Although some components will work in IE9, [grids](http://semantic-ui.com/collec ## Community #### Getting Help -Please **do not post** usage questions to GitHub Issues. For these types of questions use our [Gitter chatroom] or [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui). +Please **do not post** usage questions to GitHub Issues. For these types of questions use our [Gitter chatroom][Gitter.im Room] or [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui). #### Submitting Bugs and Enhancements [GitHub Issues](https://github.com/Semantic-Org/Semantic-UI/issues) is for suggesting enhancements and reporting bugs. Before submiting a bug make sure you do the following: @@ -92,7 +92,7 @@ When adding pull requests, be sure to merge into the [next](https://github.com/S Resource | Description --- | --- | Bugs & Feature Requests | All bug submission **require** a link to a test case, and a set of steps to reproduce the issue. You can make a test case by forking this [JSFiddle](https://jsfiddle.net/ca0rovs3/), then submit your [bug report on GitHub Issues](https://github.com/Semantic-Org/Semantic-UI/issues) -Live Chat | Join our [Gitter.im Room](https://gitter.im/Semantic-Org/Semantic-UI) +Live Chat | Join our [Gitter.im Room][Gitter.im Room] Newsletter Updates | Sign up for updates at [semantic-ui.com](http://www.semantic-ui.com) Additional Resources | Submit a question on [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui) or ask our [Google Group](https://groups.google.com/forum/#!forum/semantic-ui) @@ -112,3 +112,5 @@ If you'd like to start a conversation about Semantic feel free to e-mail me at [ [![Flattr This](https://api.flattr.com/button/flattr-badge-large.png)](https://flattr.com/submit/auto?user_id=jlukic&url=https%3A%2F%2Fgithub.com%2Fjlukic%2FSemantic-UI) + +[Gitter.im Room]: https://gitter.im/Semantic-Org/Semantic-UI From 6879d3aa662dd39b96c8c9bb089b0d199de5e343 Mon Sep 17 00:00:00 2001 From: Ikko Ashimine Date: Sun, 5 Sep 2021 22:14:29 +0900 Subject: [PATCH 2/3] Fix typo in dimmer.js occured -> occurred --- src/definitions/modules/dimmer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/definitions/modules/dimmer.js b/src/definitions/modules/dimmer.js index 49bf63e60..a16cb663c 100755 --- a/src/definitions/modules/dimmer.js +++ b/src/definitions/modules/dimmer.js @@ -151,7 +151,7 @@ $.fn.dimmer = function(parameters) { event: { click: function(event) { - module.verbose('Determining if event occured on dimmer', event); + module.verbose('Determining if event occurred on dimmer', event); if( $dimmer.find(event.target).length === 0 || $(event.target).is(selector.content) ) { module.hide(); event.stopImmediatePropagation(); From 2ec0dd00fb715849433db855deba5d4f5ef0545d Mon Sep 17 00:00:00 2001 From: jlukic Date: Thu, 6 Oct 2022 11:31:43 -0400 Subject: [PATCH 3/3] Update rls notes --- RELEASE-NOTES.md | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 0fe483ecb..5f2587bfb 100755 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -1,5 +1,32 @@ ## RELEASE NOTES +### Version 2.5.0 - Oct 21, 2018 + +**Note** +> Special Note: If you run into any breaking changes with Gulp 4. Please reach out to me at jack@semantic-ui.com with bug reports + +**Critical Fix** +- **CSS** - Fix extra semicolon causing CSS build of Semantic UI to fail compilation with various systems + +**Breaking Changes** +- **Gulp** - Updated all tasks to work with Gulp 4. This should fix SUI to install correctly on Node 12 or greater (see [Gulp3 Issue](https://github.com/gulpjs/gulp/issues/2324) for more details) +- **Node** - Updated scripts to build in Node 18 via vanilla install. + +**Build** +- **Theme** - Allow site's global site theme to be missing #6876 **Thanks @cruzdanillo** +- **Meteor** - Fix issue with misuse of `api.addAssets` #6790 **Thanks @gimco** +- **Gulp** - Report errors in build #7005 **Thanks @bundyo** + +**Examples** +- **Modal** - Fixed mutation observer was not properly disconnected +- **Sticky** - Adds new example for sticky to highlight behavior when sticky/context height varies + +**Bug Fixes** +- **Dropdown** - Fix issue where dropdown menu could not open to right when in `right menu` inside a `ui menu` (See examples/sticky.html) for use-case +- **Sticky** - Fix issue where element might be `bound bottom` (fixed to bottom of context) if the sticky element is larger than the context +- **Sticky** - Fix issue when sticky size is larger than context size caused context `min-height` not to be set correctly. +- **Button** - Fix usage of loading on in labeled button #7023 thanks @flppv + ### Version 2.4.2 - Oct 21, 2018 **Build**