richard
/
SemanSemantic-UItic-UI
mirror of https://github.com/Semantic-Org/Semantic-UI.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Fixes on all modules where settings were shared across elements initialized at the same time instead of each module

pull/258/head
jlukic 11 years ago
parent
dbe1d0b7eb
commit
9b8d3bd55e
9 changed files with 108 additions and 96 deletions
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 12
      RELEASE NOTES.md
  2. 14
      src/modules/chatroom.js
  3. 19
      src/modules/checkbox.js
  4. 19
      src/modules/nag.js
  5. 26
      src/modules/popup.js
  6. 38
      src/modules/search.js
  7. 26
      src/modules/shape.js
  8. 24
      src/modules/sidebar.js
  9. 26
      src/modules/video.js

12
RELEASE NOTES.md
View File

@ -1,5 +1,17 @@
## RELEASE NOTES
### Version 0.4.4 - Oct 10, 2013
**Critical Fixes**
- Fixes on all modules where settings were shared across elements initialized at the same time instead of each module.
**Updates**
- Accordion now comes bundled with proper easing
**Fixes**
- Fixes inheritance issue where grid column may sometimes not appear the correct size
- Fixes modal hide/show dependency issue where dimmer would not always hide modal and vice-versa
### Version 0.4.3 - Oct 10, 2013
**Fixes**

14
src/modules/chatroom.js
View File

@ -13,19 +13,19 @@
$.fn.chatroom = function(parameters) {
var
settings = $.extend(true, {}, $.fn.chatroom.settings, parameters),
className = settings.className,
namespace = settings.namespace,
selector = settings.selector,
error = settings.error,
// hoist arguments
moduleArguments = arguments || false
;
$(this)
.each(function() {
var
settings = $.extend(true, {}, $.fn.chatroom.settings, parameters),
className = settings.className,
namespace = settings.namespace,
selector = settings.selector,
error = settings.error,
$module = $(this),
$expandButton = $module.find(selector.expandButton),

19
src/modules/checkbox.js
View File

@ -14,16 +14,6 @@
$.fn.checkbox = function(parameters) {
var
$allModules = $(this),
settings = $.extend(true, {}, $.fn.checkbox.settings, parameters),
className = settings.className,
namespace = settings.namespace,
error = settings.error,
eventNamespace = '.' + namespace,
moduleNamespace = 'module-' + namespace,
moduleSelector = $allModules.selector || '',
time = new Date().getTime(),
@ -38,6 +28,15 @@ $.fn.checkbox = function(parameters) {
$allModules
.each(function() {
var
settings = $.extend(true, {}, $.fn.checkbox.settings, parameters),
className = settings.className,
namespace = settings.namespace,
error = settings.error,
eventNamespace = '.' + namespace,
moduleNamespace = 'module-' + namespace,
$module = $(this),
$label = $(this).next(settings.selector.label).first(),
$input = $(this).find(settings.selector.input),

19
src/modules/nag.js
View File

@ -14,15 +14,6 @@
$.fn.nag = function(parameters) {
var
$allModules = $(this),
settings = $.extend(true, {}, $.fn.nag.settings, parameters),
className = settings.className,
selector = settings.selector,
error = settings.error,
namespace = settings.namespace,
eventNamespace = '.' + namespace,
moduleNamespace = namespace + '-module',
moduleSelector = $allModules.selector || '',
time = new Date().getTime(),
@ -36,6 +27,16 @@ $.fn.nag = function(parameters) {
$(this)
.each(function() {
var
settings = $.extend(true, {}, $.fn.nag.settings, parameters),
className = settings.className,
selector = settings.selector,
error = settings.error,
namespace = settings.namespace,
eventNamespace = '.' + namespace,
moduleNamespace = namespace + '-module',
$module = $(this),
$close = $module.find(selector.close),

26
src/modules/popup.js
View File

@ -16,10 +16,6 @@ $.fn.popup = function(parameters) {
$allModules = $(this),
$document = $(document),
settings = ( $.isPlainObject(parameters) )
? $.extend(true, {}, $.fn.popup.settings, parameters)
: $.fn.popup.settings,
moduleSelector = $allModules.selector || '',
time = new Date().getTime(),
@ -34,6 +30,19 @@ $.fn.popup = function(parameters) {
$allModules
.each(function() {
var
settings = ( $.isPlainObject(parameters) )
? $.extend(true, {}, $.fn.popup.settings, parameters)
: $.fn.popup.settings,
selector = settings.selector,
className = settings.className,
error = settings.error,
metadata = settings.metadata,
namespace = settings.namespace,
eventNamespace = '.' + settings.namespace,
moduleNamespace = settings.namespace + '-module',
$module = $(this),
$window = $(window),
@ -44,15 +53,6 @@ $.fn.popup = function(parameters) {
searchDepth = 0,
eventNamespace = '.' + settings.namespace,
moduleNamespace = settings.namespace + '-module',
selector = settings.selector,
className = settings.className,
error = settings.error,
metadata = settings.metadata,
namespace = settings.namespace,
element = this,
instance = $module.data(moduleNamespace),
module

38
src/modules/search.js
View File

@ -14,16 +14,6 @@
$.fn.search = function(source, parameters) {
var
$allModules = $(this),
settings = $.extend(true, {}, $.fn.search.settings, parameters),
className = settings.className,
selector = settings.selector,
error = settings.error,
namespace = settings.namespace,
eventNamespace = '.' + namespace,
moduleNamespace = namespace + '-module',
moduleSelector = $allModules.selector || '',
time = new Date().getTime(),
@ -37,15 +27,25 @@ $.fn.search = function(source, parameters) {
$(this)
.each(function() {
var
$module = $(this),
$prompt = $module.find(selector.prompt),
$searchButton = $module.find(selector.searchButton),
$results = $module.find(selector.results),
$result = $module.find(selector.result),
$category = $module.find(selector.category),
element = this,
instance = $module.data(moduleNamespace),
settings = $.extend(true, {}, $.fn.search.settings, parameters),
className = settings.className,
selector = settings.selector,
error = settings.error,
namespace = settings.namespace,
eventNamespace = '.' + namespace,
moduleNamespace = namespace + '-module',
$module = $(this),
$prompt = $module.find(selector.prompt),
$searchButton = $module.find(selector.searchButton),
$results = $module.find(selector.results),
$result = $module.find(selector.result),
$category = $module.find(selector.category),
element = this,
instance = $module.data(moduleNamespace),
module
;

26
src/modules/shape.js
View File

@ -15,19 +15,6 @@ $.fn.shape = function(parameters) {
var
$allModules = $(this),
moduleSelector = $allModules.selector || '',
settings = $.extend(true, {}, $.fn.shape.settings, parameters),
// internal aliases
namespace = settings.namespace,
selector = settings.selector,
error = settings.error,
className = settings.className,
// define namespaces for modules
eventNamespace = '.' + namespace,
moduleNamespace = 'module-' + namespace,
time = new Date().getTime(),
performance = [],
@ -40,6 +27,19 @@ $.fn.shape = function(parameters) {
$allModules
.each(function() {
var
moduleSelector = $allModules.selector || '',
settings = $.extend(true, {}, $.fn.shape.settings, parameters),
// internal aliases
namespace = settings.namespace,
selector = settings.selector,
error = settings.error,
className = settings.className,
// define namespaces for modules
eventNamespace = '.' + namespace,
moduleNamespace = 'module-' + namespace,
// selector cache
$module = $(this),
$sides = $module.find(selector.sides),

24
src/modules/sidebar.js
View File

@ -14,18 +14,6 @@
$.fn.sidebar = function(parameters) {
var
$allModules = $(this),
settings = ( $.isPlainObject(parameters) )
? $.extend(true, {}, $.fn.sidebar.settings, parameters)
: $.fn.sidebar.settings,
selector = settings.selector,
className = settings.className,
namespace = settings.namespace,
error = settings.error,
eventNamespace = '.' + namespace,
moduleNamespace = 'module-' + namespace,
moduleSelector = $allModules.selector || '',
time = new Date().getTime(),
@ -40,6 +28,18 @@ $.fn.sidebar = function(parameters) {
$allModules
.each(function() {
var
settings = ( $.isPlainObject(parameters) )
? $.extend(true, {}, $.fn.sidebar.settings, parameters)
: $.fn.sidebar.settings,
selector = settings.selector,
className = settings.className,
namespace = settings.namespace,
error = settings.error,
eventNamespace = '.' + namespace,
moduleNamespace = 'module-' + namespace,
$module = $(this),
$body = $('body'),

26
src/modules/video.js
View File

@ -15,10 +15,6 @@ $.fn.video = function(parameters) {
var
$allModules = $(this),
settings = ( $.isPlainObject(parameters) )
? $.extend(true, {}, $.fn.video.settings, parameters)
: $.fn.video.settings,
moduleSelector = $allModules.selector || '',
time = new Date().getTime(),
@ -28,21 +24,25 @@ $.fn.video = function(parameters) {
methodInvoked = (typeof query == 'string'),
queryArguments = [].slice.call(arguments, 1),
selector = settings.selector,
className = settings.className,
error = settings.error,
metadata = settings.metadata,
namespace = settings.namespace,
eventNamespace = '.' + namespace,
moduleNamespace = namespace + '-module',
invokedResponse
;
$allModules
.each(function() {
var
settings = ( $.isPlainObject(parameters) )
? $.extend(true, {}, $.fn.video.settings, parameters)
: $.fn.video.settings,
selector = settings.selector,
className = settings.className,
error = settings.error,
metadata = settings.metadata,
namespace = settings.namespace,
eventNamespace = '.' + namespace,
moduleNamespace = namespace + '-module',
$module = $(this),
$placeholder = $module.find(selector.placeholder),
$playButton = $module.find(selector.playButton),

Write Preview
Loading…
Cancel
Save