diff --git a/RELEASE NOTES.md b/RELEASE NOTES.md index d3208fe6b..07b2380ef 100755 --- a/RELEASE NOTES.md +++ b/RELEASE NOTES.md @@ -1,5 +1,17 @@ ## RELEASE NOTES +### Version 0.4.4 - Oct 10, 2013 + +**Critical Fixes** +- Fixes on all modules where settings were shared across elements initialized at the same time instead of each module. + +**Updates** +- Accordion now comes bundled with proper easing + +**Fixes** +- Fixes inheritance issue where grid column may sometimes not appear the correct size +- Fixes modal hide/show dependency issue where dimmer would not always hide modal and vice-versa + ### Version 0.4.3 - Oct 10, 2013 **Fixes** diff --git a/src/modules/chatroom.js b/src/modules/chatroom.js index 7de7a519e..e98b3f9ad 100755 --- a/src/modules/chatroom.js +++ b/src/modules/chatroom.js @@ -13,19 +13,19 @@ $.fn.chatroom = function(parameters) { var - settings = $.extend(true, {}, $.fn.chatroom.settings, parameters), - - className = settings.className, - namespace = settings.namespace, - selector = settings.selector, - error = settings.error, - // hoist arguments moduleArguments = arguments || false ; $(this) .each(function() { var + settings = $.extend(true, {}, $.fn.chatroom.settings, parameters), + + className = settings.className, + namespace = settings.namespace, + selector = settings.selector, + error = settings.error, + $module = $(this), $expandButton = $module.find(selector.expandButton), diff --git a/src/modules/checkbox.js b/src/modules/checkbox.js index 970cfc575..0662ebc77 100755 --- a/src/modules/checkbox.js +++ b/src/modules/checkbox.js @@ -14,16 +14,6 @@ $.fn.checkbox = function(parameters) { var $allModules = $(this), - - settings = $.extend(true, {}, $.fn.checkbox.settings, parameters), - - className = settings.className, - namespace = settings.namespace, - error = settings.error, - - eventNamespace = '.' + namespace, - moduleNamespace = 'module-' + namespace, - moduleSelector = $allModules.selector || '', time = new Date().getTime(), @@ -38,6 +28,15 @@ $.fn.checkbox = function(parameters) { $allModules .each(function() { var + settings = $.extend(true, {}, $.fn.checkbox.settings, parameters), + + className = settings.className, + namespace = settings.namespace, + error = settings.error, + + eventNamespace = '.' + namespace, + moduleNamespace = 'module-' + namespace, + $module = $(this), $label = $(this).next(settings.selector.label).first(), $input = $(this).find(settings.selector.input), diff --git a/src/modules/nag.js b/src/modules/nag.js index 8fe6cb0a6..25d520b49 100755 --- a/src/modules/nag.js +++ b/src/modules/nag.js @@ -14,15 +14,6 @@ $.fn.nag = function(parameters) { var $allModules = $(this), - settings = $.extend(true, {}, $.fn.nag.settings, parameters), - - className = settings.className, - selector = settings.selector, - error = settings.error, - namespace = settings.namespace, - - eventNamespace = '.' + namespace, - moduleNamespace = namespace + '-module', moduleSelector = $allModules.selector || '', time = new Date().getTime(), @@ -36,6 +27,16 @@ $.fn.nag = function(parameters) { $(this) .each(function() { var + settings = $.extend(true, {}, $.fn.nag.settings, parameters), + + className = settings.className, + selector = settings.selector, + error = settings.error, + namespace = settings.namespace, + + eventNamespace = '.' + namespace, + moduleNamespace = namespace + '-module', + $module = $(this), $close = $module.find(selector.close), diff --git a/src/modules/popup.js b/src/modules/popup.js index a033636c4..8d21187f4 100755 --- a/src/modules/popup.js +++ b/src/modules/popup.js @@ -16,10 +16,6 @@ $.fn.popup = function(parameters) { $allModules = $(this), $document = $(document), - settings = ( $.isPlainObject(parameters) ) - ? $.extend(true, {}, $.fn.popup.settings, parameters) - : $.fn.popup.settings, - moduleSelector = $allModules.selector || '', time = new Date().getTime(), @@ -34,6 +30,19 @@ $.fn.popup = function(parameters) { $allModules .each(function() { var + settings = ( $.isPlainObject(parameters) ) + ? $.extend(true, {}, $.fn.popup.settings, parameters) + : $.fn.popup.settings, + + selector = settings.selector, + className = settings.className, + error = settings.error, + metadata = settings.metadata, + namespace = settings.namespace, + + eventNamespace = '.' + settings.namespace, + moduleNamespace = settings.namespace + '-module', + $module = $(this), $window = $(window), @@ -44,15 +53,6 @@ $.fn.popup = function(parameters) { searchDepth = 0, - eventNamespace = '.' + settings.namespace, - moduleNamespace = settings.namespace + '-module', - - selector = settings.selector, - className = settings.className, - error = settings.error, - metadata = settings.metadata, - namespace = settings.namespace, - element = this, instance = $module.data(moduleNamespace), module diff --git a/src/modules/search.js b/src/modules/search.js index 32629d22e..b5e89730e 100755 --- a/src/modules/search.js +++ b/src/modules/search.js @@ -14,16 +14,6 @@ $.fn.search = function(source, parameters) { var $allModules = $(this), - settings = $.extend(true, {}, $.fn.search.settings, parameters), - - - className = settings.className, - selector = settings.selector, - error = settings.error, - namespace = settings.namespace, - - eventNamespace = '.' + namespace, - moduleNamespace = namespace + '-module', moduleSelector = $allModules.selector || '', time = new Date().getTime(), @@ -37,15 +27,25 @@ $.fn.search = function(source, parameters) { $(this) .each(function() { var - $module = $(this), - $prompt = $module.find(selector.prompt), - $searchButton = $module.find(selector.searchButton), - $results = $module.find(selector.results), - $result = $module.find(selector.result), - $category = $module.find(selector.category), - - element = this, - instance = $module.data(moduleNamespace), + settings = $.extend(true, {}, $.fn.search.settings, parameters), + + className = settings.className, + selector = settings.selector, + error = settings.error, + namespace = settings.namespace, + + eventNamespace = '.' + namespace, + moduleNamespace = namespace + '-module', + + $module = $(this), + $prompt = $module.find(selector.prompt), + $searchButton = $module.find(selector.searchButton), + $results = $module.find(selector.results), + $result = $module.find(selector.result), + $category = $module.find(selector.category), + + element = this, + instance = $module.data(moduleNamespace), module ; diff --git a/src/modules/shape.js b/src/modules/shape.js index ebc8c94c6..b7124ce7e 100755 --- a/src/modules/shape.js +++ b/src/modules/shape.js @@ -15,19 +15,6 @@ $.fn.shape = function(parameters) { var $allModules = $(this), - moduleSelector = $allModules.selector || '', - settings = $.extend(true, {}, $.fn.shape.settings, parameters), - - // internal aliases - namespace = settings.namespace, - selector = settings.selector, - error = settings.error, - className = settings.className, - - // define namespaces for modules - eventNamespace = '.' + namespace, - moduleNamespace = 'module-' + namespace, - time = new Date().getTime(), performance = [], @@ -40,6 +27,19 @@ $.fn.shape = function(parameters) { $allModules .each(function() { var + moduleSelector = $allModules.selector || '', + settings = $.extend(true, {}, $.fn.shape.settings, parameters), + + // internal aliases + namespace = settings.namespace, + selector = settings.selector, + error = settings.error, + className = settings.className, + + // define namespaces for modules + eventNamespace = '.' + namespace, + moduleNamespace = 'module-' + namespace, + // selector cache $module = $(this), $sides = $module.find(selector.sides), diff --git a/src/modules/sidebar.js b/src/modules/sidebar.js index 3236d104c..1f9282fa0 100755 --- a/src/modules/sidebar.js +++ b/src/modules/sidebar.js @@ -14,18 +14,6 @@ $.fn.sidebar = function(parameters) { var $allModules = $(this), - - settings = ( $.isPlainObject(parameters) ) - ? $.extend(true, {}, $.fn.sidebar.settings, parameters) - : $.fn.sidebar.settings, - - selector = settings.selector, - className = settings.className, - namespace = settings.namespace, - error = settings.error, - - eventNamespace = '.' + namespace, - moduleNamespace = 'module-' + namespace, moduleSelector = $allModules.selector || '', time = new Date().getTime(), @@ -40,6 +28,18 @@ $.fn.sidebar = function(parameters) { $allModules .each(function() { var + settings = ( $.isPlainObject(parameters) ) + ? $.extend(true, {}, $.fn.sidebar.settings, parameters) + : $.fn.sidebar.settings, + + selector = settings.selector, + className = settings.className, + namespace = settings.namespace, + error = settings.error, + + eventNamespace = '.' + namespace, + moduleNamespace = 'module-' + namespace, + $module = $(this), $body = $('body'), diff --git a/src/modules/video.js b/src/modules/video.js index 881591f61..db4741f18 100755 --- a/src/modules/video.js +++ b/src/modules/video.js @@ -15,10 +15,6 @@ $.fn.video = function(parameters) { var $allModules = $(this), - settings = ( $.isPlainObject(parameters) ) - ? $.extend(true, {}, $.fn.video.settings, parameters) - : $.fn.video.settings, - moduleSelector = $allModules.selector || '', time = new Date().getTime(), @@ -28,21 +24,25 @@ $.fn.video = function(parameters) { methodInvoked = (typeof query == 'string'), queryArguments = [].slice.call(arguments, 1), - selector = settings.selector, - className = settings.className, - error = settings.error, - metadata = settings.metadata, - namespace = settings.namespace, - - eventNamespace = '.' + namespace, - moduleNamespace = namespace + '-module', - invokedResponse ; $allModules .each(function() { var + settings = ( $.isPlainObject(parameters) ) + ? $.extend(true, {}, $.fn.video.settings, parameters) + : $.fn.video.settings, + + selector = settings.selector, + className = settings.className, + error = settings.error, + metadata = settings.metadata, + namespace = settings.namespace, + + eventNamespace = '.' + namespace, + moduleNamespace = namespace + '-module', + $module = $(this), $placeholder = $module.find(selector.placeholder), $playButton = $module.find(selector.playButton),