Browse Source

Fixes #625 Popup using title attribute would not restore its attribute properly with on click. Hide All is invoked on popup not the element causing it to popup, making cached data lost.

pull/622/merge
jlukic 10 years ago
parent
commit
7e42a34a36
1 changed files with 3 additions and 1 deletions
  1. 4
      src/modules/popup.js

4
src/modules/popup.js

@ -167,12 +167,14 @@ $.fn.popup = function(parameters) {
if(settings.inline) { if(settings.inline) {
module.verbose('Inserting popup element inline', $popup); module.verbose('Inserting popup element inline', $popup);
$popup $popup
.data(moduleNamespace, instance)
.insertAfter($module) .insertAfter($module)
; ;
} }
else { else {
module.verbose('Appending popup element to body', $popup); module.verbose('Appending popup element to body', $popup);
$popup $popup
.data(moduleNamespace, instance)
.appendTo( $context ) .appendTo( $context )
; ;
} }
@ -274,8 +276,8 @@ $.fn.popup = function(parameters) {
conditions: function() { conditions: function() {
if(module.cache && module.cache.title) { if(module.cache && module.cache.title) {
$module.attr('title', module.cache.title); $module.attr('title', module.cache.title);
module.verbose('Restoring original attributes', module.cache.title);
} }
module.verbose('Restoring original attributes', module.cache.title);
return true; return true;
} }
}, },

Loading…
Cancel
Save