From 7e42a34a362f6f1cfbbd9bf34ea05e712a7e4023 Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 14 Feb 2014 15:59:56 -0500 Subject: [PATCH] Fixes #625 Popup using title attribute would not restore its attribute properly with on click. Hide All is invoked on popup not the element causing it to popup, making cached data lost. --- src/modules/popup.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/popup.js b/src/modules/popup.js index e02d149d5..68fb167c7 100755 --- a/src/modules/popup.js +++ b/src/modules/popup.js @@ -167,12 +167,14 @@ $.fn.popup = function(parameters) { if(settings.inline) { module.verbose('Inserting popup element inline', $popup); $popup + .data(moduleNamespace, instance) .insertAfter($module) ; } else { module.verbose('Appending popup element to body', $popup); $popup + .data(moduleNamespace, instance) .appendTo( $context ) ; } @@ -274,8 +276,8 @@ $.fn.popup = function(parameters) { conditions: function() { if(module.cache && module.cache.title) { $module.attr('title', module.cache.title); + module.verbose('Restoring original attributes', module.cache.title); } - module.verbose('Restoring original attributes', module.cache.title); return true; } },