Browse Source

Fixes indeterminate radio checkboxes in chrome, adds definition table new class names

api-progress
Jack Lukic 8 years ago
parent
commit
2e601695e5
3 changed files with 16 additions and 11 deletions
  1. 8
      RELEASE-NOTES.md
  2. 3
      src/definitions/collections/table.less
  3. 16
      src/definitions/modules/checkbox.less

8
RELEASE-NOTES.md

@ -14,6 +14,7 @@
-**Divider** - Fixed issue where descenders like "g" would be cut off in `horizontal divider` #3585 -**Divider** - Fixed issue where descenders like "g" would be cut off in `horizontal divider` #3585
**Bugs** **Bugs**
- **Checkbox** - Fixed a chrome issue where radio buttons may receive `indeterminate` styles when user has not yet interacted with the page
- **Dropdown** - Fixed issue where `apiSettings` was not defaulting to use `cache: 'local'` as specified in the docs - **Dropdown** - Fixed issue where `apiSettings` was not defaulting to use `cache: 'local'` as specified in the docs
- **Dropdown** - Fixed issue where long dropdown text entry with `allowAdditions` would cause input to mistakingly drop to next line early #3743 - **Dropdown** - Fixed issue where long dropdown text entry with `allowAdditions` would cause input to mistakingly drop to next line early #3743
- **Dropdown** - Fixed issue where dropdowns with sub-menus would not properly activate on mobile #3183 - **Dropdown** - Fixed issue where dropdowns with sub-menus would not properly activate on mobile #3183
@ -24,7 +25,7 @@
- **List** - Fixed issue where `relaxed` and `very relaxed` lists included unnecessary padding on the first and last items #3710 - **List** - Fixed issue where `relaxed` and `very relaxed` lists included unnecessary padding on the first and last items #3710
- **List** - Fixed issue where divided lists had unnecessary padding on first and last items, in both horizontal and vertical layouts #3710 - **List** - Fixed issue where divided lists had unnecessary padding on first and last items, in both horizontal and vertical layouts #3710
- **List** - Fixed issue where bullets would be affected by font weight #3715 - **List** - Fixed issue where bullets would be affected by font weight #3715
- **Rating** - Fixed issue where rating would fire `onRate` when rating is initialized #3712
- **Rating** - Fixed issue where rating would not fire `onRate` when rating is initialized #3712
-**Table** - Fixed issue where `striped selectable` table would not correctly show hover color on striped rows -**Table** - Fixed issue where `striped selectable` table would not correctly show hover color on striped rows
-**Segment/Message** - Fixed issue where `top attached message` would have no border when attached to `segment` #3619 -**Segment/Message** - Fixed issue where `top attached message` would have no border when attached to `segment` #3619
-**Popup** - Fixed issue where checking `instanceof SVGGraphicsElement` caused error in IE11 #3043 -**Popup** - Fixed issue where checking `instanceof SVGGraphicsElement` caused error in IE11 #3043
@ -32,11 +33,14 @@
**Grid** - Fixed issue where `centered` content would cause `justified` content to appear aligned left. #3496 **Grid** - Fixed issue where `centered` content would cause `justified` content to appear aligned left. #3496
**Enhancements** **Enhancements**
-**Dropdown** - Using API with dropdown will now -**Dropdown** - Using API with dropdown will now
-**Rating** - Added new setting `fireOnInit` for rating, which defaults to `false`. When set to true `onRate` will fire when rating is initialized #3712 -**Rating** - Added new setting `fireOnInit` for rating, which defaults to `false`. When set to true `onRate` will fire when rating is initialized #3712
-**Site** `@px` and `@relativepx` i.e. `@relative12px` which can be used to return EM value of pixels are now extended to `@relative40px` -**Site** `@px` and `@relativepx` i.e. `@relative12px` which can be used to return EM value of pixels are now extended to `@relative40px`
-**Tabs** - Added option `deactivate`, defaults to `siblings` which will only deactivate tab activators that are DOM siblings elements to the activating element. Setting it to <code>'all'</code> will deactivate any other tab element initialized at the same time. -**Tabs** - Added option `deactivate`, defaults to `siblings` which will only deactivate tab activators that are DOM siblings elements to the activating element. Setting it to <code>'all'</code> will deactivate any other tab element initialized at the same time.
-**Table** - Added more granular variablaes for controlling style on first column in a `definition table`
-**Table** - `definition table` now supports `ignored` variation to force a `first-child` to ignore its default definition stylings
-**Table-- `definition table` now supports `definition` variation to specify definition styles on an element that is not `:first-child`
-**Table** - Added more granular variables for controlling style on first column in a `definition table`
**Docs** **Docs**
-**Form** - Added example of using custom rules with form -**Form** - Added example of using custom rules with form

3
src/definitions/collections/table.less

@ -268,7 +268,8 @@
} }
/* Highlight Defining Column */ /* Highlight Defining Column */
.ui.definition.table tr td:first-child {
.ui.definition.table tr td:first-child:not(.ignored),
.ui.definition.table tr td.definition {
background: @definitionColumnBackground; background: @definitionColumnBackground;
font-weight: @definitionColumnFontWeight; font-weight: @definitionColumnFontWeight;
color: @definitionColumnColor; color: @definitionColumnColor;

16
src/definitions/modules/checkbox.less

@ -196,13 +196,13 @@
Indeterminate Indeterminate
---------------*/ ---------------*/
.ui.checkbox input:indeterminate ~ .box:before,
.ui.checkbox input:indeterminate ~ label:before {
.ui.checkbox input:not([type=radio]):indeterminate ~ .box:before,
.ui.checkbox input:not([type=radio]):indeterminate ~ label:before {
background: @checkboxIndeterminateBackground; background: @checkboxIndeterminateBackground;
border-color: @checkboxIndeterminateBorderColor; border-color: @checkboxIndeterminateBorderColor;
} }
.ui.checkbox input:indeterminate ~ .box:after,
.ui.checkbox input:indeterminate ~ label:after {
.ui.checkbox input:not([type=radio]):indeterminate ~ .box:after,
.ui.checkbox input:not([type=radio]):indeterminate ~ label:after {
opacity: @checkboxIndeterminateCheckOpacity; opacity: @checkboxIndeterminateCheckOpacity;
color: @checkboxIndeterminateCheckColor; color: @checkboxIndeterminateCheckColor;
} }
@ -211,15 +211,15 @@
Active Focus Active Focus
---------------*/ ---------------*/
.ui.checkbox input:indeterminate:focus ~ .box:before,
.ui.checkbox input:indeterminate:focus ~ label:before,
.ui.checkbox input:not([type=radio]):indeterminate:focus ~ .box:before,
.ui.checkbox input:not([type=radio]):indeterminate:focus ~ label:before,
.ui.checkbox input:checked:focus ~ .box:before, .ui.checkbox input:checked:focus ~ .box:before,
.ui.checkbox input:checked:focus ~ label:before { .ui.checkbox input:checked:focus ~ label:before {
background: @checkboxActiveFocusBackground; background: @checkboxActiveFocusBackground;
border-color: @checkboxActiveFocusBorderColor; border-color: @checkboxActiveFocusBorderColor;
} }
.ui.checkbox input:indeterminate:focus ~ .box:after,
.ui.checkbox input:indeterminate:focus ~ label:after,
.ui.checkbox input:not([type=radio]):indeterminate:focus ~ .box:after,
.ui.checkbox input:not([type=radio]):indeterminate:focus ~ label:after,
.ui.checkbox input:checked:focus ~ .box:after, .ui.checkbox input:checked:focus ~ .box:after,
.ui.checkbox input:checked:focus ~ label:after { .ui.checkbox input:checked:focus ~ label:after {
color: @checkboxActiveFocusCheckColor; color: @checkboxActiveFocusCheckColor;

Loading…
Cancel
Save