From 2e601695e57db7b8d418bec220647f0915813314 Mon Sep 17 00:00:00 2001 From: Jack Lukic Date: Tue, 23 Feb 2016 19:08:04 -0500 Subject: [PATCH] Fixes indeterminate radio checkboxes in chrome, adds definition table new class names --- RELEASE-NOTES.md | 8 ++++++-- src/definitions/collections/table.less | 3 ++- src/definitions/modules/checkbox.less | 16 ++++++++-------- 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 2a0c9ab5e..893ef123c 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -14,6 +14,7 @@ -**Divider** - Fixed issue where descenders like "g" would be cut off in `horizontal divider` #3585 **Bugs** +- **Checkbox** - Fixed a chrome issue where radio buttons may receive `indeterminate` styles when user has not yet interacted with the page - **Dropdown** - Fixed issue where `apiSettings` was not defaulting to use `cache: 'local'` as specified in the docs - **Dropdown** - Fixed issue where long dropdown text entry with `allowAdditions` would cause input to mistakingly drop to next line early #3743 - **Dropdown** - Fixed issue where dropdowns with sub-menus would not properly activate on mobile #3183 @@ -24,7 +25,7 @@ - **List** - Fixed issue where `relaxed` and `very relaxed` lists included unnecessary padding on the first and last items #3710 - **List** - Fixed issue where divided lists had unnecessary padding on first and last items, in both horizontal and vertical layouts #3710 - **List** - Fixed issue where bullets would be affected by font weight #3715 -- **Rating** - Fixed issue where rating would fire `onRate` when rating is initialized #3712 +- **Rating** - Fixed issue where rating would not fire `onRate` when rating is initialized #3712 -**Table** - Fixed issue where `striped selectable` table would not correctly show hover color on striped rows -**Segment/Message** - Fixed issue where `top attached message` would have no border when attached to `segment` #3619 -**Popup** - Fixed issue where checking `instanceof SVGGraphicsElement` caused error in IE11 #3043 @@ -32,11 +33,14 @@ **Grid** - Fixed issue where `centered` content would cause `justified` content to appear aligned left. #3496 **Enhancements** + -**Dropdown** - Using API with dropdown will now -**Rating** - Added new setting `fireOnInit` for rating, which defaults to `false`. When set to true `onRate` will fire when rating is initialized #3712 -**Site** `@px` and `@relativepx` i.e. `@relative12px` which can be used to return EM value of pixels are now extended to `@relative40px` -**Tabs** - Added option `deactivate`, defaults to `siblings` which will only deactivate tab activators that are DOM siblings elements to the activating element. Setting it to 'all' will deactivate any other tab element initialized at the same time. --**Table** - Added more granular variablaes for controlling style on first column in a `definition table` +-**Table** - `definition table` now supports `ignored` variation to force a `first-child` to ignore its default definition stylings +-**Table-- `definition table` now supports `definition` variation to specify definition styles on an element that is not `:first-child` +-**Table** - Added more granular variables for controlling style on first column in a `definition table` **Docs** -**Form** - Added example of using custom rules with form diff --git a/src/definitions/collections/table.less b/src/definitions/collections/table.less index fe0a60edc..fc1dd762b 100755 --- a/src/definitions/collections/table.less +++ b/src/definitions/collections/table.less @@ -268,7 +268,8 @@ } /* Highlight Defining Column */ -.ui.definition.table tr td:first-child { +.ui.definition.table tr td:first-child:not(.ignored), +.ui.definition.table tr td.definition { background: @definitionColumnBackground; font-weight: @definitionColumnFontWeight; color: @definitionColumnColor; diff --git a/src/definitions/modules/checkbox.less b/src/definitions/modules/checkbox.less index 122baaeda..541fd8e3e 100755 --- a/src/definitions/modules/checkbox.less +++ b/src/definitions/modules/checkbox.less @@ -196,13 +196,13 @@ Indeterminate ---------------*/ -.ui.checkbox input:indeterminate ~ .box:before, -.ui.checkbox input:indeterminate ~ label:before { +.ui.checkbox input:not([type=radio]):indeterminate ~ .box:before, +.ui.checkbox input:not([type=radio]):indeterminate ~ label:before { background: @checkboxIndeterminateBackground; border-color: @checkboxIndeterminateBorderColor; } -.ui.checkbox input:indeterminate ~ .box:after, -.ui.checkbox input:indeterminate ~ label:after { +.ui.checkbox input:not([type=radio]):indeterminate ~ .box:after, +.ui.checkbox input:not([type=radio]):indeterminate ~ label:after { opacity: @checkboxIndeterminateCheckOpacity; color: @checkboxIndeterminateCheckColor; } @@ -211,15 +211,15 @@ Active Focus ---------------*/ -.ui.checkbox input:indeterminate:focus ~ .box:before, -.ui.checkbox input:indeterminate:focus ~ label:before, +.ui.checkbox input:not([type=radio]):indeterminate:focus ~ .box:before, +.ui.checkbox input:not([type=radio]):indeterminate:focus ~ label:before, .ui.checkbox input:checked:focus ~ .box:before, .ui.checkbox input:checked:focus ~ label:before { background: @checkboxActiveFocusBackground; border-color: @checkboxActiveFocusBorderColor; } -.ui.checkbox input:indeterminate:focus ~ .box:after, -.ui.checkbox input:indeterminate:focus ~ label:after, +.ui.checkbox input:not([type=radio]):indeterminate:focus ~ .box:after, +.ui.checkbox input:not([type=radio]):indeterminate:focus ~ label:after, .ui.checkbox input:checked:focus ~ .box:after, .ui.checkbox input:checked:focus ~ label:after { color: @checkboxActiveFocusCheckColor;