Browse Source

Fixes #2781 issue with 'is visible' not returning correctly from popup

pull/3321/head
Jack Lukic 9 years ago
parent
commit
2c6e2cc8e5
2 changed files with 4 additions and 3 deletions
  1. 1
      RELEASE-NOTES.md
  2. 6
      src/definitions/modules/popup.js

1
RELEASE-NOTES.md

@ -9,6 +9,7 @@
**Bug Fixes**
-**Flag** - A flag with no country set will no longer display an incorrect country flag. Thanks @space-alien #3333
-**Popup** - Fixed `is visible`, `is animating`, and `is fluid` to always return `true/false` and not the DOM element. #2781
-**Build Tools** - CSS build will now correctly call callback after both packaged files are created (compressed and uncompressed) Thanks @youngjay #3405
-**Search** - Search now correctly hides menu when an error message inside results is clicked. #3039
-**Sidebar** - Sidebar no longer includes `transform` rules on child elements, this was causing layout issues in some cases (for example dropdowns in sidebars) #3306

6
src/definitions/modules/popup.js

@ -1012,13 +1012,13 @@ $.fn.popup = function(parameters) {
return $module.hasClass(className.active);
},
animating: function() {
return ( $popup && $popup.hasClass(className.animating) );
return ($popup !== undefined && $popup.hasClass(className.animating) );
},
fluid: function() {
return ( $popup && $popup.hasClass(className.fluid));
return ($popup !== undefined && $popup.hasClass(className.fluid));
},
visible: function() {
return $popup && $popup.hasClass(className.visible);
return ($popup !== undefined && $popup.hasClass(className.visible));
},
dropdown: function() {
return $module.hasClass(className.dropdown);

Loading…
Cancel
Save