diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 1df8a0b54..bdd685200 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -9,6 +9,7 @@ **Bug Fixes** -**Flag** - A flag with no country set will no longer display an incorrect country flag. Thanks @space-alien #3333 +-**Popup** - Fixed `is visible`, `is animating`, and `is fluid` to always return `true/false` and not the DOM element. #2781 -**Build Tools** - CSS build will now correctly call callback after both packaged files are created (compressed and uncompressed) Thanks @youngjay #3405 -**Search** - Search now correctly hides menu when an error message inside results is clicked. #3039 -**Sidebar** - Sidebar no longer includes `transform` rules on child elements, this was causing layout issues in some cases (for example dropdowns in sidebars) #3306 diff --git a/src/definitions/modules/popup.js b/src/definitions/modules/popup.js index c9e42990c..25065138c 100644 --- a/src/definitions/modules/popup.js +++ b/src/definitions/modules/popup.js @@ -1012,13 +1012,13 @@ $.fn.popup = function(parameters) { return $module.hasClass(className.active); }, animating: function() { - return ( $popup && $popup.hasClass(className.animating) ); + return ($popup !== undefined && $popup.hasClass(className.animating) ); }, fluid: function() { - return ( $popup && $popup.hasClass(className.fluid)); + return ($popup !== undefined && $popup.hasClass(className.fluid)); }, visible: function() { - return $popup && $popup.hasClass(className.visible); + return ($popup !== undefined && $popup.hasClass(className.visible)); }, dropdown: function() { return $module.hasClass(className.dropdown);