Sergey M․
317f7ab634
[YoutubeDL] Fix format selection with filters ( Closes #10083 )
8 years ago
Sergey M․
4c3b16d5d1
[test_YoutubeDL] Add test for format_id format selection
8 years ago
Sergey M․
e0dccdd398
[test_YoutubeDL] PEP 8
8 years ago
Sergey M․
5d583bdf6c
[YoutubeDL] Improve _format_note
8 years ago
Sergey M․
86bf29050e
[test_YoutubeDL] Make test pass until more intelligent sort formats ( Closes #8462 )
8 years ago
remitamine
91cb6b5065
rename _parse_mpd to _parse_mpd_formats and add default value for mpd namespace
8 years ago
Yen Chi Hsuan
1df4141196
[test_YoutubeDL] Fix test_youtube_format_selection
Broken since a6c2c24479
. Thanks to
@jaimeMF and @anisse for pointing that out
8 years ago
Yen Chi Hsuan
b286f201a8
[YoutubeDL] Do not override ie_key in url_transparent
8 years ago
dyn888
b913348d5f
Test codec with a dot '.' in name selection.
8 years ago
Jaime Marquínez Ferrándiz
e37afbe0b8
[YoutubeDL] urlopen: disable the 'file:' protocol ( #8227 )
If someone is running youtube-dl on a server to deliver files, the user could input 'file:///some/important/file' and youtube-dl would save that file as a video giving access to sensitive information to the user.
'file:' urls can be filtered, but the user can use an URL to a crafted m3u8 manifest like:
#EXTM3U
#EXT-X-MEDIA-SEQUENCE:0
#EXTINF:10.0
file:///etc/passwd
#EXT-X-ENDLIST
With this patch 'file:' URLs raise URLError like for unknown protocols.
9 years ago
Jaime Marquínez Ferrándiz
232541df44
[YoutubeDL] format spec: correctly handle dashes and other unused operators
'mp4-baseline-16x9' must be handled as a single string, but the '-' was treated as an operator.
9 years ago
Jaime Marquínez Ferrándiz
d96d604e53
YoutubeDL: format spec: don't accept a bare '/' ( #6124 )
9 years ago
Jaime Marquínez Ferrándiz
0a31a35098
[YoutubeDL] format spec: add additional checks for invalid syntax
9 years ago
Jaime Marquínez Ferrándiz
bb8e553662
[YoutubeDL] format spec: Do not fail when a filter gives an empty result
For example with 'best[height<40]' we ended getting a 'IndexError: list index out of range'.
9 years ago
Jaime Marquínez Ferrándiz
f5f4a27a96
[YoutubeDL] format spec: fix handling of '/' with ','
When using 'bestvideo/best,bestaudio', 'bestvideo/best' must be set as the current_selector (instead of appending it to the selectors), otherwise when it gets the ',' it would append 'None' to the selectors.
9 years ago
Jaime Marquínez Ferrándiz
cf2ac6df68
[YoutubeDL] format spec: Fix handling of '+' with '/'
'bestvideo+bestaudio/best' was incorrectly interpreted as 'bestvideo+(bestaudio/best)', so it would fail if 'bestaudio' doesn't exist instead of falling back to 'best'.
9 years ago
Jaime Marquínez Ferrándiz
0130afb76e
[YoutubeDL] format spec: allow grouping specifiers with parentheses
9 years ago
Jaime Marquínez Ferrándiz
5acfa126c8
[YoutubeDL] format spec: treat 'all' like a normal specifier
So you can use filters with it, for example 'all[width>=400][width<=600]'.
9 years ago
Jaime Marquínez Ferrándiz
67134eaba1
[YoutubeDL] rework how the format spec is processed
The spec string is processed using 'tokenize.tokenize' to split it in words and operators, the filters are still processed using regular expressions.
This should make easier to allow grouping operators with parens.
9 years ago
Jaime Marquínez Ferrándiz
e9eaf3fbcf
[test/YoutubeDL] Add tests for 'playliststart', 'playlistend' and 'playlist_items'
9 years ago
Jaime Marquínez Ferrándiz
8dd5418803
Make 'best' format only match non-DASH formats ( closes #5554 )
Otherwise it's impossible to only download non-DASH formats, for example `best[height=?480]/best` would download a DASH video if it's the only one with height=480, instead for falling back to the second format specifier.
For audio only urls (soundcloud, bandcamp ...), the best audio will be downloaded as before.
9 years ago
Jaime Marquínez Ferrándiz
9f3fa89f7c
Remove the --max-quality option
It doesn't work well with 'bestvideo' and 'bestaudio' because they are usually before the max quality.
Format filters should be used instead, they are more flexible and don't require the requested quality to exist for each video.
9 years ago
Jaime Marquínez Ferrándiz
592e97e855
Postprocessors: use a list for the files that can be deleted
We could only know if we had to delete the original file, but this system allows to specify us more files (like subtitles).
9 years ago
Jaime Marquínez Ferrándiz
531980d89c
[test/YoutubeDL] test match_filter
9 years ago
Jaime Marquínez Ferrándiz
f20bf146e2
[test/YoutubeDL] split in two classes
The name was misleading
9 years ago
Jaime Marquínez Ferrándiz
8508557e77
[test/YoutubeDL] Use valid urls
It failed on python 3.4 when building the http_headers field
9 years ago
Jaime Marquínez Ferrándiz
98c70d6fc7
[YoutubeDL] only add normal subtitles to the 'requested_subtitles' field if 'writesubtitles' is True
9 years ago
Jaime Marquínez Ferrándiz
ab84349b16
[test/YoutubeDL] Add test for subtitles
Updated the offlinetest make target to not skip it
9 years ago
Jaime Marquínez Ferrándiz
0161353d7d
[test/test_YoutubeDL] Remove debug print call
9 years ago
Jaime Marquínez Ferrándiz
2b4ecde2c8
[test/YoutubeDL] Add a simple test for postprocesors
Just checks that the 'keepvideo' option works as intended.
9 years ago
Philipp Hagemeister
083c9df93b
[YoutubeDL] Allow filtering by properties ( Fixes #4584 )
9 years ago
Philipp Hagemeister
0217c78377
[YoutubeDL] Allow selection by more extensions
10 years ago
Philipp Hagemeister
c11125f9ed
[tests] Remove format 138 from tests ( #4559 )
10 years ago
Jouke Waleson
5f6a1245ff
PEP8 applied
10 years ago
Philipp Hagemeister
a053c3493a
[test_YoutubeDL] Reorder formats ( #3542 )
10 years ago
codesparkle
1c783bca88
fixed (what I assume was a typo) that caused test_format_note to always fail.
This test was introduced in c57f775710
.
10 years ago
Philipp Hagemeister
c57f775710
[YoutubeDL] Add simple tests for format_note ( Closes #2825 )
10 years ago
Philipp Hagemeister
3537b93d8a
[tests] Fix YoutubeDL tests
Since bec1fad
, the id, title, and url (also in formats) keys are mandatory. Change the tests to reflect that.
10 years ago
Jaime Marquínez Ferrándiz
bc6d597828
Add bestvideo and worstvideo to special format names ( #2163 )
10 years ago
Philipp Hagemeister
8908741806
Use unicode_literals in test_YoutubeDL
11 years ago
Philipp Hagemeister
ba7678f9cc
Add -f bestaudio ( Fixes #2163 )
11 years ago
Philipp Hagemeister
3d4a70b821
Add more tests for format selection
11 years ago
Philipp Hagemeister
8e3e03229e
[YoutubeDL] fix tests ( Closes #2036 )
11 years ago
Jaime Marquínez Ferrándiz
26e6393134
Set 'NA' as the default value for missing fields in the output template ( fixes #1931 )
Remove the `except KeyError` clause, it won't get raised anymore
11 years ago
Jaime Marquínez Ferrándiz
b6c45014ae
Set the extra_info inside YoutubeDL.process_ie_result and set only if the keys are missing
11 years ago
Philipp Hagemeister
646e17a53d
Fix YouTubeDL test
11 years ago
Jaime Marquínez Ferrándiz
49e86983e7
Allow to use the extension for the format selection
The best format with the extension is downloaded.
11 years ago
Jaime Marquínez Ferrándiz
a9c58ad945
Accept requested formats to be in the format 35/best ( closes #1552 )
The format selection code is now an independent function.
11 years ago
Philipp Hagemeister
f4d96df0f1
Extend #980 with --max-quality support
11 years ago
Philipp Hagemeister
5d254f776a
Fix test
11 years ago