Browse Source

[downloader/hls] Do not send 'q' to ffmpeg on Windows (Closes #8300)

master
Sergey M․ 8 years ago
parent
commit
56401e1e5f
1 changed files with 5 additions and 2 deletions
  1. 7
      youtube_dl/downloader/hls.py

7
youtube_dl/downloader/hls.py

@ -3,6 +3,7 @@ from __future__ import unicode_literals
import os import os
import re import re
import subprocess import subprocess
import sys
from .common import FileDownloader from .common import FileDownloader
from .fragment import FragmentFD from .fragment import FragmentFD
@ -57,8 +58,10 @@ class HlsFD(FileDownloader):
# subprocces.run would send the SIGKILL signal to ffmpeg and the # subprocces.run would send the SIGKILL signal to ffmpeg and the
# mp4 file couldn't be played, but if we ask ffmpeg to quit it # mp4 file couldn't be played, but if we ask ffmpeg to quit it
# produces a file that is playable (this is mostly useful for live # produces a file that is playable (this is mostly useful for live
# streams)
proc.communicate(b'q')
# streams). Note that Windows is not affected and produces playable
# files (see https://github.com/rg3/youtube-dl/issues/8300).
if sys.platform != 'win32':
proc.communicate(b'q')
raise raise
if retval == 0: if retval == 0:
fsize = os.path.getsize(encodeFilename(tmpfilename)) fsize = os.path.getsize(encodeFilename(tmpfilename))

Loading…
Cancel
Save