From bf38a822f9b9b94b8a7a71f1d3460202d087d086 Mon Sep 17 00:00:00 2001 From: MrS0m30n3 Date: Mon, 26 Sep 2016 15:08:52 +0300 Subject: [PATCH] Update TODO file & tags --- TODO | 42 ++++++++++++++++++++----------- youtube_dl_gui/downloadmanager.py | 2 +- youtube_dl_gui/mainframe.py | 22 ++++++---------- youtube_dl_gui/optionsframe.py | 2 +- 4 files changed, 38 insertions(+), 30 deletions(-) diff --git a/TODO b/TODO index 7feb8c2..805f602 100644 --- a/TODO +++ b/TODO @@ -1,20 +1,31 @@ +NEW_LAYOUT +========== +* Add context menu on wx.ListCtrl +* Change download msg: "Total Progress: 0% | Completed (1) Downloading (2) Queued (3)...etc" +* Create new button widget (groups, auto width) +* Create new button with two stages (like toggle) +* Add more statistics (Average download speed, etc) +* Adjust layout see #131 +* GUI command line builder like zenmap +* Swap some of the Error messages with Info +* Add clear list button ? +* Delete dialog, add cancel +* Icons theme selection (vote on github) +* Save freq. used paths to 'settings.json' instead of 'spaths' +* Update & re-enable options window + GUI === * Change MainFrame layout (see: https://docs.google.com/document/d/1UJ55sYepfk5Dl0nCJNz9fXRBgpG32v-4RwIqSdkXXVg/edit) -* Create new button widget (groups, auto width, General tab) -* Add more statistics (Average download speed) * Auto video format detection -* GUI command line builder like zenmap -* Swap some of the Error messages with Info -* Add clear list button -* Delete dialog add cancel +* Remember list of urls after closing & re-opening Structure ========= * Create devscripts/ directory and move all the utility scripts there * Create docs/ directory and move all the guides there -* Remove twodict from utils and use it directly from the library +* Remove twodict from utils and use it directly from the library [add as depen.] * Give icons the same name and keep them on different directories (see: https://github.com/deluge-torrent/deluge/tree/develop/deluge/ui/data/icons/hicolor) @@ -30,9 +41,8 @@ Localization Options ======= * Option for basic - advanced video formats -* Options reset delete - clear 'youtubedlg/spaths' * Option to disable-enable the 'download finished' pop up message -* Option to close the program after download process +* Option to enable-disable items deletion from the filesystem * Add 'native hls option' see issue #49 * Add Swedish on available subtitles * Add Hebrew on available subtitles @@ -42,14 +52,18 @@ Other * README.md add slackbuild * README.md add new images -* Save freq. used paths to 'settings.json' instead of 'spaths' +* Extract filename info on 'Already Downloaded' +* Update setup.py * Add FAQs into docs/ -* Add tests +* Upload new website for http://mrs0m30n3.github.io/youtube-dl-gui + +* Refactor * Review - rewrite threads communications -* Update setup.py * Add support for Python 3.* * Logging system using the Python 'logging' module * Use youtube-dl directly from python instead of using the subprocess module -* Upload new website for http://mrs0m30n3.github.io/youtube-dl-gui * Script to automatically update file contents like version from .github/ISSUE_TEMPLATE.md file, AUTHORS file, etc.. -* Extract filename info on 'Already Downloaded' + +Invalid +======= +* Options reset delete - clear 'youtubedlg/spaths' diff --git a/youtube_dl_gui/downloadmanager.py b/youtube_dl_gui/downloadmanager.py index 7b2bfd0..ac94ac3 100644 --- a/youtube_dl_gui/downloadmanager.py +++ b/youtube_dl_gui/downloadmanager.py @@ -660,7 +660,7 @@ class Worker(Thread): temp_dict[key] = data[key] # Build the playlist status if there is an update - # TODO re-implement this on DownloadItem or ListCtrl level? + # REFACTOR re-implement this on DownloadItem or ListCtrl level? if self._data['playlist_index'] is not None: if 'status' in temp_dict or 'playlist_index' in temp_dict: temp_dict['status'] = '{status} {index}/{size}'.format( diff --git a/youtube_dl_gui/mainframe.py b/youtube_dl_gui/mainframe.py index 87a30b3..644fd43 100644 --- a/youtube_dl_gui/mainframe.py +++ b/youtube_dl_gui/mainframe.py @@ -94,15 +94,15 @@ class MainFrame(wx.Frame): wxEVT_TEXT_PASTE = 'wxClipboardTextEvent' FRAMES_MIN_SIZE = (440, 360) - BUTTONS_SIZE = (-1, 30) # TODO remove not used anymore - BUTTONS_SPACE = (80, -1) # TODO remove not used anymore - SIZE_20 = 20 # TODO write directly + BUTTONS_SIZE = (-1, 30) # REFACTOR remove not used anymore + BUTTONS_SPACE = (80, -1) # REFACTOR remove not used anymore + SIZE_20 = 20 # REFACTOR write directly SIZE_10 = 10 SIZE_5 = 5 # Labels area URLS_LABEL = _("Enter URLs below") - DOWNLOAD_LABEL = _("Download") # TODO remove not used anymore + DOWNLOAD_LABEL = _("Download") # REFACTOR remove not used anymore UPDATE_LABEL = _("Update") OPTIONS_LABEL = _("Options") ERROR_LABEL = _("Error") @@ -309,8 +309,7 @@ class MainFrame(wx.Frame): self._status_bar_write(msg) def _update_pause_button(self, event): - #TODO keep all icons in a data stracture instead of creating them each time - #TODO create double stage buttons? + # REFACTOR keep all icons in a data stracture instead of creating them each time pause_icon = wx.Bitmap(os.path.join(self._pixmaps_path, "pause_32px.png")) resume_icon = wx.Bitmap(os.path.join(self._pixmaps_path, "play_arrow_32px.png")) @@ -575,7 +574,7 @@ class MainFrame(wx.Frame): return textctrl def _create_button(self, label, event_handler=None): - # TODO remove not used anymore + # REFACTOR remove not used anymore btn = wx.Button(self._panel, label=label, size=self.BUTTONS_SIZE) if event_handler is not None: @@ -813,7 +812,7 @@ class MainFrame(wx.Frame): click of the mouse. """ - #TODO Remove not used anymore + # REFACTOR Remove not used anymore if event.ClassName == self.wxEVT_TEXT_PASTE: self._paste_from_clipboard() else: @@ -879,7 +878,6 @@ class MainFrame(wx.Frame): self.opt_manager.options['main_win_size'] = self.GetSize() self.opt_manager.options['opts_win_size'] = self._options_frame.GetSize() - #TODO re-enable after options frame update #self._options_frame.save_all_options() self.opt_manager.save_to_file() @@ -1003,7 +1001,6 @@ class ListCtrl(wx.ListCtrl, ListCtrlAutoWidthMixin): return url in self._url_list def bind_item(self, download_item): - #TODO remove line below self.InsertStringItem(self._list_index, download_item.url) self.SetItemData(self._list_index, download_item.object_id) @@ -1013,12 +1010,9 @@ class ListCtrl(wx.ListCtrl, ListCtrlAutoWidthMixin): self._list_index += 1 def _update_from_item(self, row, download_item): - #print row, download_item.object_id for key in download_item.progress_stats: column = self.columns[key][0] - #TODO remove line below - #print row, column, download_item.progress_stats[key] self.SetStringItem(row, column, download_item.progress_stats[key]) def add_url(self, url): @@ -1099,7 +1093,7 @@ class ListCtrl(wx.ListCtrl, ListCtrlAutoWidthMixin): if column_item[3]: self.setResizeColumn(column_item[0]) -# TODO Extra widgets below should move to other module with widgets +# REFACTOR Extra widgets below should move to other module with widgets class ExtComboBox(wx.ComboBox): diff --git a/youtube_dl_gui/optionsframe.py b/youtube_dl_gui/optionsframe.py index 3361363..410622d 100644 --- a/youtube_dl_gui/optionsframe.py +++ b/youtube_dl_gui/optionsframe.py @@ -1486,7 +1486,7 @@ class LogGUI(wx.Frame): """ - #TODO move it on widgets module + # REFACTOR move it on widgets module TITLE = _("Log Viewer") FRAME_SIZE = (650, 200)