Browse Source

fix(auth): SAML authnContext parameter should be an array (#5290)

* saml auth: `authnContext` must be a list now

This fixes

    this.options.authnContext.forEach is not a function

when trying to login via SAML on wiki-js 2.5.281.

Reason for that is that `authnContext` must be a list now which is
apparently a breaking change that was missed while upgrading
passport-saml[1].

Resolves #5289

[1] https://github.com/node-saml/passport-saml/pull/615

* fix(auth): split authnContext for SAML authenticaiton module

Co-authored-by: Nicolas Giard <github@ngpixel.com>
pull/5304/head
Maximilian Bosch 2 years ago
committed by GitHub
parent
commit
b345375477
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
  1. 2
      server/modules/authentication/saml/authentication.js

2
server/modules/authentication/saml/authentication.js

@ -21,7 +21,7 @@ module.exports = {
wantAssertionsSigned: conf.wantAssertionsSigned,
acceptedClockSkewMs: _.toSafeInteger(conf.acceptedClockSkewMs),
disableRequestedAuthnContext: conf.disableRequestedAuthnContext,
authnContext: conf.authnContext,
authnContext: _.split(conf.authnContext, '|'),
racComparison: conf.racComparison,
forceAuthn: conf.forceAuthn,
passive: conf.passive,

Loading…
Cancel
Save