Browse Source

Code style and performance fixes

pull/2/head
NGPixel 8 years ago
parent
commit
9454065ab9
12 changed files with 57 additions and 54 deletions
  1. 42
      client/js/components/editor-codeblock.js
  2. 8
      client/js/components/editor-image.js
  3. 38
      client/js/components/editor.js
  4. 2
      controllers/uploads.js
  5. 2
      controllers/ws.js
  6. 2
      libs/git.js
  7. 2
      libs/internalAuth.js
  8. 2
      libs/local.js
  9. 2
      libs/markdown.js
  10. 5
      libs/uploads-agent.js
  11. 4
      libs/uploads.js
  12. 2
      libs/winston.js

42
client/js/components/editor-codeblock.js

@ -8,6 +8,27 @@ codeEditor.setOption('wrap', true);
let modelist = ace.require("ace/ext/modelist"); let modelist = ace.require("ace/ext/modelist");
// ACE - Mode Loader
let modelistLoaded = [];
let loadAceMode = (m) => {
return $.ajax({
url: '/js/ace/mode-' + m + '.js',
dataType: "script",
cache: true,
beforeSend: () => {
if(_.includes(modelistLoaded, m)) {
return false;
}
},
success: () => {
modelistLoaded.push(m);
}
});
};
// Vue Code Block instance
let vueCodeBlock = new Vue({ let vueCodeBlock = new Vue({
el: '#modal-editor-codeblock', el: '#modal-editor-codeblock',
data: { data: {
@ -39,23 +60,4 @@ let vueCodeBlock = new Vue({
} }
} }
});
// ACE - Mode Loader
let modelistLoaded = [];
let loadAceMode = (m) => {
return $.ajax({
url: '/js/ace/mode-' + m + '.js',
dataType: "script",
cache: true,
beforeSend: () => {
if(_.includes(modelistLoaded, m)) {
return false;
}
},
success: () => {
modelistLoaded.push(m);
}
});
}
});

8
client/js/components/editor-image.js

@ -186,7 +186,7 @@ let vueImage = new Vue({
vueImage.isLoadingText = 'Moving image...'; vueImage.isLoadingText = 'Moving image...';
vueImage.isLoading = true; vueImage.isLoading = true;
Vue.nextTick(() => { Vue.nextTick(() => {
socket.emit('uploadsMoveFile', { uid: uid, folder: fld }, (data) => {
socket.emit('uploadsMoveFile', { uid, folder: fld }, (data) => {
if(data.ok) { if(data.ok) {
vueImage.loadImages(); vueImage.loadImages();
} else { } else {
@ -311,7 +311,7 @@ let vueImage = new Vue({
position: (opt, x, y) => { position: (opt, x, y) => {
$(opt.$trigger).addClass('is-contextopen'); $(opt.$trigger).addClass('is-contextopen');
let trigPos = $(opt.$trigger).position(); let trigPos = $(opt.$trigger).position();
let trigDim = { w: $(opt.$trigger).width() / 2, h: $(opt.$trigger).height() / 2 }
let trigDim = { w: $(opt.$trigger).width() / 2, h: $(opt.$trigger).height() / 2 };
opt.$menu.css({ top: trigPos.top + trigDim.h, left: trigPos.left + trigDim.w }); opt.$menu.css({ top: trigPos.top + trigDim.h, left: trigPos.left + trigDim.w });
}, },
events: { events: {
@ -370,7 +370,7 @@ $('#btn-editor-uploadimage input').on('change', (ev) => {
vueImage.isLoading = true; vueImage.isLoading = true;
}, },
progress: function(progress) {
progress: (progress) => {
vueImage.isLoadingText = 'Uploading...' + Math.round(progress) + '%'; vueImage.isLoadingText = 'Uploading...' + Math.round(progress) + '%';
}, },
@ -398,7 +398,7 @@ $('#btn-editor-uploadimage input').on('change', (ev) => {
} }
}, },
error: function(error) {
error: (error) => {
alerts.pushError(error.message, this.upload.file.name); alerts.pushError(error.message, this.upload.file.name);
}, },

38
client/js/components/editor.js

@ -10,7 +10,7 @@ if($('#mk-editor').length === 1) {
Vue.filter('filesize', (v) => { Vue.filter('filesize', (v) => {
return _.toUpper(filesize(v)); return _.toUpper(filesize(v));
})
});
//=include editor-image.js //=include editor-image.js
//=include editor-codeblock.js //=include editor-codeblock.js
@ -170,26 +170,26 @@ if($('#mk-editor').length === 1) {
} }
}); });
}
//-> Save
//-> Save
$('.btn-edit-save, .btn-create-save').on('click', (ev) => {
$('.btn-edit-save, .btn-create-save').on('click', (ev) => {
$.ajax(window.location.href, {
data: {
markdown: mde.value()
},
dataType: 'json',
method: 'PUT'
}).then((rData, rStatus, rXHR) => {
if(rData.ok) {
window.location.assign('/' + pageEntryPath);
} else {
alerts.pushError('Something went wrong', rData.error);
}
}, (rXHR, rStatus, err) => {
alerts.pushError('Something went wrong', 'Save operation failed.');
});
$.ajax(window.location.href, {
data: {
markdown: mde.value()
},
dataType: 'json',
method: 'PUT'
}).then((rData, rStatus, rXHR) => {
if(rData.ok) {
window.location.assign('/' + pageEntryPath);
} else {
alerts.pushError('Something went wrong', rData.error);
}
}, (rXHR, rStatus, err) => {
alerts.pushError('Something went wrong', 'Save operation failed.');
}); });
});
}

2
controllers/uploads.js

@ -92,7 +92,7 @@ router.post('/img', lcdata.uploadImgHandler, (req, res, next) => {
return { return {
ok: false, ok: false,
msg: r.reason().message msg: r.reason().message
}
};
} }
}); });
res.json({ ok: true, results: uplResults }); res.json({ ok: true, results: uplResults });

2
controllers/ws.js

@ -21,7 +21,7 @@ module.exports = (socket) => {
cb = cb || _.noop; cb = cb || _.noop;
upl.getUploadsFolders().then((f) => { upl.getUploadsFolders().then((f) => {
return cb(f) || true; return cb(f) || true;
})
});
}); });
socket.on('uploadsCreateFolder', (data, cb) => { socket.on('uploadsCreateFolder', (data, cb) => {

2
libs/git.js

@ -111,7 +111,7 @@ module.exports = {
self._git.exec('config', ['--local', 'user.email', self._signature.email]) self._git.exec('config', ['--local', 'user.email', self._signature.email])
).then(() => { ).then(() => {
return self._git.exec('remote', ['add', 'origin', self._url]); return self._git.exec('remote', ['add', 'origin', self._url]);
})
});
} }
}); });

2
libs/internalAuth.js

@ -19,7 +19,7 @@ module.exports = {
generateKey() { generateKey() {
return crypto.randomBytes(20).toString('hex')
return crypto.randomBytes(20).toString('hex');
}, },

2
libs/local.js

@ -47,7 +47,7 @@ module.exports = {
this.uploadImgHandler = multer({ this.uploadImgHandler = multer({
storage: multer.diskStorage({ storage: multer.diskStorage({
destination: (req, f, cb) => { destination: (req, f, cb) => {
cb(null, path.resolve(ROOTPATH, appconfig.paths.data, 'temp-upload'))
cb(null, path.resolve(ROOTPATH, appconfig.paths.data, 'temp-upload'));
} }
}), }),
fileFilter: (req, f, cb) => { fileFilter: (req, f, cb) => {

2
libs/markdown.js

@ -86,7 +86,7 @@ const parseTree = (content) => {
content = heading.children[1].content; content = heading.children[1].content;
anchor = _.kebabCase(content); anchor = _.kebabCase(content);
} else { } else {
content = heading.content
content = heading.content;
anchor = _.kebabCase(heading.children.reduce((acc, t) => acc + t.content, "")); anchor = _.kebabCase(heading.children.reduce((acc, t) => acc + t.content, ""));
} }

5
libs/uploads-agent.js

@ -156,7 +156,7 @@ module.exports = {
return upl.watch(); return upl.watch();
})
});
}, },
@ -218,7 +218,7 @@ module.exports = {
filename: f, filename: f,
basename: fPathObj.name, basename: fPathObj.name,
filesize: s.size filesize: s.size
}
};
// Generate thumbnail // Generate thumbnail
@ -258,6 +258,7 @@ module.exports = {
* Generate thumbnail of image * Generate thumbnail of image
* *
* @param {String} sourcePath The source path * @param {String} sourcePath The source path
* @param {String} destPath The destination path
* @return {Promise<Object>} Promise returning the resized image info * @return {Promise<Object>} Promise returning the resized image info
*/ */
generateThumbnail(sourcePath, destPath) { generateThumbnail(sourcePath, destPath) {

4
libs/uploads.js

@ -95,7 +95,7 @@ module.exports = {
return db.UplFolder.findOne({ name: folderName }).then((f) => { return db.UplFolder.findOne({ name: folderName }).then((f) => {
return (f) ? path.resolve(this._uploadsPath, folderName) : false; return (f) ? path.resolve(this._uploadsPath, folderName) : false;
})
});
}, },
@ -180,7 +180,7 @@ module.exports = {
let self = this; let self = this;
let fUrlObj = url.parse(fUrl); let fUrlObj = url.parse(fUrl);
let fUrlFilename = _.last(_.split(fUrlObj.pathname, '/'))
let fUrlFilename = _.last(_.split(fUrlObj.pathname, '/'));
let destFolder = _.chain(fFolder).trim().toLower().value(); let destFolder = _.chain(fFolder).trim().toLower().value();
return upl.validateUploadsFolder(destFolder).then((destFolderPath) => { return upl.validateUploadsFolder(destFolder).then((destFolderPath) => {

2
libs/winston.js

@ -4,7 +4,7 @@ var winston = require('winston');
module.exports = (isDebug) => { module.exports = (isDebug) => {
winston.remove(winston.transports.Console)
winston.remove(winston.transports.Console);
winston.add(winston.transports.Console, { winston.add(winston.transports.Console, {
level: (isDebug) ? 'info' : 'warn', level: (isDebug) ? 'info' : 'warn',
prettyPrint: true, prettyPrint: true,

Loading…
Cancel
Save