Browse Source

fix: bypass page rule check for global permission check + handle missing page extra field

pull/2429/head
NGPixel 4 years ago
parent
commit
5295e413be
2 changed files with 9 additions and 1 deletions
  1. 3
      server/controllers/common.js
  2. 7
      server/core/auth.js

3
server/controllers/common.js

@ -148,6 +148,9 @@ router.get(['/e', '/e/*'], async (req, res, next) => {
await page.$relatedQuery('tags') await page.$relatedQuery('tags')
page.tags = _.map(page.tags, 'tag') page.tags = _.map(page.tags, 'tag')
// Handle missing extra field
page.extra = page.extra || { css: '', js: '' }
// -> Beautify Script CSS // -> Beautify Script CSS
if (!_.isEmpty(page.extra.css)) { if (!_.isEmpty(page.extra.css)) {
page.extra.css = new CleanCSS({ format: 'beautify' }).minify(page.extra.css).styles page.extra.css = new CleanCSS({ format: 'beautify' }).minify(page.extra.css).styles

7
server/core/auth.js

@ -226,8 +226,13 @@ module.exports = {
return false return false
} }
// Skip if no page rule to check
if (!page) {
return true
}
// Check Page Rules // Check Page Rules
if (page && user.groups) {
if (user.groups) {
let checkState = { let checkState = {
deny: false, deny: false,
match: false, match: false,

Loading…
Cancel
Save