From 98846e0e6602f8b86b468584137425ad32e54242 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jure=20=C5=A0orn?= <sornjure@gmail.com>
Date: Sun, 16 Feb 2025 07:44:02 +0100
Subject: [PATCH] Fixed dark theme banner

---
 index.html | 10 ++++++++--
 parse.js   | 10 ++++++++--
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/index.html b/index.html
index 8b26394..bb366d1 100644
--- a/index.html
+++ b/index.html
@@ -64,7 +64,12 @@
 </sup></p><p class="banner" style="margin-bottom: 20px; padding-bottom: 7px;"><img src="web/image_888.jpeg" alt="Monty Python"></p><script>
   // Changes the banner image and link-to-theme if "theme=dark" is in query string
   // or if browser prefers dark mode and theme is not explicitly set.
-  if ( (window.location.search.search(/[?&]theme=dark/) !== -1) || ((window.location.search.search(/[?&]theme=light/) == -1) && (window.matchMedia('(prefers-color-scheme: dark)').matches)) ) {
+
+const theme_not_set_in_query = window.location.search.search(/[?&]theme=light/) == -1
+const browser_prefers_dark = window.matchMedia('(prefers-color-scheme: dark)').matches;
+
+  if ((window.location.search.search(/[?&]theme=dark/) !== -1) || 
+      (theme_not_set_in_query && browser_prefers_dark)) {
     activateDarkMode();
   }
 
@@ -78,7 +83,8 @@
     img_dark.src = "web/image_orig_blue6.png";
     img_dark.alt = "Monthy Python";
     if ((window.location.search.search(/[?&]theme=dark2/) !== -1) ||
-        (window.location.search.search(/[?&]theme=dark3/) !== -1)) {
+        (window.location.search.search(/[?&]theme=dark3/) !== -1) ||
+        (theme_not_set_in_query && browser_prefers_dark)) {
       img_dark.style = "width: 910px;";
     } else {
       img_dark.style = "width: 960px;";
diff --git a/parse.js b/parse.js
index faee6bc..f7895a0 100755
--- a/parse.js
+++ b/parse.js
@@ -738,7 +738,12 @@ const DARK_THEME_SCRIPT =
   '<script>\n' +
   '  // Changes the banner image and link-to-theme if "theme=dark" is in query string\n' +
   '  // or if browser prefers dark mode and theme is not explicitly set.\n' +
-  '  if ( (window.location.search.search(/[?&]theme=dark/) !== -1) || ((window.location.search.search(/[?&]theme=light/) == -1) && (window.matchMedia(\'(prefers-color-scheme: dark)\').matches)) ) {\n' +
+  '\n' +
+  'const theme_not_set_in_query = window.location.search.search(/[?&]theme=light/) == -1\n' +
+  'const browser_prefers_dark = window.matchMedia(\'(prefers-color-scheme: dark)\').matches;\n' +
+  '\n' +
+  '  if ((window.location.search.search(/[?&]theme=dark/) !== -1) || \n' +
+  '      (theme_not_set_in_query && browser_prefers_dark)) {\n' +
   '    activateDarkMode();\n' +
   '  }\n' +
   '\n' +
@@ -752,7 +757,8 @@ const DARK_THEME_SCRIPT =
   '    img_dark.src = "web/image_orig_blue6.png";\n' +
   '    img_dark.alt = "Monthy Python";\n' +
   '    if ((window.location.search.search(/[?&]theme=dark2/) !== -1) ||\n' +
-  '        (window.location.search.search(/[?&]theme=dark3/) !== -1)) {\n' +
+  '        (window.location.search.search(/[?&]theme=dark3/) !== -1) ||\n' +
+  '        (theme_not_set_in_query && browser_prefers_dark)) {\n' +
   '      img_dark.style = "width: 910px;";\n' +
   '    } else {\n' +
   '      img_dark.style = "width: 960px;";\n' +