Browse Source

boostrap-os: use import_tasks instead of symlinks (#11508)

Working symlinks are dependant on git configuration (when using the playbook as
a git repository, which is common), precisely `git config
core.symlinks`.

While this is enabled by default, some company policies will disable it.

Instead, use import_tasks which should avoid that class of bugs.
pull/11441/head v2.26.0
Max Gautier 3 weeks ago
committed by GitHub
parent
commit
f9ebd45c74
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
5 changed files with 30 additions and 24 deletions
  1. 20
      roles/bootstrap-os/tasks/debian.yml
  2. 1
      roles/bootstrap-os/tasks/openEuler.yml
  3. 3
      roles/bootstrap-os/tasks/openEuler.yml
  4. 1
      roles/bootstrap-os/tasks/opensuse-leap.yml
  5. 3
      roles/bootstrap-os/tasks/opensuse-leap.yml
  6. 1
      roles/bootstrap-os/tasks/opensuse-tumbleweed.yml
  7. 3
      roles/bootstrap-os/tasks/opensuse-tumbleweed.yml
  8. 1
      roles/bootstrap-os/tasks/ubuntu.yml
  9. 21
      roles/bootstrap-os/tasks/ubuntu.yml

20
roles/bootstrap-os/tasks/debian.yml

@ -62,23 +62,3 @@
- '"changed its" in bootstrap_update_apt_result.stdout'
- '"value from" in bootstrap_update_apt_result.stdout'
ignore_errors: true
- name: Check unattended-upgrades file exist
stat:
path: /etc/apt/apt.conf.d/50unattended-upgrades
register: unattended_upgrades_file_stat
when:
- os_release_dict['ID'] == 'ubuntu'
- ubuntu_kernel_unattended_upgrades_disabled
- name: Disable kernel unattended-upgrades
lineinfile:
path: "{{ unattended_upgrades_file_stat.stat.path }}"
insertafter: "Unattended-Upgrade::Package-Blacklist"
line: '"linux-";'
state: present
become: true
when:
- os_release_dict['ID'] == 'ubuntu'
- ubuntu_kernel_unattended_upgrades_disabled
- unattended_upgrades_file_stat.stat.exists

1
roles/bootstrap-os/tasks/openEuler.yml

@ -1 +0,0 @@
centos.yml

3
roles/bootstrap-os/tasks/openEuler.yml

@ -0,0 +1,3 @@
---
- name: Import Centos boostrap for openEuler
import_tasks: centos.yml

1
roles/bootstrap-os/tasks/opensuse-leap.yml

@ -1 +0,0 @@
opensuse.yml

3
roles/bootstrap-os/tasks/opensuse-leap.yml

@ -0,0 +1,3 @@
---
- name: Import Opensuse bootstrap
import_tasks: opensuse.yml

1
roles/bootstrap-os/tasks/opensuse-tumbleweed.yml

@ -1 +0,0 @@
opensuse.yml

3
roles/bootstrap-os/tasks/opensuse-tumbleweed.yml

@ -0,0 +1,3 @@
---
- name: Import Opensuse bootstrap
import_tasks: opensuse.yml

1
roles/bootstrap-os/tasks/ubuntu.yml

@ -1 +0,0 @@
debian.yml

21
roles/bootstrap-os/tasks/ubuntu.yml

@ -0,0 +1,21 @@
---
- name: Import Debian bootstrap
import_tasks: debian.yml
- name: Check unattended-upgrades file exist
stat:
path: /etc/apt/apt.conf.d/50unattended-upgrades
register: unattended_upgrades_file_stat
when:
- ubuntu_kernel_unattended_upgrades_disabled
- name: Disable kernel unattended-upgrades
lineinfile:
path: "{{ unattended_upgrades_file_stat.stat.path }}"
insertafter: "Unattended-Upgrade::Package-Blacklist"
line: '"linux-";'
state: present
become: true
when:
- ubuntu_kernel_unattended_upgrades_disabled
- unattended_upgrades_file_stat.stat.exists
Loading…
Cancel
Save