From e053ee42724bdd3b800256880a54b2ba41b02125 Mon Sep 17 00:00:00 2001 From: Ilya Margolin Date: Wed, 23 Feb 2022 10:20:18 +0100 Subject: [PATCH] Check all places with `check_mode: no` for side effects (#8573) and fix the one with side effect. Also removes `notify` from this task as the task has `changed_when: false` and notify is not going to fire. --- roles/etcd/tasks/gen_certs_script.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/roles/etcd/tasks/gen_certs_script.yml b/roles/etcd/tasks/gen_certs_script.yml index 3825e3c62..680df69db 100644 --- a/roles/etcd/tasks/gen_certs_script.yml +++ b/roles/etcd/tasks/gen_certs_script.yml @@ -156,11 +156,9 @@ executable: /bin/bash no_log: true changed_when: false - check_mode: no when: (('calico_rr' in groups and inventory_hostname in groups['calico_rr']) or inventory_hostname in groups['k8s_cluster']) and sync_certs|default(false) and inventory_hostname not in groups['etcd'] - notify: set etcd_secret_changed - name: Gen_certs | check certificate permissions file: