Browse Source
missing "check_mode: no"s for several read-only tasks (#8584)
this is not complete -- there are almost certainly more instances of
this issue
pull/8596/head
Tom Janson
3 years ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with
6 additions and
0 deletions
-
roles/etcd/tasks/main.yml
-
roles/kubernetes/node/tasks/facts.yml
-
roles/kubernetes/node/tasks/main.yml
-
roles/kubernetes/node/tasks/pre_upgrade.yml
-
roles/network_plugin/calico/tasks/check.yml
|
|
@ -19,6 +19,7 @@ |
|
|
|
command: "openssl x509 -in {{ etcd_cert_dir }}/node-{{ inventory_hostname }}.pem -noout -serial" |
|
|
|
register: "etcd_client_cert_serial_result" |
|
|
|
changed_when: false |
|
|
|
check_mode: no |
|
|
|
when: |
|
|
|
- inventory_hostname in groups['k8s_cluster']|union(groups['calico_rr']|default([]))|unique|sort |
|
|
|
tags: |
|
|
|
|
|
@ -4,6 +4,7 @@ |
|
|
|
shell: "docker info | grep 'Cgroup Driver' | awk -F': ' '{ print $2; }'" |
|
|
|
register: docker_cgroup_driver_result |
|
|
|
changed_when: false |
|
|
|
check_mode: no |
|
|
|
|
|
|
|
- name: set kubelet_cgroup_driver_detected fact for docker |
|
|
|
set_fact: |
|
|
|
|
|
@ -52,6 +52,7 @@ |
|
|
|
register: modinfo_br_netfilter |
|
|
|
failed_when: modinfo_br_netfilter.rc not in [0, 1] |
|
|
|
changed_when: false |
|
|
|
check_mode: no |
|
|
|
|
|
|
|
- name: Verify br_netfilter module path exists |
|
|
|
file: |
|
|
@ -77,6 +78,7 @@ |
|
|
|
command: "sysctl net.bridge.bridge-nf-call-iptables" |
|
|
|
failed_when: false |
|
|
|
changed_when: false |
|
|
|
check_mode: no |
|
|
|
register: sysctl_bridge_nf_call_iptables |
|
|
|
|
|
|
|
- name: Enable bridge-nf-call tables |
|
|
|
|
|
@ -11,6 +11,7 @@ |
|
|
|
executable: /bin/bash |
|
|
|
failed_when: false |
|
|
|
changed_when: false |
|
|
|
check_mode: no |
|
|
|
register: kubelet_container_check |
|
|
|
|
|
|
|
- name: "Pre-upgrade | copy /var/lib/cni from kubelet" |
|
|
|
|
|
@ -41,6 +41,7 @@ |
|
|
|
command: calicoctl.sh get ipPool {{ calico_pool_name }} -o json |
|
|
|
failed_when: False |
|
|
|
changed_when: False |
|
|
|
check_mode: no |
|
|
|
register: calico |
|
|
|
run_once: True |
|
|
|
delegate_to: "{{ groups['kube_control_plane'][0] }}" |
|
|
|