Browse Source

Feature DynamicKubeletConfig is deprecated in 1.22 and will not move to GA (#7938)

* Feature DynamicKubeletConfig is deprecated in 1.22 and will not move to GA

* Add check for dynamic_kubelet_configuration with kube >= 1.22
pull/7947/head
Cristian Calin 3 years ago
committed by GitHub
parent
commit
d57ddf0be8
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 17 additions and 4 deletions
  1. 3
      inventory/sample/group_vars/k8s_cluster/k8s-cluster.yml
  2. 4
      roles/kubernetes/node/tasks/kubelet.yml
  3. 2
      roles/kubernetes/node/templates/kubelet.env.v1beta1.j2
  4. 10
      roles/kubernetes/preinstall/tasks/0020-verify-settings.yml
  5. 1
      tests/files/packet_oracle7-canal-ha.yml
  6. 1
      tests/files/packet_ubuntu16-canal-kubeadm-ha.yml

3
inventory/sample/group_vars/k8s_cluster/k8s-cluster.yml

@ -211,6 +211,9 @@ k8s_image_pull_policy: IfNotPresent
kubernetes_audit: false
# dynamic kubelet configuration
# Note: Feature DynamicKubeletConfig is deprecated in 1.22 and will not move to GA.
# It is planned to be removed from Kubernetes in the version 1.23.
# Please use alternative ways to update kubelet configuration.
dynamic_kubelet_configuration: false
# define kubelet config dir for dynamic kubelet

4
roles/kubernetes/node/tasks/kubelet.yml

@ -4,7 +4,9 @@
path: "{{ dynamic_kubelet_configuration_dir }}"
mode: 0600
state: directory
when: dynamic_kubelet_configuration
when:
- dynamic_kubelet_configuration
- kube_version is version('v1.22.0', '<')
- name: Set kubelet api version to v1beta1
set_fact:

2
roles/kubernetes/node/templates/kubelet.env.v1beta1.j2

@ -18,7 +18,7 @@ KUBELET_HOSTNAME="--hostname-override={{ kube_override_hostname }}"
--container-runtime=remote \
--container-runtime-endpoint=unix://{{ cri_socket }} \
{% endif %}
{% if dynamic_kubelet_configuration %}
{% if dynamic_kubelet_configuration and kube_version is version('v1.22.0', '<') %}
--dynamic-config-dir={{ dynamic_kubelet_configuration_dir }} \
{% endif %}
--runtime-cgroups={{ kubelet_runtime_cgroups }} \

10
roles/kubernetes/preinstall/tasks/0020-verify-settings.yml

@ -114,6 +114,16 @@
when:
- kube_version is version('v1.21.0', '>=')
- name: Stop when dynamic_kubelet_configuration enabled for kubernetes >= 1.22
assert:
that: not dynamic_kubelet_configuration
msg: >
Feature DynamicKubeletConfig is deprecated in 1.22 and will not move to GA.
It is planned to be removed from Kubernetes in the version 1.23.
Please use alternative ways to update kubelet configuration.
when:
- kube_version is version('v1.22.0', '>=')
# This assertion will fail on the safe side: One can indeed schedule more pods
# on a node than the CIDR-range has space for when additional pods use the host
# network namespace. It is impossible to ascertain the number of such pods at

1
tests/files/packet_oracle7-canal-ha.yml

@ -6,7 +6,6 @@ mode: ha
# Kubespray settings
calico_datastore: etcd
kube_network_plugin: canal
dynamic_kubelet_configuration: true
deploy_netchecker: true
dns_min_replicas: 1

1
tests/files/packet_ubuntu16-canal-kubeadm-ha.yml

@ -6,6 +6,5 @@ mode: ha
# Kubespray settings
calico_datastore: etcd
kube_network_plugin: canal
dynamic_kubelet_configuration: true
deploy_netchecker: true
dns_min_replicas: 1
Loading…
Cancel
Save