From 189ce380bd55741a58079c431bb2573b4bddcd90 Mon Sep 17 00:00:00 2001 From: David Louks <2402775+dlouks@users.noreply.github.com> Date: Tue, 9 Feb 2021 08:02:40 -0600 Subject: [PATCH] Remove deletion of coredns deployment. (#7211) * Add unique annotation on coredns deployment and only remove existing deployment if annotation is missing. * Ignore errors when gathering coredns deployment details to handle case where it doesn't exist yet * Remove run_once, deletegate_to and add to when statement (cherry picked from commit 0cc17267811efa7b9568cdd264d57fd1640e23a8) --- roles/kubernetes-apps/ansible/tasks/cleanup_dns.yml | 10 ++++++++++ .../ansible/templates/coredns-deployment.yml.j2 | 1 + 2 files changed, 11 insertions(+) diff --git a/roles/kubernetes-apps/ansible/tasks/cleanup_dns.yml b/roles/kubernetes-apps/ansible/tasks/cleanup_dns.yml index 49ed96a47..8d3020875 100644 --- a/roles/kubernetes-apps/ansible/tasks/cleanup_dns.yml +++ b/roles/kubernetes-apps/ansible/tasks/cleanup_dns.yml @@ -1,4 +1,13 @@ --- +- name: Kubernetes Apps | Register coredns deployment annotation `createdby` + shell: "{{ bin_dir }}/kubectl get deploy -n kube-system coredns -o jsonpath='{ .spec.template.metadata.annotations.createdby }'" + register: createdby_annotation + changed_when: false + ignore_errors: true + when: + - dns_mode in ['coredns', 'coredns_dual'] + - inventory_hostname == groups['kube-master'][0] + - name: Kubernetes Apps | Delete kubeadm CoreDNS kube: name: "coredns" @@ -9,6 +18,7 @@ when: - dns_mode in ['coredns', 'coredns_dual'] - inventory_hostname == groups['kube-master'][0] + - createdby_annotation.stdout != 'kubespray' - name: Kubernetes Apps | Delete kubeadm Kube-DNS service kube: diff --git a/roles/kubernetes-apps/ansible/templates/coredns-deployment.yml.j2 b/roles/kubernetes-apps/ansible/templates/coredns-deployment.yml.j2 index 6a7253422..556e77c76 100644 --- a/roles/kubernetes-apps/ansible/templates/coredns-deployment.yml.j2 +++ b/roles/kubernetes-apps/ansible/templates/coredns-deployment.yml.j2 @@ -23,6 +23,7 @@ spec: k8s-app: kube-dns{{ coredns_ordinal_suffix }} annotations: seccomp.security.alpha.kubernetes.io/pod: 'runtime/default' + createdby: 'kubespray' spec: priorityClassName: system-cluster-critical nodeSelector: