From e05036cb9abb398c0be72249b960db21be864cf2 Mon Sep 17 00:00:00 2001 From: Hironsan Date: Wed, 15 Dec 2021 14:52:33 +0900 Subject: [PATCH] Implements builders --- backend/api/tests/upload/test_builder.py | 36 +++++++++++++++++ backend/api/views/upload/builders.py | 50 ++++++++++++++++++++++++ 2 files changed, 86 insertions(+) create mode 100644 backend/api/tests/upload/test_builder.py create mode 100644 backend/api/views/upload/builders.py diff --git a/backend/api/tests/upload/test_builder.py b/backend/api/tests/upload/test_builder.py new file mode 100644 index 00000000..a8d50129 --- /dev/null +++ b/backend/api/tests/upload/test_builder.py @@ -0,0 +1,36 @@ +import unittest + +from ...views.upload import builders +from ...views.upload.data import TextData +from ...views.upload.label import CategoryLabel + + +class TestColumnBuilder(unittest.TestCase): + + def assert_record(self, actual, expected): + self.assertEqual(actual.data['text'], expected['data']) + self.assertEqual(actual.label, expected['label']) + + def test_can_load_default_column_names(self): + row = {'text': 'Text', 'label': 'Label'} + builder = builders.ColumnBuilder( + data_class=TextData, + label_class=CategoryLabel, + text_column='text', + label_column='label' + ) + actual = builder.build(row, filename='', line_num=1) + expected = {'data': 'Text', 'label': [{'text': 'Label'}]} + self.assert_record(actual, expected) + + def test_can_load_only_text_column(self): + row = {'text': 'Text', 'label': None} + builder = builders.ColumnBuilder( + data_class=TextData, + label_class=CategoryLabel, + text_column='text', + label_column='label' + ) + actual = builder.build(row, filename='', line_num=1) + expected = {'data': 'Text', 'label': []} + self.assert_record(actual, expected) diff --git a/backend/api/views/upload/builders.py b/backend/api/views/upload/builders.py new file mode 100644 index 00000000..669290b1 --- /dev/null +++ b/backend/api/views/upload/builders.py @@ -0,0 +1,50 @@ +from typing import Any, Dict, Type + +from pydantic import ValidationError + +from .data import BaseData +from .exception import FileParseException +from .label import Label +from .readers import DEFAULT_LABEL_COLUMN, DEFAULT_TEXT_COLUMN, Builder, Record + + +class PlainBuilder(Builder): + + def __init__(self, data_class: Type[BaseData]): + self.data_class = data_class + + def build(self, row: Dict[Any, Any], filename: str, line_num: int) -> Record: + data = self.data_class.parse(filename=filename) + yield Record(data=data) + + +class ColumnBuilder(Builder): + + def __init__(self, + data_class: Type[BaseData], + label_class: Type[Label], + text_column: str = DEFAULT_TEXT_COLUMN, + label_column: str = DEFAULT_LABEL_COLUMN): + self.data_class = data_class + self.label_class = label_class + self.text_column = text_column + self.label_column = label_column + + def build(self, row: Dict[Any, Any], filename: str, line_num: int) -> Record: + if self.text_column not in row: + message = f'{self.text_column} does not exist.' + raise FileParseException(filename, line_num, message) + text = row.pop(self.text_column) + label = row.pop(self.label_column, []) + label = [label] if isinstance(label, str) else label + try: + label = [self.label_class.parse(o) for o in label] + except (ValidationError, TypeError): + label = [] + + try: + data = self.data_class.parse(text=text, filename=filename, meta=row) + return Record(data=data, label=label, line_num=line_num) + except ValidationError: + message = 'The empty text is not allowed.' + raise FileParseException(filename, line_num, message)