From afa38da34424cfd364dba3c98f06771a884c309f Mon Sep 17 00:00:00 2001 From: Clemens Wolff Date: Thu, 12 Dec 2019 16:17:19 -0500 Subject: [PATCH] Fix codacy --- app/api/permissions.py | 4 ++-- app/api/tests/test_api.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/api/permissions.py b/app/api/permissions.py index 4720c2bb..d91ae795 100644 --- a/app/api/permissions.py +++ b/app/api/permissions.py @@ -47,8 +47,8 @@ class IsOwnAnnotation(ProjectMixin, BasePermission): class IsOwnComment(ProjectMixin, BasePermission): - - def has_object_permission(self, request, view, obj): + @classmethod + def has_object_permission(cls, request, view, obj): if request.user.is_superuser: return True diff --git a/app/api/tests/test_api.py b/app/api/tests/test_api.py index e0d286d1..84d6c3ef 100644 --- a/app/api/tests/test_api.py +++ b/app/api/tests/test_api.py @@ -841,13 +841,13 @@ class TestCommentListAPI(APITestCase): def test_does_not_allow_deletion_by_non_project_member(self): self.client.login(username=self.non_project_member_name, password=self.non_project_member_pass) - response = self.client.delete(f"{self.url}/{self.comment.id}", format='json') + response = self.client.delete('{}/{}'.format(self.url, self.comment.id), format='json') self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN) def test_does_not_allow_deletion_of_non_owned_comment(self): self.client.login(username=self.another_project_member_name, password=self.another_project_member_pass) - response = self.client.delete(f"{self.url}/{self.comment.id}", format='json') + response = self.client.delete('{}/{}'.format(self.url, self.comment.id), format='json') self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN) def test_create_update_delete_comment(self): @@ -857,7 +857,7 @@ class TestCommentListAPI(APITestCase): self.assertEqual(response.status_code, status.HTTP_201_CREATED) self.assertEqual(response.data['user'], self.project_member.id) self.assertEqual(response.data['text'], 'comment') - url = f"{self.url}/{response.data['id']}" + url = '{}/{}'.format(self.url, response.data['id']) response = self.client.get(self.url, format='json') self.assertEqual(response.status_code, status.HTTP_200_OK)