From f585d4cf16230456431c0258f9932e155aba29c4 Mon Sep 17 00:00:00 2001 From: jlukic Date: Tue, 28 Jul 2015 15:08:36 -0400 Subject: [PATCH] Text menu now uses padding for larger hitboxes --- RELEASE-NOTES.md | 1 + src/definitions/collections/menu.less | 4 ++-- src/themes/default/collections/menu.variables | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index ebfd72b2f..62deb1c15 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -6,6 +6,7 @@ - **Breadcrumb** - Breadcrumb no longer receives vertical spacing by default. This may often cause vertical alignment issues when displayed next to other `inline-block` content. - **Menu** - Appearance of `labeled icon menu` has been modified. Horizontal menus now have icons above text, and icons are slightly larger than before. +- **Menu** - `text menu` now uses padding for hitboxes to make target area for links larger **[Reported Bugs](https://github.com/Semantic-Org/Semantic-UI/issues?q=is%3Aissue+milestone%3A2.1.0+is%3Aclosed)** - **Modal** - Fix autofocus setting in modal not working due to improper selector #2737 diff --git a/src/definitions/collections/menu.less b/src/definitions/collections/menu.less index 3b0a008b1..b30a15e67 100755 --- a/src/definitions/collections/menu.less +++ b/src/definitions/collections/menu.less @@ -966,11 +966,11 @@ Floated Menu / Item margin: @textMenuMargin; } .ui.text.menu .item { - padding: 0em; border-radius: 0px; box-shadow: none; align-self: center; margin: @textMenuItemMargin; + padding: @textMenuItemPadding; font-weight: @textMenuItemFontWeight; color: @textMenuItemColor; transition: @textMenuItemTransition; @@ -1038,9 +1038,9 @@ Floated Menu / Item /*--- active ---*/ .ui.text.menu .active.item { background-color: transparent; - padding: 0em; border: none; box-shadow: none; + padding: @textMenuItemPadding; font-weight: @textMenuActiveItemFontWeight; color: @textMenuActiveItemColor; } diff --git a/src/themes/default/collections/menu.variables b/src/themes/default/collections/menu.variables index e57d34d53..9d7224f3e 100644 --- a/src/themes/default/collections/menu.variables +++ b/src/themes/default/collections/menu.variables @@ -332,10 +332,11 @@ /* Text */ @textMenuItemSpacing: 0.5em; -@textMenuMargin: @relativeLarge -@textMenuItemSpacing; +@textMenuMargin: @relativeMedium -(@textMenuItemSpacing); @textMenuItemColor: @mutedTextColor; @textMenuItemFontWeight: normal; -@textMenuItemMargin: 0em @textMenuItemSpacing; +@textMenuItemMargin: 0em 0em; +@textMenuItemPadding: @relative5px @textMenuItemSpacing; @textMenuItemTransition: opacity @defaultDuration @defaultEasing; @textMenuSubMenuMargin: 0em;