Browse Source

Fix condition where progress could continue firing interval indefinitely if removed from DOM

pull/3763/merge
Jack Lukic 8 years ago
parent
commit
ef5913ba1d
1 changed files with 10 additions and 1 deletions
  1. 11
      src/definitions/modules/progress.js

11
src/definitions/modules/progress.js

@ -452,7 +452,16 @@ $.fn.progress = function(parameters) {
clearInterval(module.interval);
$bar.one(transitionEnd + eventNamespace, animationCallback);
animating = true;
module.interval = setInterval(module.set.labels, settings.framerate);
module.interval = setInterval(function() {
let
isInDOM = $.contains(document.documentElement, element)
;
if(!isInDOM) {
clearInterval(module.interval);
animating = false;
}
module.set.labels();
}, settings.framerate);
},
labels: function() {
module.verbose('Setting both bar progress and outer label text');

Loading…
Cancel
Save