diff --git a/RELEASE NOTES.md b/RELEASE NOTES.md index 26431058e..2c70dba65 100755 --- a/RELEASE NOTES.md +++ b/RELEASE NOTES.md @@ -1,5 +1,10 @@ ## RELEASE NOTES +### Version 0.2.2 - Sep 28, 2013 + +**Updates** +- Fixes invoke returning found function instead of results of found function in dropdown, modal + ### Version 0.2.1 - Sep 28, 2013 **Updates** diff --git a/build/less/modules/chatroom.js b/build/less/modules/chatroom.js index fde496f95..7de7a519e 100644 --- a/build/less/modules/chatroom.js +++ b/build/less/modules/chatroom.js @@ -574,7 +574,7 @@ $.fn.chatroom = function(parameters) { if(instance === undefined) { module.initialize(); } - invokedResponse = module.invoke(query); + module.invoke(query); } else { if(instance !== undefined) { diff --git a/build/less/modules/dimmer.js b/build/less/modules/dimmer.js index da1ea1e88..8d24f0480 100644 --- a/build/less/modules/dimmer.js +++ b/build/less/modules/dimmer.js @@ -316,7 +316,6 @@ $.fn.dimmer = function(parameters) { }, setting: function(name, value) { - module.debug('Changing setting', name, value); if(value !== undefined) { if( $.isPlainObject(name) ) { $.extend(true, settings, name); diff --git a/build/less/modules/dropdown.js b/build/less/modules/dropdown.js index c31938e68..e27b03abd 100644 --- a/build/less/modules/dropdown.js +++ b/build/less/modules/dropdown.js @@ -161,7 +161,7 @@ $.fn.dropdown = function(parameters) { var $choice = $(this), text = $choice.data(metadata.text) || $choice.text(), - value = $choice.data(metadata.value) || text + value = $choice.data(metadata.value) || text.toLowerCase() ; if( $choice.find(selector.menu).size() === 0 ) { module.verbose('Adding active state to selected item'); @@ -358,7 +358,7 @@ $.fn.dropdown = function(parameters) { duration : settings.duration, complete : callback, queue : false - }) + }); } else if(settings.transition == 'slide down') { $currentMenu @@ -406,7 +406,7 @@ $.fn.dropdown = function(parameters) { duration : settings.duration, complete : callback, queue : false - }) + }); } else if(settings.transition == 'none') { callback(); @@ -639,7 +639,7 @@ $.fn.dropdown = function(parameters) { if(instance === undefined) { module.initialize(); } - invokedResponse = module.invoke(query); + module.invoke(query); } else { if(instance !== undefined) { diff --git a/build/less/modules/modal.js b/build/less/modules/modal.js index 704aafb3d..5d50b6d77 100644 --- a/build/less/modules/modal.js +++ b/build/less/modules/modal.js @@ -157,6 +157,9 @@ $.fn.modal = function(parameters) { module.set.dimmerSettings(); $context.dimmer('show'); }, + hideDimmer: function() { + $context.dimmer('hide'); + }, hide: function() { module.debug('Hiding modal'); @@ -438,7 +441,7 @@ $.fn.modal = function(parameters) { if(instance === undefined) { module.initialize(); } - invokedResponse = module.invoke(query); + module.invoke(query); } else { if(instance !== undefined) { diff --git a/build/minified/modules/chatroom.js b/build/minified/modules/chatroom.js index fde496f95..7de7a519e 100644 --- a/build/minified/modules/chatroom.js +++ b/build/minified/modules/chatroom.js @@ -574,7 +574,7 @@ $.fn.chatroom = function(parameters) { if(instance === undefined) { module.initialize(); } - invokedResponse = module.invoke(query); + module.invoke(query); } else { if(instance !== undefined) { diff --git a/build/minified/modules/dimmer.js b/build/minified/modules/dimmer.js index da1ea1e88..8d24f0480 100644 --- a/build/minified/modules/dimmer.js +++ b/build/minified/modules/dimmer.js @@ -316,7 +316,6 @@ $.fn.dimmer = function(parameters) { }, setting: function(name, value) { - module.debug('Changing setting', name, value); if(value !== undefined) { if( $.isPlainObject(name) ) { $.extend(true, settings, name); diff --git a/build/minified/modules/dropdown.js b/build/minified/modules/dropdown.js index c31938e68..e27b03abd 100644 --- a/build/minified/modules/dropdown.js +++ b/build/minified/modules/dropdown.js @@ -161,7 +161,7 @@ $.fn.dropdown = function(parameters) { var $choice = $(this), text = $choice.data(metadata.text) || $choice.text(), - value = $choice.data(metadata.value) || text + value = $choice.data(metadata.value) || text.toLowerCase() ; if( $choice.find(selector.menu).size() === 0 ) { module.verbose('Adding active state to selected item'); @@ -358,7 +358,7 @@ $.fn.dropdown = function(parameters) { duration : settings.duration, complete : callback, queue : false - }) + }); } else if(settings.transition == 'slide down') { $currentMenu @@ -406,7 +406,7 @@ $.fn.dropdown = function(parameters) { duration : settings.duration, complete : callback, queue : false - }) + }); } else if(settings.transition == 'none') { callback(); @@ -639,7 +639,7 @@ $.fn.dropdown = function(parameters) { if(instance === undefined) { module.initialize(); } - invokedResponse = module.invoke(query); + module.invoke(query); } else { if(instance !== undefined) { diff --git a/build/minified/modules/modal.js b/build/minified/modules/modal.js index 704aafb3d..5d50b6d77 100644 --- a/build/minified/modules/modal.js +++ b/build/minified/modules/modal.js @@ -157,6 +157,9 @@ $.fn.modal = function(parameters) { module.set.dimmerSettings(); $context.dimmer('show'); }, + hideDimmer: function() { + $context.dimmer('hide'); + }, hide: function() { module.debug('Hiding modal'); @@ -438,7 +441,7 @@ $.fn.modal = function(parameters) { if(instance === undefined) { module.initialize(); } - invokedResponse = module.invoke(query); + module.invoke(query); } else { if(instance !== undefined) { diff --git a/build/uncompressed/modules/chatroom.js b/build/uncompressed/modules/chatroom.js index fde496f95..7de7a519e 100644 --- a/build/uncompressed/modules/chatroom.js +++ b/build/uncompressed/modules/chatroom.js @@ -574,7 +574,7 @@ $.fn.chatroom = function(parameters) { if(instance === undefined) { module.initialize(); } - invokedResponse = module.invoke(query); + module.invoke(query); } else { if(instance !== undefined) { diff --git a/build/uncompressed/modules/dimmer.js b/build/uncompressed/modules/dimmer.js index da1ea1e88..8d24f0480 100644 --- a/build/uncompressed/modules/dimmer.js +++ b/build/uncompressed/modules/dimmer.js @@ -316,7 +316,6 @@ $.fn.dimmer = function(parameters) { }, setting: function(name, value) { - module.debug('Changing setting', name, value); if(value !== undefined) { if( $.isPlainObject(name) ) { $.extend(true, settings, name); diff --git a/build/uncompressed/modules/dropdown.js b/build/uncompressed/modules/dropdown.js index c31938e68..e27b03abd 100644 --- a/build/uncompressed/modules/dropdown.js +++ b/build/uncompressed/modules/dropdown.js @@ -161,7 +161,7 @@ $.fn.dropdown = function(parameters) { var $choice = $(this), text = $choice.data(metadata.text) || $choice.text(), - value = $choice.data(metadata.value) || text + value = $choice.data(metadata.value) || text.toLowerCase() ; if( $choice.find(selector.menu).size() === 0 ) { module.verbose('Adding active state to selected item'); @@ -358,7 +358,7 @@ $.fn.dropdown = function(parameters) { duration : settings.duration, complete : callback, queue : false - }) + }); } else if(settings.transition == 'slide down') { $currentMenu @@ -406,7 +406,7 @@ $.fn.dropdown = function(parameters) { duration : settings.duration, complete : callback, queue : false - }) + }); } else if(settings.transition == 'none') { callback(); @@ -639,7 +639,7 @@ $.fn.dropdown = function(parameters) { if(instance === undefined) { module.initialize(); } - invokedResponse = module.invoke(query); + module.invoke(query); } else { if(instance !== undefined) { diff --git a/build/uncompressed/modules/modal.js b/build/uncompressed/modules/modal.js index 704aafb3d..5d50b6d77 100644 --- a/build/uncompressed/modules/modal.js +++ b/build/uncompressed/modules/modal.js @@ -157,6 +157,9 @@ $.fn.modal = function(parameters) { module.set.dimmerSettings(); $context.dimmer('show'); }, + hideDimmer: function() { + $context.dimmer('hide'); + }, hide: function() { module.debug('Hiding modal'); @@ -438,7 +441,7 @@ $.fn.modal = function(parameters) { if(instance === undefined) { module.initialize(); } - invokedResponse = module.invoke(query); + module.invoke(query); } else { if(instance !== undefined) { diff --git a/node/src/documents/modules/modal.html.eco b/node/src/documents/modules/modal.html.eco index fc09611f7..3b85c13bd 100755 --- a/node/src/documents/modules/modal.html.eco +++ b/node/src/documents/modules/modal.html.eco @@ -68,8 +68,9 @@ type : 'UI Module'
@@ -79,8 +80,8 @@ type : 'UI Module'A modal can be included anywhere on the page. On initialization a modal's current size will be cached, and the element will be detached from the dom and moved inside a dimmer.
A standard modal
+A modal can reduce its complexity
+An active modal is visible on the page
+You can disable a modal's dimmer from being closed by click to force a user to make a choice
+A dimmer can use any named ui transition.
+A modal can reduce its complexity
-$('.foo').modal('behavior name', argumentOne, argumentTwo)
- An active modal is visible on the page
-refresh | +Refreshes centering of modal on page | +
show dimmer | +Shows associated page dimmer | +
hide dimmer | +Hides associated page dimmer | +
hide all | +Hides all visible modals initialized at the same time | +
cache sizes | +Caches current modal size | +
can fit | +Returns whether the modal can fit on the page | +
is active | +Returns whether the modal is active | +
set active | +Sets modal to active | +
Modal settings modify the modal's behavior
-Setting | Default | @@ -223,7 +309,7 @@ type : 'UI Module'
---|
Setting | Context | @@ -243,13 +329,9 @@ type : 'UI Module'
---|
DOM settings specify how this module should interface with the DOM
-Setting | Default | @@ -266,7 +348,7 @@ type : 'UI Module'
selector : {
- close : '.close'
+ close : '.close, .actions .button'
},
|
@@ -276,6 +358,7 @@ type : 'UI Module'
className : {
+ active : 'active',
scrolling : 'scrolling'
}
@@ -284,13 +367,9 @@ type : 'UI Module'
|
---|
Debug settings controls debug output to the console
-Setting | Default | @@ -330,7 +409,6 @@ type : 'UI Module'
---|