From da0aff070a05ab2c12a603c9c5db01b9208e9400 Mon Sep 17 00:00:00 2001 From: Jack Lukic Date: Tue, 11 Apr 2017 23:34:04 -0400 Subject: [PATCH] Remove iOS html class name fix #3488 --- RELEASE-NOTES.md | 2 ++ src/definitions/modules/sidebar.js | 5 +---- src/definitions/modules/sidebar.less | 10 ---------- 3 files changed, 3 insertions(+), 14 deletions(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 80aa103e9..2b05f7b91 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -6,6 +6,8 @@ - **Modal** - Adds `tiny` and `mini` sized modals #5123 **Thanks @Banandrew** **Bugs** + +- **Sidebar** - Removed use of `ios` browser detection, and use of `-webkit-overflow-scrolling: touch;`. iOS no longer has sizing issues when displaying sidebar content in latest iOS. - **Search** - Fixed issue where `searchDelay` could cause results to appear after search had lost focus. - **Sticky** - Fix issue where sticky would cause page to shift when `context` height was determined by sticky's height in `position: static;` #3430 - **Form Validation** - Fixed issue where radio was not being included in `onFailure` values if not set #5064 diff --git a/src/definitions/modules/sidebar.js b/src/definitions/modules/sidebar.js index ba063f8ad..54b61a61c 100644 --- a/src/definitions/modules/sidebar.js +++ b/src/definitions/modules/sidebar.js @@ -89,10 +89,6 @@ $.fn.sidebar = function(parameters) { transitionEvent = module.get.transitionEvent(); - if(module.is.ios()) { - module.set.ios(); - } - // avoids locking rendering if initialized in onReady if(settings.delaySetup) { requestAnimationFrame(module.setup.layout); @@ -569,6 +565,7 @@ $.fn.sidebar = function(parameters) { set: { // ios only (scroll on html not document). This prevent auto-resize canvas/scroll in ios + // (This is no longer necessary in latest iOS) ios: function() { $html.addClass(className.ios); }, diff --git a/src/definitions/modules/sidebar.less b/src/definitions/modules/sidebar.less index 52debc23f..489eff093 100755 --- a/src/definitions/modules/sidebar.less +++ b/src/definitions/modules/sidebar.less @@ -239,16 +239,6 @@ body.pushable > .pusher { iOS ---------------*/ -/* - iOS incorrectly sizes document when content - is presented outside of view with 2Dtranslate -*/ -html.ios { - overflow-x: hidden; - -webkit-overflow-scrolling: touch; -} - - /******************************* Variations