diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 5460d7768..34f0d99a0 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -15,21 +15,17 @@ - **Menu** - Appearance of `labeled icon menu` has been modified. Horizontal menus now have icons above text, and icons are slightly larger than before. - **Site** - `html,body { height: 100% }` has been modified [based on reasonable feedback](http://stackoverflow.com/questions/17555682/height-100-or-min-height-100-for-html-and-body-elements) +**[Community Enhancements](https://github.com/Semantic-Org/Semantic-UI/issues?q=is%3Aissue+milestone%3A2.1.0+is%3Aclosed)** +- **Flag** - England flag alias is now correctly set #2770 **Thanks @eduardom** +- **Popup** - Popup will now look for inline popup as any next adjacent sibling #2772 **Thanks @malacalypse** +- **Dropdown** - Dropdown `show` and `hide` are now cancellable by returning `false` from `onShow` or `onHide` callbacks. + **Additional Enhancements** - **Dropdown** - Dropdown `@arrowSize` will now automatically reposition itself if size is changed with variable - **Dropdown** - Dropdown arrow now has a variable `@dropdownArrowSize`, and is slightly smaller than previously - **List** - Lists can now be `right floated` or `left floated` - **Menu** - `text menu` now uses padding for hitboxes to make target area for links larger -**[Merged Pull Requests](https://github.com/Semantic-Org/Semantic-UI/issues?q=is%3Aissue+milestone%3A2.1.0+is%3Aclosed)** - -- **Menu** - Fixes tabular menu missing variable for background. **Thanks @frontdevde** -- **Sticky** - Sticky now sets width and height with `!important` to avoid inheritance issues in some cases **Thanks @lauri-elevant** #2710 -- **Flag** - England flag alias is now correctly set #2770 **Thanks @eduardom** -- **Popup** - Popup will now look for inline popup as any next adjacent sibling #2772 **Thanks @malacalypse** -- **API** - API debug is now `false` by default, like other modules. #2817 -- **Dropdown** - Fixed issue where label could not be removed when using a numeric value due to mismatched types #2754 #2755 **Thanks @dgurkaynak** - **[Reported Bugs](https://github.com/Semantic-Org/Semantic-UI/issues?q=is%3Aissue+milestone%3A2.1.0+is%3Aclosed)** - **Accordion** - Added missing notation for accordion docs #2812 - **Container** - Fix issue with `fluid container` being `100% + gutter` at mobile resolution (causing overflow) @@ -49,6 +45,12 @@ - **Dropdown** - `forceSelection` no longer sets current value in search selection when current query is blank #2058 - **Dropdown** - Fixed issue where "no results" message would be still be visible before search query on input focus #2824 +**[Community Bug Fixes](https://github.com/Semantic-Org/Semantic-UI/issues?q=is%3Aissue+milestone%3A2.1.0+is%3Aclosed)** +- **Menu** - Fixes tabular menu missing variable for background. **Thanks @frontdevde** +- **Sticky** - Sticky now sets width and height with `!important` to avoid inheritance issues in some cases **Thanks @lauri-elevant** #2710 +- **API** - API debug is now `false` by default, like other modules. #2817 +- **Dropdown** - Fixed issue where label could not be removed when using a numeric value due to mismatched types #2754 #2755 **Thanks @dgurkaynak** + **Additional Bugs** - **Build Tools** - Fixes issue on `win` platform where packaged theme would not correctly update when using watch due to regExp not matching windows path separators. - **Dropdown** - Dropdown will no longer fire native `onchange` event on hidden input when setting value during initial load (unless `fireOnInit: true`) #2795 **Thanks @lauri-elevant** diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js index a2be4dc19..d093bc369 100644 --- a/src/definitions/modules/dropdown.js +++ b/src/definitions/modules/dropdown.js @@ -412,7 +412,7 @@ $.fn.dropdown = function(parameters) { if(module.has.message() && !module.has.maxSelections()) { module.remove.message(); } - if(settings.onHide.call(element) !== false) { + if(settings.onShow.call(element) !== false) { module.animate.show(function() { if( module.can.click() ) { module.bind.intent();