From 77d2739079519f65b7c2545b4334b8dd8684a895 Mon Sep 17 00:00:00 2001 From: Martin D Date: Wed, 31 Aug 2016 13:53:11 -0400 Subject: [PATCH 01/11] Update dropdown.js `text` argument missing for select action --- src/definitions/modules/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js index 0ae40b02b..0e6d78ef9 100644 --- a/src/definitions/modules/dropdown.js +++ b/src/definitions/modules/dropdown.js @@ -1558,7 +1558,7 @@ $.fn.dropdown = function(parameters) { : text ; if( module.can.activate( $(element) ) ) { - module.set.value(value, $(element)); + module.set.value(value, text, $(element)); if(module.is.multiple() && !module.is.allFiltered()) { return; } From 884298381e0bb46d5641a2facbfa4508606d8822 Mon Sep 17 00:00:00 2001 From: Pierrick Prudhomme Date: Tue, 27 Feb 2018 11:27:13 +0100 Subject: [PATCH 02/11] [Search] add exactResults on duplicate check --- src/definitions/modules/search.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/definitions/modules/search.js b/src/definitions/modules/search.js index c06ab1b49..f074ff80c 100644 --- a/src/definitions/modules/search.js +++ b/src/definitions/modules/search.js @@ -596,9 +596,10 @@ $.fn.search = function(parameters) { addResult = function(array, result) { var notResult = ($.inArray(result, results) == -1), - notFuzzyResult = ($.inArray(result, fuzzyResults) == -1) + notFuzzyResult = ($.inArray(result, fuzzyResults) == -1), + notExactResults = ($.inArray(result, exactResults) == -1) ; - if(notResult && notFuzzyResult) { + if(notResult && notFuzzyResult && notExactResults) { array.push(result); } } From b78dc75fc17c93996dc2c1164b1c756f606fb4bc Mon Sep 17 00:00:00 2001 From: Jack Date: Wed, 7 Mar 2018 17:04:38 -0800 Subject: [PATCH 03/11] Fix visibility issue with onScreen calculations for long elements --- RELEASE-NOTES.md | 1 + src/definitions/behaviors/visibility.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) mode change 100644 => 100755 src/definitions/behaviors/visibility.js diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index f16cdafcc..5da458227 100755 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -5,6 +5,7 @@ **Bugs** - **Icons** - Fixes some icons that were incorrectly named. **Thanks hammy2899** [#6181](https://github.com/Semantic-Org/Semantic-UI/pull/6181) [#6180](https://github.com/Semantic-Org/Semantic-UI/pull/6180) [#6176](https://github.com/Semantic-Org/Semantic-UI/pull/6176) [#6175](https://github.com/Semantic-Org/Semantic-UI/pull/6175) - **Icons** - Increased specifity on `fitted icon` to fix compatibility with other components [#6125](https://github.com/Semantic-Org/Semantic-UI/issues/6125) +- **Visibility** - Fixed bug that could cause `onScreen` to not work properly for elements that are longer than screen. **Docs** - Fixes CDN links in docs **Thanks @KSH-code** diff --git a/src/definitions/behaviors/visibility.js b/src/definitions/behaviors/visibility.js old mode 100644 new mode 100755 index d5ab6c27b..789e6ddc7 --- a/src/definitions/behaviors/visibility.js +++ b/src/definitions/behaviors/visibility.js @@ -933,7 +933,7 @@ $.fn.visibility = function(parameters) { element.percentagePassed = 0; // meta calculations - element.onScreen = (element.topVisible && !element.bottomPassed); + element.onScreen = ((element.topVisible || element.passing) && !element.bottomPassed); element.passing = (element.topPassed && !element.bottomPassed); element.offScreen = (!element.onScreen); From 23a7efa3719dbab4d97a7c87b5bdea75179cf9cd Mon Sep 17 00:00:00 2001 From: Jack Date: Sun, 18 Mar 2018 13:53:45 -0700 Subject: [PATCH 04/11] Version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 22a92ef38..24bc0c95e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "semantic-ui", - "version": "2.3.0", + "version": "2.3.1", "title": "Semantic UI", "description": "Semantic empowers designers and developers by creating a shared vocabulary for UI.", "homepage": "http://www.semantic-ui.com", From ab535ba375e71e27aa41026e45b7aa4857d8c060 Mon Sep 17 00:00:00 2001 From: Jack Date: Sun, 18 Mar 2018 14:04:12 -0700 Subject: [PATCH 05/11] Use single quotes for string literals --- src/definitions/behaviors/api.js | 2 +- src/definitions/behaviors/form.js | 2 +- src/definitions/behaviors/visibility.js | 2 +- src/definitions/modules/accordion.js | 2 +- src/definitions/modules/checkbox.js | 2 +- src/definitions/modules/dimmer.js | 2 +- src/definitions/modules/dropdown.js | 6 +++--- src/definitions/modules/embed.js | 2 +- src/definitions/modules/modal.js | 2 +- src/definitions/modules/nag.js | 2 +- src/definitions/modules/popup.js | 2 +- src/definitions/modules/progress.js | 2 +- src/definitions/modules/rating.js | 2 +- src/definitions/modules/search.js | 2 +- src/definitions/modules/shape.js | 2 +- src/definitions/modules/sidebar.js | 2 +- src/definitions/modules/sticky.js | 2 +- src/definitions/modules/tab.js | 2 +- src/definitions/modules/transition.js | 2 +- 19 files changed, 21 insertions(+), 21 deletions(-) diff --git a/src/definitions/behaviors/api.js b/src/definitions/behaviors/api.js index 578e20162..cdcfc753d 100644 --- a/src/definitions/behaviors/api.js +++ b/src/definitions/behaviors/api.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; var window = (typeof window != 'undefined' && window.Math == Math) diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js index 35353ffbe..6c0d0172b 100644 --- a/src/definitions/behaviors/form.js +++ b/src/definitions/behaviors/form.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/behaviors/visibility.js b/src/definitions/behaviors/visibility.js index 789e6ddc7..8ae572c7f 100755 --- a/src/definitions/behaviors/visibility.js +++ b/src/definitions/behaviors/visibility.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/accordion.js b/src/definitions/modules/accordion.js index 170a5e805..818e3d62d 100644 --- a/src/definitions/modules/accordion.js +++ b/src/definitions/modules/accordion.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/checkbox.js b/src/definitions/modules/checkbox.js index 4c9298466..f88c4d09b 100644 --- a/src/definitions/modules/checkbox.js +++ b/src/definitions/modules/checkbox.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/dimmer.js b/src/definitions/modules/dimmer.js index 900566711..86bf308db 100755 --- a/src/definitions/modules/dimmer.js +++ b/src/definitions/modules/dimmer.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js index 82f87f336..d2687ae71 100644 --- a/src/definitions/modules/dropdown.js +++ b/src/definitions/modules/dropdown.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window @@ -2283,7 +2283,7 @@ $.fn.dropdown = function(parameters) { var length = module.get.query().length ; - $search.val( text.substr(0 , length)); + $search.val( text.substr(0, length)); }, scrollPosition: function($item, forceScroll) { var @@ -3889,7 +3889,7 @@ $.fn.dropdown.settings.templates = { ? 'disabled ' : '' ; - html += '
' + html += '
'; html += option[fields.name]; html += '
'; }); diff --git a/src/definitions/modules/embed.js b/src/definitions/modules/embed.js index 6ed6f5a01..682a6ec23 100644 --- a/src/definitions/modules/embed.js +++ b/src/definitions/modules/embed.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/modal.js b/src/definitions/modules/modal.js index 66ce70d30..b2ccea05e 100755 --- a/src/definitions/modules/modal.js +++ b/src/definitions/modules/modal.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/nag.js b/src/definitions/modules/nag.js index f8d862ce0..79d431130 100644 --- a/src/definitions/modules/nag.js +++ b/src/definitions/modules/nag.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/popup.js b/src/definitions/modules/popup.js index ad25d879e..26e59cb1f 100644 --- a/src/definitions/modules/popup.js +++ b/src/definitions/modules/popup.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/progress.js b/src/definitions/modules/progress.js index 846fa4c8b..544e8c77e 100644 --- a/src/definitions/modules/progress.js +++ b/src/definitions/modules/progress.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/rating.js b/src/definitions/modules/rating.js index 1affce2c1..e1a643b0e 100644 --- a/src/definitions/modules/rating.js +++ b/src/definitions/modules/rating.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/search.js b/src/definitions/modules/search.js index c06ab1b49..c770b74d4 100644 --- a/src/definitions/modules/search.js +++ b/src/definitions/modules/search.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/shape.js b/src/definitions/modules/shape.js index d39904643..5ba72efe7 100644 --- a/src/definitions/modules/shape.js +++ b/src/definitions/modules/shape.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/sidebar.js b/src/definitions/modules/sidebar.js index 54b61a61c..1dcb3ae15 100644 --- a/src/definitions/modules/sidebar.js +++ b/src/definitions/modules/sidebar.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/sticky.js b/src/definitions/modules/sticky.js index 4887c9859..436b1c3eb 100755 --- a/src/definitions/modules/sticky.js +++ b/src/definitions/modules/sticky.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/tab.js b/src/definitions/modules/tab.js index 383a8d561..4eedf6caa 100644 --- a/src/definitions/modules/tab.js +++ b/src/definitions/modules/tab.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window diff --git a/src/definitions/modules/transition.js b/src/definitions/modules/transition.js index 1dedef9eb..d6e2349d2 100644 --- a/src/definitions/modules/transition.js +++ b/src/definitions/modules/transition.js @@ -10,7 +10,7 @@ ;(function ($, window, document, undefined) { -"use strict"; +'use strict'; window = (typeof window != 'undefined' && window.Math == Math) ? window From 0e5c82466f675620540216fd2df350090ea688c7 Mon Sep 17 00:00:00 2001 From: Jack Date: Sun, 18 Mar 2018 14:16:53 -0700 Subject: [PATCH 06/11] Labels should check for label existence not value existence Fixes #6123 #6271 #6280 #6276 --- src/definitions/modules/dropdown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js index d2687ae71..5b18f2501 100644 --- a/src/definitions/modules/dropdown.js +++ b/src/definitions/modules/dropdown.js @@ -2586,7 +2586,7 @@ $.fn.dropdown = function(parameters) { ; $label = settings.onLabelCreate.call($label, escapedValue, text); - if(module.has.value(value)) { + if(module.has.label(value)) { module.debug('User selection already exists, skipping', escapedValue); return; } From 691089301b0305168bdf9157515b3f13d771e77b Mon Sep 17 00:00:00 2001 From: Jack Date: Sun, 18 Mar 2018 14:26:08 -0700 Subject: [PATCH 07/11] Fix the 'ignoreCase' option when using multiselect to work with has.label #6123 --- src/definitions/modules/dropdown.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js index 5b18f2501..943178013 100644 --- a/src/definitions/modules/dropdown.js +++ b/src/definitions/modules/dropdown.js @@ -2579,6 +2579,9 @@ $.fn.dropdown = function(parameters) { escapedValue = module.escape.value(value), $label ; + if(settings.ignoreCase) { + escapedValue = escapedValue.toLowerCase(); + } $label = $('') .addClass(className.label) .attr('data-' + metadata.value, escapedValue) @@ -3043,6 +3046,9 @@ $.fn.dropdown = function(parameters) { escapedValue = module.escape.value(value), $labels = $module.find(selector.label) ; + if(settings.ignoreCase) { + escapedValue = escapedValue.toLowerCase(); + } return ($labels.filter('[data-' + metadata.value + '="' + module.escape.string(escapedValue) +'"]').length > 0); }, maxSelections: function() { From 6b316474ae7ea27bda950a269ba44e2aa6311bc8 Mon Sep 17 00:00:00 2001 From: Jack Date: Sun, 18 Mar 2018 14:26:24 -0700 Subject: [PATCH 08/11] Rlsnotes #6193 --- RELEASE-NOTES.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 5da458227..e868783dc 100755 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -2,6 +2,9 @@ ### Version 2.3.1 - Feb 23, 2018 +**Critical Bugs** +- **Dropdown** - Fixed issue in `2.3.0` that could cause multiselect dropdowns initialized by converting `` to not add initial selected options. #6123 **Bugs** +- **Search** - Fixes using category search with `fullTextSearch: 'exact'` returning duplicate results #6223 #6221 @Thanks @prudho - **Icons** - Fixes some icons that were incorrectly named. **Thanks hammy2899** [#6181](https://github.com/Semantic-Org/Semantic-UI/pull/6181) [#6180](https://github.com/Semantic-Org/Semantic-UI/pull/6180) [#6176](https://github.com/Semantic-Org/Semantic-UI/pull/6176) [#6175](https://github.com/Semantic-Org/Semantic-UI/pull/6175) - **Icons** - Increased specifity on `fitted icon` to fix compatibility with other components [#6125](https://github.com/Semantic-Org/Semantic-UI/issues/6125) - **Visibility** - Fixed bug that could cause `onScreen` to not work properly for elements that are longer than screen. From 050d182d6a473abd1b00bd02f2a42ab41fac82a2 Mon Sep 17 00:00:00 2001 From: Jack Date: Sun, 18 Mar 2018 14:41:36 -0700 Subject: [PATCH 11/11] Rlsnotes #4183 --- RELEASE-NOTES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 0538fac80..6288193b7 100755 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -6,6 +6,7 @@ - **Dropdown** - Fixed issue in `2.3.0` that could cause multiselect dropdowns initialized by converting `