From 209db36bf20507dadc5d4a50d09f4ebbf7903a2e Mon Sep 17 00:00:00 2001 From: jlukic Date: Thu, 19 Mar 2015 18:18:16 -0400 Subject: [PATCH 1/9] #1927 adds back in transform --- src/definitions/modules/transition.less | 1 + 1 file changed, 1 insertion(+) diff --git a/src/definitions/modules/transition.less b/src/definitions/modules/transition.less index fedebb3fc..755ba07ca 100755 --- a/src/definitions/modules/transition.less +++ b/src/definitions/modules/transition.less @@ -59,6 +59,7 @@ display: block !important; visibility: visible !important; backface-visibility: @backfaceVisibility; + transform: rotateZ(0deg); } /* Disabled */ From 1eca2468657427a53b1f5298d70109db6c6481fb Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 20 Mar 2015 11:19:15 -0400 Subject: [PATCH 2/9] Fixes #1990, tab affected by casing --- src/definitions/modules/tab.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/definitions/modules/tab.js b/src/definitions/modules/tab.js index ddc2f17d2..aa9ec1dfd 100644 --- a/src/definitions/modules/tab.js +++ b/src/definitions/modules/tab.js @@ -258,6 +258,9 @@ $.fn.tab = function(parameters) { changeTab: function(tabPath) { var + tabPath = (typeof tabPath == 'string') + ? tabPath.toLowerCase() + : tabPath, pushStateAvailable = (window.history && window.history.pushState), shouldIgnoreLoad = (pushStateAvailable && settings.ignoreFirstLoad && firstLoad), remoteContent = (settings.auto || $.isPlainObject(settings.apiSettings) ), From 36613f54609580517d5a2cc04d0d36d6059caeb4 Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 20 Mar 2015 11:32:00 -0400 Subject: [PATCH 3/9] #1990 rlsnotes --- RELEASE-NOTES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index c0dcb113b..48b1ca964 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -63,6 +63,7 @@ - **Modal** - `scrollable modal` now correctly adds padding below modal - **Modal** - Modal with `detachable: false` inside `ui sidebar` `pusher` element will now show correctly - **Popup** - Fixes issue with `min-width` in firefox exceeding `max-width` causing element to not wrap correctly +- **Tab** - Tab name is no longer case sensitive - **Table** - `very basic table` now works together with `padded table` - **Table** - Fix inheritance of text alignment and vertical alignment - **Transition** - Fixed bug where transition could sometimes not occur when an element was determined to always be hidden From 683b5aa5fcb14d181a140093aa925c629f4cc127 Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 20 Mar 2015 11:46:20 -0400 Subject: [PATCH 4/9] #1996 #1992 issue with calc interpolation in dropdown LESS --- src/definitions/modules/dropdown.less | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/definitions/modules/dropdown.less b/src/definitions/modules/dropdown.less index c5bdde85c..baaf0bfbf 100755 --- a/src/definitions/modules/dropdown.less +++ b/src/definitions/modules/dropdown.less @@ -400,7 +400,7 @@ select.ui.dropdown { /* Scrollbar in IE */ @media all and (-ms-high-contrast:none) { .ui.selection.dropdown .menu { - min-width: calc(100% - @scrollBarWidth); + min-width: ~"calc(100% - "@scrollBarWidth~")"; } } @@ -430,7 +430,7 @@ select.ui.dropdown { border-top: @selectionItemDivider; padding-left: @selectionHorizontalPadding !important; /* Add in spacing for scroll bar */ - padding-right: calc(@selectionHorizontalPadding + 1em) !important; + padding-right: ~"calc("@selectionHorizontalPadding~" + 1em) !important~"; white-space: normal; word-wrap: normal; } From 8102cff1846d695669e8d755aca7b9c384888fd8 Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 20 Mar 2015 11:56:41 -0400 Subject: [PATCH 5/9] Fix gulp watch not erroring out with legitimate errors --- tasks/config/project/tasks.js | 4 ++++ tasks/watch.js | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tasks/config/project/tasks.js b/tasks/config/project/tasks.js index 1a8e90fe6..0cc7eb3d5 100644 --- a/tasks/config/project/tasks.js +++ b/tasks/config/project/tasks.js @@ -83,6 +83,10 @@ module.exports = { if(error.filename.match(/theme.less/)) { console.error('Looks like your theme.config is out of date. You will need to add new elements from theme.config.example'); } + else { + console.log(error); + this.emit('end'); + } } } }, diff --git a/tasks/watch.js b/tasks/watch.js index a4a9ecee8..55980d6ff 100644 --- a/tasks/watch.js +++ b/tasks/watch.js @@ -136,6 +136,7 @@ module.exports = function(callback) { stream = gulp.src(lessPath) .pipe(plumber(settings.plumber.less)) .pipe(less(settings.less)) + .pipe(print(log.created)) .pipe(replace(comments.variables.in, comments.variables.out)) .pipe(replace(comments.license.in, comments.license.out)) .pipe(replace(comments.large.in, comments.large.out)) @@ -170,7 +171,6 @@ module.exports = function(callback) { gulp.start('package compressed css'); }) ; - } else { console.log('Cannot find UI definition at path', lessPath); From 3510d967df4f815cb3ee87def3f931474cc59d3f Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 20 Mar 2015 11:57:02 -0400 Subject: [PATCH 6/9] Fix menu to have same border color on keyboard tab --- src/definitions/modules/dropdown.less | 21 ++++++++++++------- src/themes/default/modules/dropdown.variables | 10 +++++---- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/src/definitions/modules/dropdown.less b/src/definitions/modules/dropdown.less index baaf0bfbf..ce6654ffa 100755 --- a/src/definitions/modules/dropdown.less +++ b/src/definitions/modules/dropdown.less @@ -450,22 +450,29 @@ select.ui.dropdown { border: @selectionBorder; opacity: @disabledOpacity !important; } +/* Visible */ +.ui.selection.dropdown.visible { + border-color: @selectionVisibleBorderColor; + box-shadow: @selectionVisibleBoxShadow; +} + +.ui.selection.visible.dropdown .menu { + border-color: @selectionVisibleBorderColor; + box-shadow: @selectionVisibleMenuBoxShadow; +} + /* Visible Hover */ .ui.selection.visible.dropdown:hover { border-color: @selectionVisibleHoverBorderColor; box-shadow: @selectionVisibleHoverBoxShadow; } -.ui.selection.visible.dropdown:hover .menu { - border: @selectionVisibleHoverMenuBorder; + +.ui.selection.visible.dropdown .menu { + border-color: @selectionVisibleHoverBorderColor; box-shadow: @selectionVisibleHoverMenuBoxShadow; } -/* Visible */ -.ui.selection.dropdown.visible { - border-color: @selectionVisibleBorderColor; - box-shadow: @selectionVisibleBoxShadow; -} /* Active Item */ .ui.selection.active.dropdown > .text:not(.default), diff --git a/src/themes/default/modules/dropdown.variables b/src/themes/default/modules/dropdown.variables index f79baf5cd..d92a37952 100644 --- a/src/themes/default/modules/dropdown.variables +++ b/src/themes/default/modules/dropdown.variables @@ -172,15 +172,17 @@ @selectionHoverBoxShadow: 0px 0px 2px 0px rgba(0, 0, 0, 0.05); /* Visible */ -@selectionVisibleBorderColor: @selectedBorderColor; -@selectionVisibleBoxShadow: 0px 0px 4px 0px rgba(0, 0, 0, 0.08); @selectionVisibleTextFontWeight: normal; @selectionVisibleTextColor: @hoveredTextColor; +@selectionVisibleBorderColor: @selectedBorderColor; +@selectionVisibleBoxShadow: 0px 0px 4px 0px rgba(0, 0, 0, 0.08); +@selectionVisibleMenuBoxShadow: 0px 2px 6px 0px @borderColor; + /* Visible Hover */ @selectionVisibleHoverBorderColor: @selectedBorderColor; -@selectionVisibleHoverBoxShadow: 0px 0px 4px 0px rgba(0, 0, 0, 0.08); -@selectionVisibleHoverMenuBoxShadow: 0px 2px 6px 0px @borderColor; +@selectionVisibleHoverBoxShadow: @selectionVisibleBoxShadow; +@selectionVisibleHoverMenuBoxShadow: @selectionVisibleMenuBoxShadow; @selectionVisibleConnectingBorder: 0em; @selectionVisibleIconOpacity: 1; From a6447b11501d24598bd0864202e48bdbf9d78f7b Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 20 Mar 2015 12:36:45 -0400 Subject: [PATCH 7/9] Darken toggle checkbox text --- src/definitions/modules/checkbox.less | 2 +- src/themes/default/modules/checkbox.variables | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/definitions/modules/checkbox.less b/src/definitions/modules/checkbox.less index 14ad087b4..a3479c50b 100755 --- a/src/definitions/modules/checkbox.less +++ b/src/definitions/modules/checkbox.less @@ -102,7 +102,7 @@ opacity: 0; color: @checkboxColor; - transition: all 0.1s ease; + transition: all @transitionDuration @transitionEasing; } /*-------------- diff --git a/src/themes/default/modules/checkbox.variables b/src/themes/default/modules/checkbox.variables index ae911781c..5a63bf005 100644 --- a/src/themes/default/modules/checkbox.variables +++ b/src/themes/default/modules/checkbox.variables @@ -130,7 +130,7 @@ @toggleHoverColor: @toggleFocusColor; @toggleOffLabelColor: @checkboxColor; -@toggleOnLabelColor: @positiveCheckbox; +@toggleOnLabelColor: @positiveTextColor; @toggleOnLaneColor: @positiveCheckbox; From d4dc873241d6a16f0a60292a1a794e636e609bdb Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 20 Mar 2015 12:37:00 -0400 Subject: [PATCH 8/9] Fix flat dropdown style --- src/themes/flat/collections/form.overrides | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/themes/flat/collections/form.overrides b/src/themes/flat/collections/form.overrides index e9480415b..68f40fe81 100644 --- a/src/themes/flat/collections/form.overrides +++ b/src/themes/flat/collections/form.overrides @@ -18,6 +18,10 @@ border-bottom: 1px solid #DDDDDD; border-radius: 0em !important; } +.ui.form .selection.dropdown > .menu { + border-top-width: 1px !important; + border-radius: @defaultBorderRadius !important; +} .ui.form .ui.icon.input > .icon { width: 1em; From 36d91ff3a65eabea387f09a2a3856be465d575a9 Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 20 Mar 2015 13:10:17 -0400 Subject: [PATCH 9/9] RLSNotes: --- RELEASE-NOTES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 48b1ca964..84a3215eb 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -30,6 +30,7 @@ - **Visibility/Sticky** - Visibility now uses pub/sub pattern to greatly improve scroll performance when attaching multiple events **Changes** +- **Checkbox** - Slider now uses `positive text color` a slightly more legible green for label - **Dropdown** - Dropdown padding values now resolve to exact pixel values from em - **Grid** - Small computer `page grid` gutters have been adjusted from 8% to 3% to allow for roomier layouts on small screens. - **Grid** - `center aligned` no longer centers rows, just text. Use `centered grid` to center a grid column on the page.