From b7b4e310a15510ba2a207481a99b0ffb360c94b7 Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 9 Jan 2015 16:28:24 -0500 Subject: [PATCH] Remove proxy calls from dimmer --- RELEASE-NOTES.md | 3 ++- src/definitions/modules/dimmer.js | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 120ee921f..8f6d666ec 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -8,10 +8,11 @@ **Enhancements** - **Sidebar** - Having a sidebar visible on page load is now much simpler. You can include ``ui visible sidebar`` on page load to have a sidebar element appear on page load. To close call `$('.ui.sidebar').sidebar('hide')` + **Code / Build** - **Build** - `Dist/` files now have file permissions `644` by default. Can adjust in `semantic.json`. You will need to run `npm install` to add the new gulp-chmod dependency *Thanks @PeterDaveHello* - **Modules** - Remove use of deprecated `.size()` for `.length` across all modules -- **Modules** - Use of `$.proxy` swapped to native `function.call()` for performance gains +- **Modules** - Use of `$.proxy` swapped to native `function.call()` for performance gains across all modules **Bugs** - **Popup** - Popup no longer blurs element on popup hide diff --git a/src/definitions/modules/dimmer.js b/src/definitions/modules/dimmer.js index a1343ff7e..3d40500c3 100644 --- a/src/definitions/modules/dimmer.js +++ b/src/definitions/modules/dimmer.js @@ -172,8 +172,8 @@ $.fn.dimmer = function(parameters) { module.debug('Showing dimmer', $dimmer, settings); if( (!module.is.dimmed() || module.is.animating()) && module.is.enabled() ) { module.animate.show(callback); - $.proxy(settings.onShow, element)(); - $.proxy(settings.onChange, element)(); + settings.onShow.call(element); + settings.onChange.call(element); } else { module.debug('Dimmer is already shown or disabled'); @@ -188,8 +188,8 @@ $.fn.dimmer = function(parameters) { if( module.is.dimmed() || module.is.animating() ) { module.debug('Hiding dimmer', $dimmer); module.animate.hide(callback); - $.proxy(settings.onHide, element)(); - $.proxy(settings.onChange, element)(); + settings.onHide.call(element); + settings.onChange.call(element); } else { module.debug('Dimmer is not visible');