From b61569620932b53e67dbbde469ccfdbf9fa8764f Mon Sep 17 00:00:00 2001 From: Jack Lukic Date: Tue, 11 Aug 2015 11:40:23 -0400 Subject: [PATCH] Fixes #2806 issue with trim in dropdown --- RELEASE-NOTES.md | 1 + src/definitions/modules/dropdown.js | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 730064739..01decd871 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -27,6 +27,7 @@ - **Transition** - Transition callbacks now all have the correct `this` set. #2758 - **Form / Input** - Fixes `::placeholder` text color for `ui error input`, modifies form error placeholder color to distinguish from form value error color #2786 - **Form** - Date input and other special input in chrome now are the same height as normal input (adds custom vendor shadow dom styling) #2704 +- **Dropdown** - Remove use of `trim` which causes issues IE 11 and below #2806 **Additional Bugs** - **Build Tools** - Fixes issue on `win` platform where packaged theme would not correctly update when using watch due to regExp not matching windows path separators. diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js index 49da61ddd..ebcd718e4 100644 --- a/src/definitions/modules/dropdown.js +++ b/src/definitions/modules/dropdown.js @@ -1509,8 +1509,8 @@ $.fn.dropdown = function(parameters) { return ($choice.data(metadata.text) !== undefined) ? $choice.data(metadata.text) : (preserveHTML) - ? $choice.html().trim() - : $choice.text().trim() + ? $.trim($choice.html()) + : $.trim($choice.text()) ; } }, @@ -1522,7 +1522,7 @@ $.fn.dropdown = function(parameters) { return ($choice.data(metadata.value) !== undefined) ? $choice.data(metadata.value) : (typeof choiceText === 'string') - ? choiceText.toLowerCase().trim() + ? $.trim(choiceText.toLowerCase()) : choiceText ; },