Browse Source

Fix issue with scrolling modal and allowMultiple #2423

pull/5603/merge
Jack 7 years ago
parent
commit
aa1d36b232
2 changed files with 4 additions and 2 deletions
  1. 2
      RELEASE-NOTES.md
  2. 4
      src/definitions/modules/modal.less

2
RELEASE-NOTES.md

@ -4,6 +4,7 @@
**Critical Bugs** **Critical Bugs**
- **Form** - Fixes issue where radio checkbox would not return correct value from `get values` **Thanks @tincdev** #5713 #6043 - **Form** - Fixes issue where radio checkbox would not return correct value from `get values` **Thanks @tincdev** #5713 #6043
- **Modal** - Fixes issue where an oversized modal would appear behind an existing modal when using `allowMultiple: true` and a second modal that is larger than the sreen height. #2423
**Enhancements** **Enhancements**
- **Button** - Youtube's red color now matches their current brand guidelines **Thanks @hammy2899** #6110 - **Button** - Youtube's red color now matches their current brand guidelines **Thanks @hammy2899** #6110
@ -11,7 +12,6 @@
- **Reveal** - `ribbon label` can now work with `reveal` #5681 - **Reveal** - `ribbon label` can now work with `reveal` #5681
**Bugs** **Bugs**
- **Form** - Fixe
- **Dropdown** - Fixed issue where dropdown could incorrectly open upward and leftward opening when using `context` setting due to an incorrect offset calculation. **Thanks @dannyBies** #5974 #5366 - **Dropdown** - Fixed issue where dropdown could incorrectly open upward and leftward opening when using `context` setting due to an incorrect offset calculation. **Thanks @dannyBies** #5974 #5366
- **Visibility** - Fixes issue where `bottomPassed` and `topPassed` would not fire under some conditions - **Visibility** - Fixes issue where `bottomPassed` and `topPassed` would not fire under some conditions
- **Dropdown** - Fixes issue where dropdowns might accidentally animate closed two times when quickly tabbing through fields - **Dropdown** - Fixes issue where dropdowns might accidentally animate closed two times when quickly tabbing through fields

4
src/definitions/modules/modal.less

@ -353,7 +353,9 @@
position: fixed; position: fixed;
} }
.modals.dimmer .ui.scrolling.modal { .modals.dimmer .ui.scrolling.modal {
position: static !important;
position: relative !important;
left: auto !important;
top: auto !important;
margin: @scrollingMargin auto !important; margin: @scrollingMargin auto !important;
} }

Loading…
Cancel
Save