Browse Source

Merge pull request #6405 from chen-ye/patch-1

[Site] fix @inputLineHeight comment spelling error
pull/6440/head
Jack Lukic 6 years ago
committed by GitHub
parent
commit
a919070271
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 18 deletions
  1. 33
      RELEASE-NOTES.md
  2. 2
      src/themes/default/globals/site.variables

33
RELEASE-NOTES.md

@ -1,6 +1,5 @@
## RELEASE NOTES ## RELEASE NOTES
### Version 2.3.2 - June 17, 2018 ### Version 2.3.2 - June 17, 2018
**Enhancements** **Enhancements**
@ -14,31 +13,31 @@
### Version 2.3.1 - Mar 18, 2018 ### Version 2.3.1 - Mar 18, 2018
**Note on Flex Modals**
There will be an update shortly to resolve issues related to flex modals when using multiple modals and `detachable: false`, in order to not hold up this release, we've decided to move forward without a general solve.
> **A Special Message about Flex Modals**
> There will be an update shortly to resolve issues related to flex modals when using multiple modals and `detachable: false`, in order to not hold up this release, we've decided to move forward without a fix.
A general solution will most likely require branching code for IE11 which will disable flex (as IE11 doesnt correctly implement the latest spec for [absolute positioned flex containers](https://developers.google.com/web/updates/2016/06/absolute-positioned-children)).
> A general solution will most likely require branching code for IE11 which will disable flex (as IE11 doesnt correctly implement the latest spec for [absolute positioned flex containers](https://developers.google.com/web/updates/2016/06/absolute-positioned-children)).
**Critical Bugs** **Critical Bugs**
- **Dropdown** - Fixed issue in `2.3.0` that could cause multiselect dropdowns initialized by converting `<select>` to not add initial selected options. #6123
- **Search** - Fixes using category search with `fullTextSearch: 'exact'` **@Thanks @prudho** returning duplicate results #6223 #6221
- **Icon** - Fixes `centered` and `bordered` icons appearing incorrectly with FA5 **Thanks @w96k** #6192
- **Icons** - Fixes missing aliases/incorrect icons from Font Awesome 5 port in `2.3.0` **Thanks hammy2899** #6181 #6175 #6176 #6174 #6175
- **Icons** - Fixed issue where `link icon` were appearing incorrectly due to changes in icons #6180
- **Dropdown** - Fixed issue in `2.3.0` that could cause multiselect dropdowns initialized by converting `<select>` to not add initial selected options. [#6123](https://github.com/Semantic-Org/Semantic-UI/issues/6123)
- **Search** - Fixes using category search with `fullTextSearch: 'exact'` **@Thanks @prudho** returning duplicate results [#6223](https://github.com/Semantic-Org/Semantic-UI/issues/6223) [#6221](https://github.com/Semantic-Org/Semantic-UI/issues/6221)
- **Icon** - Fixes `centered` and `bordered` icons appearing incorrectly with FA5 **Thanks @w96k** [#6192](https://github.com/Semantic-Org/Semantic-UI/issues/6192)
- **Icons** - Fixes missing aliases/incorrect icons from Font Awesome 5 port in `2.3.0` **Thanks hammy2899** [#6181](https://github.com/Semantic-Org/Semantic-UI/issues/6181) [#6175](https://github.com/Semantic-Org/Semantic-UI/issues/6175) [#6176](https://github.com/Semantic-Org/Semantic-UI/issues/6176) [#6174](https://github.com/Semantic-Org/Semantic-UI/issues/6174) [#6175](https://github.com/Semantic-Org/Semantic-UI/issues/6175)
- **Icons** - Fixed issue where `link icon` were appearing incorrectly due to changes in icons [#6180](https://github.com/Semantic-Org/Semantic-UI/issues/6180)
**Enhancements** **Enhancements**
- **Search** - Adds disabled variation **Thanks @prudho** #6225
- **Form Validation** - Form can now return their validation prompt dynamically based on their current value. **Thanks @xDaizu** #6016 #3864
- **Search** - Adds disabled variation **Thanks @prudho** [#6225](https://github.com/Semantic-Org/Semantic-UI/issues/6225)
- **Form Validation** - Form can now return their validation prompt dynamically based on their current value. **Thanks @xDaizu** [#6016](https://github.com/Semantic-Org/Semantic-UI/issues/6016) [#3864](https://github.com/Semantic-Org/Semantic-UI/issues/3864)
**Bugs** **Bugs**
- **Dropdown** - Fixed `onChange` missing `text` from callback when dropdown is set to `action: 'select'` #4183 #4510
- **Icons** - Fixes some icons that were incorrectly named. **Thanks hammy2899** #6181
- **Dropdown** - Fixed `onChange` missing `text` from callback when dropdown is set to `action: 'select'` **Thanks @martinduparc** [#4183](https://github.com/Semantic-Org/Semantic-UI/issues/4183) [#4510](https://github.com/Semantic-Org/Semantic-UI/issues/4510)
- **Icons** - Fixes some icons that were incorrectly named. **Thanks hammy2899** [#6181](https://github.com/Semantic-Org/Semantic-UI/issues/6181)
- **Icons** - Added ability to choose whether solid, outline and brand icons should be included in your theme via the `@importSolidIcons`, `importRegularIcons` and `@importBrandIcons` variables **Thanks hammy2899** - **Icons** - Added ability to choose whether solid, outline and brand icons should be included in your theme via the `@importSolidIcons`, `importRegularIcons` and `@importBrandIcons` variables **Thanks hammy2899**
- **Icons** - Increased specifity on `fitted icon` to fix compatibility with other components #6125
- **Icons** - Increased specifity on `fitted icon` to fix compatibility with other components [#6125](https://github.com/Semantic-Org/Semantic-UI/issues/6125)
- **Visibility** - Fixed bug that could cause `onScreen` callback to not occur properly for elements that are taller than screen. - **Visibility** - Fixed bug that could cause `onScreen` callback to not occur properly for elements that are taller than screen.
- **Menu** - Fixes `disabled item` showing hover style for `secondary menu` **Thanks @tcmal** #6268
- **CSS Variables** - Added use of `@normal` for normal font weight for all non-default themes included in repo. #6227
- **Image** - Fixes margin being applied twice to `ui images` #6224
- **Menu** - Fixes `disabled item` showing hover style for `secondary menu` **Thanks @tcmal** [#6268](https://github.com/Semantic-Org/Semantic-UI/issues/6268)
- **CSS Variables** - Added use of `@normal` for normal font weight for all non-default themes included in repo. [#6227](https://github.com/Semantic-Org/Semantic-UI/issues/6227)
- **Image** - Fixes margin being applied twice to `ui images` [#6224](https://github.com/Semantic-Org/Semantic-UI/issues/6224)
- **Reveal** - Fix `whitespace: nowrap;` applying to content inside `slide reveal` and `move reveal` - **Reveal** - Fix `whitespace: nowrap;` applying to content inside `slide reveal` and `move reveal`
**Docs** **Docs**

2
src/themes/default/globals/site.variables

@ -85,7 +85,7 @@
@inputPlaceholderColor: lighten(@inputColor, 75); @inputPlaceholderColor: lighten(@inputColor, 75);
@inputPlaceholderFocusColor: lighten(@inputColor, 45); @inputPlaceholderFocusColor: lighten(@inputColor, 45);
/* Line Height Default For Inputs in Browser (Descendors are 17px at 14px base em) */
/* Line Height Default For Inputs in Browser (Descenders are 17px at 14px base em) */
@inputLineHeight: unit((17 / 14), em); @inputLineHeight: unit((17 / 14), em);
/*------------------- /*-------------------

Loading…
Cancel
Save