From 74646843d2d21103d395efe67e5d7416fb28bc0b Mon Sep 17 00:00:00 2001 From: jlukic Date: Wed, 11 Mar 2015 17:39:59 -0400 Subject: [PATCH] Button fixes icon height instead of using 0.9em icon height --- RELEASE-NOTES.md | 13 +++++++++---- src/definitions/elements/button.less | 1 + src/themes/default/elements/button.variables | 11 ++++++----- src/themes/default/globals/site.variables | 4 ++-- 4 files changed, 18 insertions(+), 11 deletions(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index b1f444578..a15e774ed 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -1,26 +1,31 @@ ## RELEASE NOTES -### Version 1.12.0 - March 6, 2015 +### Version 1.12.0 - March 11, 2015 **New UI** -- **Container** - +- **Container** - Containers are fixed width containers meant for holding page contents, and are a simpler alternative to `ui page grid`, view more [examples in docs](http://www.semantic-ui.com/elements/container.html#examples) **Major Changes** -- **Menu** - Menu now uses flexbox. This is a *significant* change which means +- **Menu** - Menu now uses flexbox. This allows menu items to match each others heights regardless of each items content size **Enhancements** -- **Menu** - Horizontal menus now set a default image size when none specified +- **Headers** - Added new header type `sub header`, useful for displaying small headers alongside text content. See examples [in the header docs](http://www.semantic-ui.com/elements/header.html#sub-headers) +- **Menu** - Horizontal menus now set a default image size for images / logos +- **Menu** - Added many new variables to menu theme - **Segment** - Added `padded` and `very padded` segment variations - **Grid** - `equal height` and `equal width` now work without `row` wrappers - **Visibility/Sticky** - Visibility now uses pub/sub pattern to greatly improve scroll performance when attaching multiple events - **Visibility/Sticky** - Visibility and sticky now refresh automatically after page content loading to deal with changes in position from images loading **Changes** +- **Menu** - Horizontal menus no longer use pointers on `active item` in the default theme +- **Menu** - Active sub-menu items are now `bold` - **Table** - Table cells now default to top vertical alignment. - **Grid** - Small computer `page grid` gutters have been adjusted from 8% to 3% to allow for roomier layouts on small screens. **Bugs** - **All Modules** - Performance logging now delays 500ms instead of 100ms for console logging to ensure all logs are captured in one group +- **Dropdown** - Fixes issue with disappearing headers inside of `ui dropdown` when nested in `ui menu` - **Grid** - Fixes colored grid columns not appearing when not nested in rows - **Label** - Labels inside `header` now vertical align better by accounting for line height offset - **Dropdown** - Fix bug where `onChange` would call even when reselecting current value diff --git a/src/definitions/elements/button.less b/src/definitions/elements/button.less index 0b691f7df..c3c7ed5c2 100755 --- a/src/definitions/elements/button.less +++ b/src/definitions/elements/button.less @@ -514,6 +514,7 @@ ---------------*/ .ui.button > .icon { + height: @iconHeight; opacity: @iconOpacity; margin: @iconMargin; transition: @iconTransition; diff --git a/src/themes/default/elements/button.variables b/src/themes/default/elements/button.variables index 3ee2cf2d7..cc07f7496 100644 --- a/src/themes/default/elements/button.variables +++ b/src/themes/default/elements/button.variables @@ -41,6 +41,7 @@ ; /* Icon */ +@iconHeight: 0.9em; @iconOpacity: 0.8; @iconDistance: 0.4em; @iconColor: ''; @@ -57,11 +58,11 @@ @invertedLoaderFillColor: rgba(0, 0, 0, 0.15); @transition: - opacity 0.1s @transitionEasing, - background-color 0.1s @transitionEasing, - color 0.1s @transitionEasing, - box-shadow 0.1s @transitionEasing, - background 0.1s @transitionEasing + opacity @transitionDuration @transitionEasing, + background-color @transitionDuration @transitionEasing, + color @transitionDuration @transitionEasing, + box-shadow @transitionDuration @transitionEasing, + background @transitionDuration @transitionEasing ; /* @willChange: box-shadow, transform, opacity, color, background; diff --git a/src/themes/default/globals/site.variables b/src/themes/default/globals/site.variables index 6b7841446..22ca0ae9d 100644 --- a/src/themes/default/globals/site.variables +++ b/src/themes/default/globals/site.variables @@ -318,8 +318,8 @@ @unselectedTextColor : rgba(0, 0, 0, 0.4); @hoveredTextColor : rgba(0, 0, 0, 0.8); -@pressedTextColor : rgba(0, 0, 0, 0.8); -@selectedTextColor : rgba(0, 0, 0, 0.8); +@pressedTextColor : rgba(0, 0, 0, 0.9); +@selectedTextColor : rgba(0, 0, 0, 0.9); @disabledTextColor : rgba(0, 0, 0, 0.2); @invertedTextColor : rgba(255, 255, 255, 1);