Adds remove to dimmer destroy fixes #151, removes right margin changes

to icon sizes, removes fixed height from menus fixing #141, tweaks input positioning in menus. Former-commit-id: 5f26c0eb60 Former-commit-id: d436750639
11 years ago · 724d04e2f0
23 changed files with 47 additions and 38 deletions
--- a/build/less/collections/menu.less.REMOVED.git-id
+++ b/build/less/collections/menu.less.REMOVED.git-id
@ -1 +1 @@
-ae5be9219aa61370d76209f2c0efe1730f7a4f8a
+938a77368926e4c24478b94333049fc8a2662ad5
--- a/build/less/elements/icon.less
+++ b/build/less/elements/icon.less
@ -756,16 +756,13 @@ i.icon {
 }
 i.large.icon {
  font-size: 2em;
-  margin-right: 0.5em;
  vertical-align: middle;
 }
 i.huge.icon {
  font-size: 4em;
-  margin-right: 0.75em;
  vertical-align: middle;
 }
 i.massive.icon {
  font-size: 8em;
-  margin-right: 1em;
  vertical-align: middle;
 }
--- a/build/less/modules/dimmer.js
+++ b/build/less/modules/dimmer.js
@ -115,6 +115,7 @@ $.fn.dimmer = function(parameters) {
          ;
          $dimmer
            .off(eventNamespace)
+            .remove()
          ;
        },

--- a/build/minified/modules/dimmer.js
+++ b/build/minified/modules/dimmer.js
@ -115,6 +115,7 @@ $.fn.dimmer = function(parameters) {
          ;
          $dimmer
            .off(eventNamespace)
+            .remove()
          ;
        },

--- a/build/packaged/css/semantic.css.REMOVED.git-id
+++ b/build/packaged/css/semantic.css.REMOVED.git-id
@ -1 +1 @@
-4d1a687e483032ac1b73bd5fb89fd157574e7a35
+f6954ada100fee5816c6469d55133bbaee195cb0
--- a/build/packaged/javascript/semantic.js.REMOVED.git-id
+++ b/build/packaged/javascript/semantic.js.REMOVED.git-id
@ -1 +1 @@
-cc8df66b4e0febc22293c8109ba70d035b958c5f
+263cdcca09a4b62ed0dfc6de95dab1efdf34eff3
--- a/build/uncompressed/collections/menu.css
+++ b/build/uncompressed/collections/menu.css
@ -173,14 +173,13 @@
  width: 100%;
 }
 .ui.menu .ui.input > .icon {
-  padding-top: 0em;
+  padding-top: 0.1em;
  height: auto;
 }
 .ui.menu .item > .input input,
 .ui.menu .item > input[type="text"] {
  position: relative;
-  top: -0.45em;
-  margin: 0em;
+  margin: -0.45em 0em;
  padding-top: 0.45em;
  padding-bottom: 0.45em;
 }
@ -453,10 +452,11 @@
 .ui.tiered.menu > .menu .item.active:after {
  position: absolute;
  content: '';
+  margin-top: -1px;
  top: 100%;
  left: 0px;
  width: 100%;
-  height: 1px;
+  height: 2px;
  background-color: #FBFBFB;
 }
 .ui.tiered.menu .sub.menu {
@ -578,7 +578,7 @@
 }
 .ui.pagination.menu .item {
  min-width: 2.7em;
-  min-height: 2.66em;
+  min-height: 2.7em;
  text-align: center;
 }
 .ui.pagination.menu.floated {
@ -1398,7 +1398,6 @@
 }
 .ui.menu .item {
  font-size: 1rem;
-  height: 2.66em;
 }
 .ui.vertical.menu {
  width: 15rem;
--- a/build/uncompressed/elements/icon.css
+++ b/build/uncompressed/elements/icon.css
@ -1424,16 +1424,13 @@ i.icon {
 }
 i.large.icon {
  font-size: 2em;
-  margin-right: 0.5em;
  vertical-align: middle;
 }
 i.huge.icon {
  font-size: 4em;
-  margin-right: 0.75em;
  vertical-align: middle;
 }
 i.massive.icon {
  font-size: 8em;
-  margin-right: 1em;
  vertical-align: middle;
 }
--- a/build/uncompressed/modules/dimmer.js
+++ b/build/uncompressed/modules/dimmer.js
@ -115,6 +115,7 @@ $.fn.dimmer = function(parameters) {
          ;
          $dimmer
            .off(eventNamespace)
+            .remove()
          ;
        },

--- a/node/src/documents/collections/menu.html.eco
+++ b/node/src/documents/collections/menu.html.eco
@ -37,7 +37,7 @@ type        : 'UI Collection'
        <i class="user icon"></i> Friends
      </a>
      <div class="right menu">
-        <div class="borderless item">
+        <div class="borderless vertically fitted item">
          <div class="ui icon input">
            <input type="text" placeholder="Search...">
            <i class="search link icon"></i>
@ -140,7 +140,7 @@ type        : 'UI Collection'
          <i class="mail icon"></i> Messages
        </a>
        <div class="right menu">
-          <div class="borderless item">
+          <div class="borderless vertically fitted item">
            <div class="ui icon input">
              <input type="text" placeholder="Search...">
              <i class="search icon"></i>
@ -812,7 +812,7 @@ type        : 'UI Collection'
        <i class="user icon"></i> Friends
      </a>
      <div class="right menu">
-        <div class="borderless item">
+        <div class="borderless vertically fitted item">
          <div class="ui icon input">
            <input type="text" placeholder="Search...">
            <i class="search link icon"></i>
@ -829,6 +829,25 @@ type        : 'UI Collection'
      </div>
    </div>
  </div>
+  <div class="another example">
+    <div class="ui small menu">
+      <a class="active item">
+        Inbox
+      </a>
+      <a class="item">
+        Spam
+      </a>
+      <a class="item">
+        Updates
+      </a>
+      <div class="item">
+        <div class="ui icon input">
+          <input type="text" placeholder="Search mail...">
+          <i class="search icon"></i>
+        </div>
+      </div>
+    </div>
+  </div>
  <div class="example">
    <p>A vertical menu can also vary in size</p>
    <div class="ui large vertical menu">
--- a/node/src/files/build/less/collections/menu.less.REMOVED.git-id
+++ b/node/src/files/build/less/collections/menu.less.REMOVED.git-id
@ -1 +1 @@
-ae5be9219aa61370d76209f2c0efe1730f7a4f8a
+938a77368926e4c24478b94333049fc8a2662ad5
--- a/node/src/files/build/less/elements/icon.less
+++ b/node/src/files/build/less/elements/icon.less
@ -756,16 +756,13 @@ i.icon {
 }
 i.large.icon {
  font-size: 2em;
-  margin-right: 0.5em;
  vertical-align: middle;
 }
 i.huge.icon {
  font-size: 4em;
-  margin-right: 0.75em;
  vertical-align: middle;
 }
 i.massive.icon {
  font-size: 8em;
-  margin-right: 1em;
  vertical-align: middle;
 }
--- a/node/src/files/build/less/modules/dimmer.js
+++ b/node/src/files/build/less/modules/dimmer.js
@ -115,6 +115,7 @@ $.fn.dimmer = function(parameters) {
          ;
          $dimmer
            .off(eventNamespace)
+            .remove()
          ;
        },

--- a/node/src/files/build/minified/modules/dimmer.js
+++ b/node/src/files/build/minified/modules/dimmer.js
@ -115,6 +115,7 @@ $.fn.dimmer = function(parameters) {
          ;
          $dimmer
            .off(eventNamespace)
+            .remove()
          ;
        },

--- a/node/src/files/build/packaged/css/semantic.css.REMOVED.git-id
+++ b/node/src/files/build/packaged/css/semantic.css.REMOVED.git-id
@ -1 +1 @@
-4d1a687e483032ac1b73bd5fb89fd157574e7a35
+f6954ada100fee5816c6469d55133bbaee195cb0
--- a/node/src/files/build/packaged/javascript/semantic.js.REMOVED.git-id
+++ b/node/src/files/build/packaged/javascript/semantic.js.REMOVED.git-id
@ -1 +1 @@
-cc8df66b4e0febc22293c8109ba70d035b958c5f
+263cdcca09a4b62ed0dfc6de95dab1efdf34eff3
--- a/node/src/files/build/uncompressed/collections/menu.css
+++ b/node/src/files/build/uncompressed/collections/menu.css
@ -173,14 +173,13 @@
  width: 100%;
 }
 .ui.menu .ui.input > .icon {
-  padding-top: 0em;
+  padding-top: 0.1em;
  height: auto;
 }
 .ui.menu .item > .input input,
 .ui.menu .item > input[type="text"] {
  position: relative;
-  top: -0.45em;
-  margin: 0em;
+  margin: -0.45em 0em;
  padding-top: 0.45em;
  padding-bottom: 0.45em;
 }
@ -453,10 +452,11 @@
 .ui.tiered.menu > .menu .item.active:after {
  position: absolute;
  content: '';
+  margin-top: -1px;
  top: 100%;
  left: 0px;
  width: 100%;
-  height: 1px;
+  height: 2px;
  background-color: #FBFBFB;
 }
 .ui.tiered.menu .sub.menu {
@ -578,7 +578,7 @@
 }
 .ui.pagination.menu .item {
  min-width: 2.7em;
-  min-height: 2.66em;
+  min-height: 2.7em;
  text-align: center;
 }
 .ui.pagination.menu.floated {
@ -1398,7 +1398,6 @@
 }
 .ui.menu .item {
  font-size: 1rem;
-  height: 2.66em;
 }
 .ui.vertical.menu {
  width: 15rem;
--- a/node/src/files/build/uncompressed/elements/icon.css
+++ b/node/src/files/build/uncompressed/elements/icon.css
@ -1424,16 +1424,13 @@ i.icon {
 }
 i.large.icon {
  font-size: 2em;
-  margin-right: 0.5em;
  vertical-align: middle;
 }
 i.huge.icon {
  font-size: 4em;
-  margin-right: 0.75em;
  vertical-align: middle;
 }
 i.massive.icon {
  font-size: 8em;
-  margin-right: 1em;
  vertical-align: middle;
 }
--- a/node/src/files/build/uncompressed/modules/dimmer.js
+++ b/node/src/files/build/uncompressed/modules/dimmer.js
@ -115,6 +115,7 @@ $.fn.dimmer = function(parameters) {
          ;
          $dimmer
            .off(eventNamespace)
+            .remove()
          ;
        },

--- a/node/src/files/stylesheets/semantic.css
+++ b/node/src/files/stylesheets/semantic.css
@ -177,7 +177,7 @@ a:hover {
  transition: margin 0.3s ease;
 }
 #example .main.menu iframe {
-  margin: 10px 0px 0px 0px;
+  margin: 0px 0px 0px 0px;
 }
 #example .main.menu .count {
 /*  font-size: 0.875em;
--- a/src/collections/menu.less.REMOVED.git-id
+++ b/src/collections/menu.less.REMOVED.git-id
@ -1 +1 @@
-ae5be9219aa61370d76209f2c0efe1730f7a4f8a
+938a77368926e4c24478b94333049fc8a2662ad5
--- a/src/elements/icon.less
+++ b/src/elements/icon.less
@ -756,16 +756,13 @@ i.icon {
 }
 i.large.icon {
  font-size: 2em;
-  margin-right: 0.5em;
  vertical-align: middle;
 }
 i.huge.icon {
  font-size: 4em;
-  margin-right: 0.75em;
  vertical-align: middle;
 }
 i.massive.icon {
  font-size: 8em;
-  margin-right: 1em;
  vertical-align: middle;
 }
--- a/src/modules/dimmer.js
+++ b/src/modules/dimmer.js
@ -115,6 +115,7 @@ $.fn.dimmer = function(parameters) {
          ;
          $dimmer
            .off(eventNamespace)
+            .remove()
          ;
        },