Browse Source

#2934, fix onRemove firing when no popup removed

pull/2942/head
Jack Lukic 9 years ago
parent
commit
6f4ac8697b
2 changed files with 3 additions and 2 deletions
  1. 1
      RELEASE-NOTES.md
  2. 4
      src/definitions/modules/popup.js

1
RELEASE-NOTES.md

@ -117,6 +117,7 @@
- **Menu** - Fix text align on `dropdown item` inside `icon menu`
- **Menu** - Fixed hybrid initialization not creating `menu` correctly. Fixed docs example of hybrid `<select>` initialization
- **Menu** - Fixed issue with `labeled input` text inside menu not appearing vertically centered
- **Popup** - Fixed `onRemove` firing even when popup is not removed
- **Reveal** - Reveal now uses `display: inherit` instead of forcing `inline-block`
### Version 2.0.8 - August 10, 2015

4
src/definitions/modules/popup.js

@ -342,12 +342,12 @@ $.fn.popup = function(parameters) {
},
removePopup: function() {
module.debug('Removing popup', $popup);
if( module.has.popup() && !settings.popup) {
module.debug('Removing popup', $popup);
$popup.remove();
$popup = undefined;
settings.onRemove.call($popup, element);
}
settings.onRemove.call($popup, element);
},
save: {

Loading…
Cancel
Save