Browse Source

Modal should clear screen height, updates release notes

pull/1407/head
jlukic 10 years ago
parent
commit
6db67c42d8
2 changed files with 14 additions and 3 deletions
  1. 12
      RELEASE-NOTES.md
  2. 5
      src/definitions/modules/modal.js

12
RELEASE-NOTES.md

@ -2,11 +2,19 @@
### Version 1.1.3 - December 03, 2014
**Enhancement**
- **Fonts** - Add font subset variable for ``site.variables`` **Thanks gabormeszoly**
- **Modal** - Default modal shadow now more subtle
- **Sidebar** - Now has aliases ``is open/closed`` for ``is visible/hidden``
- **Checkbox** - JS Checkbox now handles several variations of html. Labels can be before inputs, after, or not included at all.
**Bugs**
- **Modal** - Modals now use UUIDs to fix issues with multiple modals sometimes not closing dimmers
- **Modal** - When a second modal that is not scrolling is opened after a scrolling modal it no longer causes the first modal to not be scrollable
- **Modal** - "Hammer" clicking multiple times on a hiding dimmer no longer causes animation issues
- Item/Card - Default link formatting inside element simplified to avoid adjusting other nested ``ui`` link styles
- Dropdown - Fixes bug with dropdown converted from ``select`` that use ``<option`` values with capital letters not being selectable
**Enhancement**
- **Sidebar** - Now has aliases ``is open/closed`` for ``is visible/hidden``
### Version 1.1.2 - December 03, 2014

5
src/definitions/modules/modal.js

@ -217,7 +217,7 @@ $.fn.modal = function(parameters) {
}
},
click: function(event) {
if( $(event.target).closest(selector.modal).size() === 0 ) {
if( $(event.target).closest($module).size() === 0 ) {
module.debug('Dimmer clicked, hiding all modals');
module.remove.clickaway();
if( module.is.active() ) {
@ -562,6 +562,9 @@ $.fn.modal = function(parameters) {
.css('height', module.cache.height + settings.padding)
;
}
else {
$body.css('height', '');
}
},
active: function() {
$module.addClass(className.active);

Loading…
Cancel
Save