From 63561c514f7961f36d3de3246285fd1ab9d33f30 Mon Sep 17 00:00:00 2001 From: jlukic Date: Tue, 17 Mar 2015 15:30:17 -0400 Subject: [PATCH] Fix activator with settings.popup --- RELEASE-NOTES.md | 2 ++ src/definitions/modules/popup.js | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index cda078b16..4b31650ab 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -15,6 +15,7 @@ - **Grid** - `equal height` and `equal width` now work without `row` wrappers - **Grid** - `equal height` rows can now be `stretched` as well as `middle aligned`, `bottom aligned` and `top aligned`! - **Headers** - Added new header type `sub header`, useful for displaying small headers alongside text content. See examples [in the header docs](http://www.semantic-ui.com/elements/header.html#sub-headers) +- **Menu** - Added `stackable` menu variation for responsive menus - **Menu** - Added many new variables to menu - **Menu** - Horizontal menus now set a default image size for images / logos - **Menu** - Fixed several inheritance issues for `dropdown item` inside `menu` appearing as `menu item`. @@ -51,6 +52,7 @@ - **Grid** - `x column wide` inside `equal width/height` now cannot grow beyond column size - **Grid** - Fixes colored grid columns not appearing when not nested in rows - **Label** - Labels inside `header` now vertical align better by accounting for line height offset +- **Loader** - Fix position of `inline centered loader` to be centered correctly - **Message** - Message now uses `@lineHeight` from `site.variables` - **Modal** - `scrollable modal` now correctly adds padding below modal - **Modal** - Modal with `detachable: false` inside `ui sidebar` `pusher` element will now show correctly diff --git a/src/definitions/modules/popup.js b/src/definitions/modules/popup.js index 4cd7ff6eb..aa818798e 100644 --- a/src/definitions/modules/popup.js +++ b/src/definitions/modules/popup.js @@ -228,14 +228,14 @@ $.fn.popup = function(parameters) { else if($target.next(selector.popup).length !== 0) { module.verbose('Pre-existing popup found'); settings.inline = true; - settings.popup = $target.next(selector.popup).data(metadata.activator, $module); + settings.popups = $target.next(selector.popup).data(metadata.activator, $module); module.refresh(); if(settings.hoverable) { module.bind.popup(); } } else if(settings.popup) { - settings.popup.data(metadata.activator, $module); + $(settings.popup).data(metadata.activator, $module); module.verbose('Used popup specified in settings'); module.refresh(); if(settings.hoverable) {