From 625ef8ffc06ba7b21f083728930e0a8d8f1d44a7 Mon Sep 17 00:00:00 2001 From: jlukic Date: Mon, 5 Jan 2015 16:07:32 -0500 Subject: [PATCH] Fix issue #1569 #1564 #1560 - Popup issues in 1.5.x --- RELEASE-NOTES.md | 8 ++++++++ src/definitions/modules/dropdown.less | 10 +++++----- src/definitions/modules/popup.js | 4 ++-- src/definitions/modules/popup.less | 1 - 4 files changed, 15 insertions(+), 8 deletions(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index bafd36920..8a5e3d1cf 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -1,5 +1,13 @@ ## RELEASE NOTES + +### Version 1.5.3 - January 05, 2015 + +**Bugs** +- **Popup** - Fix issue with `ui popup` receiving error ``$offsetParent is undefined`` when using a pre-defined popup +- **Popup** - Fix issue with ``ui popup` not appearing with ``ui flowing popup`` due to newly added ``min-width: max-content`` +- **Form** - ``ui search dropdown`` inside a form has incorrect focus style + ### Version 1.5.2 - January 02, 2015 **Bugs** diff --git a/src/definitions/modules/dropdown.less b/src/definitions/modules/dropdown.less index cc1439c49..63493a318 100755 --- a/src/definitions/modules/dropdown.less +++ b/src/definitions/modules/dropdown.less @@ -481,13 +481,13 @@ select.ui.dropdown { /* Search Dropdown */ .ui.search.dropdown > input.search { - cursor: pointer; - background: none transparent; - border: none; - box-shadow: none; + background: none transparent !important; + border: none !important; + box-shadow: none !important; + border-radius: 0em !important; + cursor: pointer; position: absolute; - border-radius: 0em !important; top: 0em; left: 0em; width: 100%; diff --git a/src/definitions/modules/popup.js b/src/definitions/modules/popup.js index fe3478b9a..e73711887 100644 --- a/src/definitions/modules/popup.js +++ b/src/definitions/modules/popup.js @@ -116,9 +116,9 @@ $.fn.popup = function(parameters) { } if(settings.popup) { $popup.addClass(className.loading); - if($popup.offsetParent()[0] !== $module.offsetParent()[0]) { + $offsetParent = $module.offsetParent(); + if($popup.offsetParent()[0] !== $offsetParent[0]) { module.debug('Moving popup to the same offset parent as activating element'); - $offsetParent = $module.offsetParent(); $popup .detach() .appendTo($offsetParent) diff --git a/src/definitions/modules/popup.less b/src/definitions/modules/popup.less index 7d4d85f4d..ff02683b2 100755 --- a/src/definitions/modules/popup.less +++ b/src/definitions/modules/popup.less @@ -30,7 +30,6 @@ z-index: @zIndex; border: @border; - min-width: max-content; max-width: @maxWidth; background-color: @background;