From 619386ebbc714447e9c2ca4d50c7460ffcf98239 Mon Sep 17 00:00:00 2001 From: Jack Lukic Date: Wed, 1 Mar 2017 20:45:29 -0500 Subject: [PATCH] Fix dropdowns inside overflow containers --- RELEASE-NOTES.md | 8 ++++++++ src/definitions/modules/dropdown.js | 6 ++++++ 2 files changed, 14 insertions(+) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index bd7a31283..79d985af5 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -1,5 +1,13 @@ ## RELEASE NOTES +### Version 2.2.11 - February 21, 2017 + +**Bugs** + +- **Button** - Fixes `@basicActiveBoxShadow` being used incorrectly in basic button variables +- **Visibility** - Fixes issue where visibility events would occur improperly when using a `context` that have `overflow-x` or `overflow-y` set to `auto` +- **Dropdown** - Fixes an issue where dropdown would not correctly open `upward` at bottom edge of the screen when using a `context` with `overflow-x` or `overflow-y` set to `auto` + ### Version 2.2.10 - February 21, 2017 **Bugs** diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js index 9b8a682d5..2aa2ecf05 100644 --- a/src/definitions/modules/dropdown.js +++ b/src/definitions/modules/dropdown.js @@ -3069,6 +3069,9 @@ $.fn.dropdown = function(parameters) { height: $currentMenu.outerHeight() } }; + if(module.is.verticallyScrollableContext()) { + calculations.menu.offset.top += calculations.context.scrollTop; + } onScreen = { above : (calculations.context.scrollTop) <= calculations.menu.offset.top - calculations.menu.height, below : (calculations.context.scrollTop + calculations.context.height) >= calculations.menu.offset.top + calculations.menu.height @@ -3142,6 +3145,9 @@ $.fn.dropdown = function(parameters) { ? $subMenu.hasClass(className.visible) : $menu.hasClass(className.visible) ; + }, + verticallyScrollableContext: function() { + return $context.get(0) !== window && $context.css('overflow-y') == 'auto'; } },