Browse Source

#1754, Fixes namespace being called out of order in transition init

pull/1806/head
jlukic 9 years ago
parent
commit
5653f6ff09
2 changed files with 13 additions and 7 deletions
  1. 1
      RELEASE-NOTES.md
  2. 19
      src/definitions/modules/transition.js

1
RELEASE-NOTES.md

@ -14,6 +14,7 @@
- **All Modules** - Fixed bug where element `destroy` could remove third party events when re-initialized
- **Transition** - Transitions with direction now use word order dependency to prevent conflict with component directions, for example `bottom left popup slide down in transition`
- **Dropdown** - Upward dropdown now has upward arrow icon
- **Transition** - Fixes bug where `moduleNamespace` was being omitted
### Version 1.8.1 - January 26, 2015

19
src/definitions/modules/transition.js

@ -62,23 +62,28 @@ $.fn.transition = function() {
initialize: function() {
// get full settings
moduleNamespace = 'module-' + namespace;
settings = module.get.settings.apply(element, moduleArguments);
// shorthand
className = settings.className;
error = settings.error;
metadata = settings.metadata;
animationStart = module.get.animationStartEvent();
animationEnd = module.get.animationEndEvent();
animationName = module.get.animationName();
error = settings.error;
namespace = settings.namespace;
// define namespace
eventNamespace = '.' + settings.namespace;
instance = $module.data(moduleNamespace) || module;
moduleNamespace = 'module-' + settings.namespace;
// get vendor specific events
animationEnd = module.get.animationEndEvent();
animationName = module.get.animationName();
animationStart = module.get.animationStartEvent();
if(methodInvoked) {
methodInvoked = module.invoke(query);
}
// no internal method was found matching query or query not made
// method not invoked, lets run an animation
if(methodInvoked === false) {
module.verbose('Converted arguments into settings object', settings);
module.animate();

Loading…
Cancel
Save