diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 1f751c1f9..1a0e8aa37 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -2,12 +2,15 @@ ### Version 1.9.4 - February 21, 2015 -**Changes** +**Updates** - **Form Validation** - Adds `containsExactly`, `notExactly`, `isExactly` case sensitive validation rules, make `contains`, `not`, `is` case insensitive. - **Form Validation** - `contains` rule is now case insensitive - **Form Validation** - Validation messages no longer increase field height on `inline fields` like checkboxes after error appears -- **Build Tools** - Fixed issue with recursive merge for site themes in update scripts, [details here](https://github.com/Semantic-Org/Semantic-UI/pull/1845) Thanks @derekslife - **API** - Added `was cancelled` to determine whether request was cancelled by `beforeSend` + +**Bugs** +- **Build Tools** - Fixed issue with recursive merge for site themes in update scripts, [details here](https://github.com/Semantic-Org/Semantic-UI/pull/1845) Thanks @derekslife +- **Sidebar** - Sidebar using `exclusive: true` now queue animations after hiding previous sidebar (unless `overlay`) to avoid rendering issues - **State** - Text states now handle `cancelled` API requests correctly - **Search** - Category search no longer displays unnecessary error message about maxResults - **Composer** - Composer.json should now read version from tags, adjusted some fields. diff --git a/src/definitions/modules/sidebar.js b/src/definitions/modules/sidebar.js index 844b721e9..a420e3510 100644 --- a/src/definitions/modules/sidebar.js +++ b/src/definitions/modules/sidebar.js @@ -365,11 +365,20 @@ $.fn.sidebar = function(parameters) { settings.transition = 'overlay'; } module.refresh(); - if(module.othersActive() && module.get.transition() !== 'overlay') { + if(module.othersActive()) { module.debug('Other sidebars currently visible'); - settings.transition = 'overlay'; if(settings.exclusive) { - module.hideOthers(); + // if not overlay queue animation after hide + if(settings.transition != 'overlay') { + module.hideOthers(module.show); + return; + } + else { + module.hideOthers(); + } + } + else { + settings.transition = 'overlay'; } } animateMethod(function() { @@ -422,8 +431,7 @@ $.fn.sidebar = function(parameters) { sidebarCount = $otherSidebars.length, callbackCount = 0 ; - callback = callback || function(){}; - + callback = callback || function(){}; $otherSidebars .sidebar('hide', function() { callbackCount++;