Browse Source

Fix observe changes not working correctly in popup

slider
Jack Lukic 8 years ago
parent
commit
549e61f35e
2 changed files with 4 additions and 1 deletions
  1. 1
      RELEASE-NOTES.md
  2. 4
      src/definitions/modules/popup.js

1
RELEASE-NOTES.md

@ -27,6 +27,7 @@
- **Icon** - Fixes `talk` icon not working correctly **Thanks @anantogosh** #4354 - **Icon** - Fixes `talk` icon not working correctly **Thanks @anantogosh** #4354
- **Transition** - Removed unreachable code **Thanks @basarat** #4225 - **Transition** - Removed unreachable code **Thanks @basarat** #4225
- **Grid** - Fixed alignment in `centered justified grid** **Thanks @bretto36** #4224 - **Grid** - Fixed alignment in `centered justified grid** **Thanks @bretto36** #4224
- **Popup** - Fixed issue where `observeChanges: false` setting in popup would not prevent mutation observers
**Docs** **Docs**
- **Icons** - Fixed some duplicate icons (External) and mispelled icons (Dribbble) - **Icons** - Fixed some duplicate icons (External) and mispelled icons (Dribbble)

4
src/definitions/modules/popup.js

@ -88,7 +88,9 @@ $.fn.popup = function(parameters) {
if(!module.exists() && settings.preserve) { if(!module.exists() && settings.preserve) {
module.create(); module.create();
} }
module.observeChanges();
if(settings.observeChanges) {
module.observeChanges();
}
module.instantiate(); module.instantiate();
}, },

Loading…
Cancel
Save