From 506f96ffd77afff06b25522cdfa88650a6c1d779 Mon Sep 17 00:00:00 2001
From: Jack Lukic <jacklukic@gmail.com>
Date: Tue, 11 Aug 2015 18:52:51 -0400
Subject: [PATCH] #2754, fix issue with not using correct metadata setting for
 label value

---
 RELEASE-NOTES.md                    | 1 +
 src/definitions/modules/dropdown.js | 6 +++---
 src/definitions/modules/tab.js      | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index 547053ca7..1bec77e9c 100644
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -51,6 +51,7 @@
 - **Menu** - Fix text align on `dropdown item` inside `icon menu`
 - **Menu** - Fixed issue with `labeled input` text inside menu not appearing vertically centered
 - **Menu** - Fixed hybrid initialization not creating `menu` correctly. Fixed docs example of hybrid `<select>` initialization
+- **Dropdown/Tab** - Fixed an instance where `metadata` was not referencing settings metadata value
 
 **[Merged PR](https://github.com/Semantic-Org/Semantic-UI/issues?q=is%3Aissue+milestone%3A2.1.0+is%3Aclosed)**
 
diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js
index 0c6e1019d..bb12e5edf 100644
--- a/src/definitions/modules/dropdown.js
+++ b/src/definitions/modules/dropdown.js
@@ -634,7 +634,6 @@ $.fn.dropdown = function(parameters) {
             apiSettings = {
               errorDuration        : false,
               throttle             : settings.throttle,
-              cache                : 'local',
               urlData              : {
                 query: query
               },
@@ -999,7 +998,7 @@ $.fn.dropdown = function(parameters) {
                 var
                   $label            = $module.find(selector.label),
                   $activeLabel      = $label.filter('.' + className.active),
-                  activeValue       = $activeLabel.data('value'),
+                  activeValue       = $activeLabel.data(metadata.value),
                   labelIndex        = $label.index($activeLabel),
                   labelCount        = $label.length,
                   hasActiveLabel    = ($activeLabel.length > 0),
@@ -1363,6 +1362,7 @@ $.fn.dropdown = function(parameters) {
           },
 
           hide: function() {
+            module.set.value(value);
             module.hideAndClear();
           }
 
@@ -2596,7 +2596,7 @@ $.fn.dropdown = function(parameters) {
             $labels
               .each(function(){
                 var
-                  value       = $(this).data('value'),
+                  value       = $(this).data(metadata.value),
                   isUserValue = module.is.userValue(value)
                 ;
                 if(isUserValue) {
diff --git a/src/definitions/modules/tab.js b/src/definitions/modules/tab.js
index ee91e30b7..5e351d270 100644
--- a/src/definitions/modules/tab.js
+++ b/src/definitions/modules/tab.js
@@ -374,7 +374,7 @@ $.fn.tab = function(parameters) {
             else if(tabPath.search('/') == -1 && tabPath !== '') {
               // look for in page anchor
               $anchor     = $('#' + tabPath + ', a[name="' + tabPath + '"]');
-              currentPath = $anchor.closest('[data-tab]').data('tab');
+              currentPath = $anchor.closest('[data-tab]').data(metadata.tab);
               $tab        = module.get.tabElement(currentPath);
               // if anchor exists use parent tab
               if($anchor && $anchor.length > 0 && currentPath) {