From 49ae497bc990ada25b844d9b63b059e00daceac7 Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 25 Oct 2013 15:33:29 -0400 Subject: [PATCH] Fixes #277 falsey values are treated as undefined --- src/modules/dropdown.js | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/src/modules/dropdown.js b/src/modules/dropdown.js index b073e431b..e631a0bc4 100755 --- a/src/modules/dropdown.js +++ b/src/modules/dropdown.js @@ -266,7 +266,10 @@ $.fn.dropdown = function(parameters) { }, activate: function(text, value) { - value = value || text; + value = (value !== undefined) + ? value + : text + ; module.set.selected(value); module.set.value(value); module.hide(); @@ -274,7 +277,10 @@ $.fn.dropdown = function(parameters) { /* Deprecated */ auto: function(text, value) { - value = value || text; + value = (value !== undefined) + ? value + : text + ; module.set.selected(value); module.set.value(value); module.hide(); @@ -282,14 +288,20 @@ $.fn.dropdown = function(parameters) { /* Deprecated */ changeText: function(text, value) { - value = value || text; + value = (value !== undefined) + ? value + : text + ; module.set.selected(value); module.hide(); }, /* Deprecated */ updateForm: function(text, value) { - value = value || text; + value = (value !== undefined) + ? value + : text + ; module.set.selected(value); module.set.value(value); module.hide(); @@ -308,7 +320,10 @@ $.fn.dropdown = function(parameters) { var $selectedItem ; - value = value || module.get.value() || module.get.text(); + value = (value !== undefined) + ? value + : ( module.get.value() || module.get.text() ) + ; if(value) { $item .each(function() {