From 44837faf5793fdfc7394e9a0fbc3ced5e701d73e Mon Sep 17 00:00:00 2001 From: jlukic Date: Fri, 19 Feb 2016 02:11:23 -0500 Subject: [PATCH] #3712 - Fixed issue with rating firing onRate on initial load --- src/definitions/modules/rating.js | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/definitions/modules/rating.js b/src/definitions/modules/rating.js index 9a45f2fa5..e835ae941 100644 --- a/src/definitions/modules/rating.js +++ b/src/definitions/modules/rating.js @@ -48,6 +48,7 @@ $.fn.rating = function(parameters) { $module = $(this), $icon = $module.find(selector.icon), + initialLoad, module ; @@ -66,7 +67,9 @@ $.fn.rating = function(parameters) { else { module.disable(); } + module.set.initialLoad(); module.set.rating( module.get.initialRating() ); + module.remove.initialLoad(); module.instantiate(); }, @@ -170,6 +173,9 @@ $.fn.rating = function(parameters) { $module .off(eventNamespace) ; + }, + initialLoad: function() { + initialLoad = false; } }, @@ -189,6 +195,12 @@ $.fn.rating = function(parameters) { ; }, + is: { + initialLoad: function() { + return initialLoad; + } + }, + get: { initialRating: function() { if($module.data(metadata.rating) !== undefined) { @@ -236,7 +248,12 @@ $.fn.rating = function(parameters) { .addClass(className.active) ; } - settings.onRate.call(element, rating); + if(!module.is.initialLoad()) { + settings.onRate.call(element, rating); + } + }, + initialLoad: function() { + initialLoad = true; } }, @@ -432,6 +449,8 @@ $.fn.rating.settings = { maxRating : 4, clearable : 'auto', + fireOnInit : false, + onRate : function(rating){}, error : {