From 421845e3c68c11ac8549b4d945004788b0f7fe21 Mon Sep 17 00:00:00 2001 From: jlukic Date: Tue, 14 Apr 2015 11:42:19 -0400 Subject: [PATCH] Add #2113 Add accordion on event, update rlsnotes --- RELEASE-NOTES.md | 4 +++- src/definitions/modules/accordion.js | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 2c953be8b..faac6b958 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -14,8 +14,9 @@ **Major Changes** - **Colors** - Global colors defaults have been adjusted to improve contrast with white text +- **Multiple UI** - Many components now use flexbox, which means previous confusing fixes like `font-size: 0;` to remove [white-space from inline block](https://css-tricks.com/fighting-the-space-between-inline-block-elements/) have been removed. This means any element can be a direct child of `grid` or `menu`. - **Menu** - Menu now uses flexbox. This allows menu items to match each others heights regardless of each items content size. `right menu` content should now follow other menu content instead of preceding it (no longer uses float). -- **Grid** - grids are now all `equal height` by default, the `equal height` variation can safely be removed +- **Grid** - Grids are now `flexbox` and `equal height` by default, the `equal height` variation can safely be removed - **Transition** - Fallback javascript animations have been removed from some UI components like dropdown to reduce redundant code and filesizes. - **Form Validation** - Form validation now uses a single `settings` object like other modules. Using `(fields, settings)` will continue to work but will produce a deprecation notifications in `console` - **Form Validation** - Form validation now supports several validation for multiple @@ -26,6 +27,7 @@ **Enhancements** - **Accordion** - adds `onOpening` and `onClosing` callback (before animation) to go with `onOpen`, `onClose` (after animation) **Thanks @cluppric** +- **Accordion** - Added `on` setting for accordion trigger event - **Build Tools** - Adjusting `site.variables` will now rebuild all UI, instead of just `site.less` - **Divider** - `vertical divider` inside `ui grid` now accounts for column padding - **Dropdown** - Dropdowns now have `match` setting to specify whether to match on `text`, `value` or `both` diff --git a/src/definitions/modules/accordion.js b/src/definitions/modules/accordion.js index a88a1b443..fe2cf4856 100644 --- a/src/definitions/modules/accordion.js +++ b/src/definitions/modules/accordion.js @@ -105,7 +105,7 @@ $.fn.accordion = function(parameters) { events: function() { module.debug('Binding delegated events'); $module - .on('click' + eventNamespace, selector.trigger, module.event.click) + .on(settings.on + eventNamespace, selector.trigger, module.event.click) ; } }, @@ -547,6 +547,8 @@ $.fn.accordion.settings = { duration : 350, easing : 'easeOutQuad', + on : 'click', + onOpening : function(){}, onOpen : function(){}, onClosing : function(){},