From 403a37799030c246db46aa45302f0c915c17b610 Mon Sep 17 00:00:00 2001 From: Jack Date: Sun, 8 Jul 2018 17:00:14 -0700 Subject: [PATCH] Move deprecated icons before normal rules to prevent improper inheritance --- RELEASE-NOTES.md | 11 +++++++++++ src/themes/default/elements/icon.overrides | 21 +++++++++++---------- 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 7c383e3bf..96812b762 100755 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -5,6 +5,17 @@ **Bug Fixes** - **Search** - Passing in `cache: false` will now affect default settings for `apiSettings` when using a remote endpoint. Previously you would also have to pass in `apiSettings: { cache: false}` as well - **CSS** - Update LESS syntax to be compatible with LESS 3.0 **Thanks @sciyoshi** [#6447](https://github.com/Semantic-Org/Semantic-UI/pull/6447) +- **Icon** - Several icon names have been deprecated due to incompatibility with `transition in` and `transition out` used in animations. + +* `linkedin in` is now `linkedin alternate` +* `zoom in` is now `zoom-in` +* `zoom out` is now `zoom-out` +* `sign in` is now `sign-in` +* `sign in alternate` is now `sign-in alternate` +* `sign out` is now `sign-out` +* `sign out alternate` is now `sign-out alternate` +* `log out` is now `logout` +* `in cart` is now `in-cart` ### Version 2.3.2 - June 18, 2018 diff --git a/src/themes/default/elements/icon.overrides b/src/themes/default/elements/icon.overrides index ecb5bef23..6c10b6c9e 100644 --- a/src/themes/default/elements/icon.overrides +++ b/src/themes/default/elements/icon.overrides @@ -31,6 +31,17 @@ for instance `lemon icon` not `lemon outline icon` since there is only one lemon Icons *******************************/ +/* Deprecated *In/Out Naming Conflict) */ +i.icon.linkedin.in:before { content: "\f0e1"; } +i.icon.zoom.in:before { content: "\f00e"; } +i.icon.zoom.out:before { content: "\f010"; } +i.icon.sign.in:before { content: "\f2f6"; } +i.icon.sign.in.alternate:before { content: "\f2f6"; } +i.icon.in.cart:before { content: "\f218"; } +i.icon.log.out:before { content: "\f2f5"; } +i.icon.sign.out:before { content: "\f2f5"; } +i.icon.sign.out.alternate:before { content: "\f2f5"; } + /* Icons */ i.icon.\35 00px:before { content: "\f26e"; } i.icon.accessible.icon:before { content: "\f368"; } @@ -861,16 +872,6 @@ i.icon.yoast:before { content: "\f2b1"; } i.icon.youtube:before { content: "\f167"; } i.icon.youtube.square:before { content: "\f431"; } -/* Deprecated *In/Out Naming Conflict) */ -i.icon.linkedin.in:before { content: "\f0e1"; } -i.icon.zoom.in:before { content: "\f00e"; } -i.icon.sign.in.alternate:before { content: "\f2f6"; } -i.icon.in.cart:before { content: "\f218"; } -i.icon.zoom.out:before { content: "\f010"; } -i.icon.log.out:before { content: "\f2f5"; } -i.icon.sign.out:before { content: "\f2f5"; } -i.icon.sign.out.alternate:before { content: "\f2f5"; } - /* Aliases */ i.icon.chess.rock:before { content: "\f447"; } i.icon.ordered.list:before { content: "\f0cb"; }